You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-17] [$1000] IOS - Icon is not set when https://new.expensify.com is added to home screen on iOS devices #21064
changed the title [-][$1000] IOS - Icon is not set when https://new.expensify.com is added to home screen on iOS devices[/-][+][HOLD for payment 2023-07-17] [$1000] IOS - Icon is not set when https://new.expensify.com is added to home screen on iOS devices[/+]on Jul 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
No offending PR.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
This is going to be one-time bug, so the regression step should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
eh2077 commentedon Jun 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Icon is not set when https://new.expensify.com is added to home screen on iOS devices.
What is the root cause of that problem?
The root cause of this issue is that in file index.html, we didn't set
apple-touch-iconmeta tag there.What changes do you think we should make in order to solve the problem?
To fix this issue, we add following line before this line of web/index.html
And include the new icon in webpack file.
We'll also need to ask the design team to design an icon for it.
What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Jun 19, 2023
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 19, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Jun 22, 2023
@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jun 26, 2023
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.38 remaining items
[-][$1000] IOS - Icon is not set when https://new.expensify.com is added to home screen on iOS devices[/-][+][HOLD for payment 2023-07-17] [$1000] IOS - Icon is not set when https://new.expensify.com is added to home screen on iOS devices[/+]melvin-bot commentedon Jul 10, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 10, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-17. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
puneetlath commentedon Jul 11, 2023
Sent everyone Upwork offers.
mollfpr commentedon Jul 18, 2023
No offending PR.
This is going to be one-time bug, so the regression step should be enough.
Mobile Web Safari
Mobile Web Chrome
melvin-bot commentedon Jul 21, 2023
@puneetlath, @shawnborton, @marcochavezf, @mollfpr, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!
puneetlath commentedon Jul 24, 2023
Sorry for the delay here. All paid!