Skip to content

[HOLD for payment 2023-07-17] [$1000] IOS - Icon is not set when https://new.expensify.com is added to home screen on iOS devices #21064

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to https://new.expensify.com/ in iOS Safari
  2. Tap on share icon from toolbar
  3. Select Add to Home Screen option
  4. Tap Add on the following screen
  5. Observe the icon that gets added to Home Screen

Expected Result:

Home screen should show New Expensify icon

Actual Result:

A generic icon with letter 'N' is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29.2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1687197548.MP4
home.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: @aswin-s

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686538637077189

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01221dcc554041530c
  • Upwork Job ID: 1673346830813540352
  • Last Price Increase: 2023-06-26

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 19, 2023
  2. eh2077 commented on Jun 19, 2023

    @eh2077
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Icon is not set when https://new.expensify.com is added to home screen on iOS devices.

    What is the root cause of that problem?

    The root cause of this issue is that in file index.html, we didn't set apple-touch-icon meta tag there.

    What changes do you think we should make in order to solve the problem?

    To fix this issue, we add following line before this line of web/index.html

    <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">

    And include the new icon in webpack file.

    We'll also need to ask the design team to design an icon for it.

    What alternative solutions did you explore? (Optional)

    N/A

  3. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. melvin-bot commented on Jun 22, 2023

    @melvin-bot

    @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. removed their assignment
    on Jun 26, 2023
  7. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 26, 2023
  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 26, 2023
  9. melvin-bot commented on Jun 26, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. 38 remaining items

  11. changed the title [-][$1000] IOS - Icon is not set when https://new.expensify.com is added to home screen on iOS devices[/-] [+][HOLD for payment 2023-07-17] [$1000] IOS - Icon is not set when https://new.expensify.com is added to home screen on iOS devices[/+] on Jul 10, 2023
  12. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jul 10, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-07-17. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter @aswin-s
    • Contributor that fixed the issue @eh2077
    • Contributor+ that helped on the issue and/or PR @mollfpr

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. puneetlath commented on Jul 11, 2023

    @puneetlath
    Contributor

    Sent everyone Upwork offers.

  15. mollfpr commented on Jul 18, 2023

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    No offending PR.

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    This is going to be one-time bug, so the regression step should be enough.

    [@mollfpr] Determine if we should create a regression test for this bug.
    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Mobile Web Safari

    1. Navigate to https://staging.new.expensify.com/ in iOS Safari
    2. Tap on the share icon from the toolbar
    3. Select Add to Home Screen option
    4. Tap Add on the following screen
    5. Verify the Expensify icon that gets added to Home Screen
    6. Click the icon bookmark just added from Home Screen
    7. Verify that it opens https://new.expensify.com/

    Mobile Web Chrome

    1. Navigate to https://staging.new.expensify.com/ in Android Chrome
    2. Tap on three dot icon in the top right corner
    3. Select Add to Home Screen option
    4. Tap Add on the following screen
    5. Verify the Expensify icon that gets added to Home Screen
    6. Click the icon bookmark just added from Home Screen
    7. Verify that it opens https://new.expensify.com/
  16. melvin-bot commented on Jul 21, 2023

    @melvin-bot

    @puneetlath, @shawnborton, @marcochavezf, @mollfpr, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. puneetlath commented on Jul 24, 2023

    @puneetlath
    Contributor

    Sorry for the delay here. All paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions