You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-17] [$1000] Web - Request money option shouldn't be shown in the task report #21788
After task is created >> task details page will be will be show
Click on + button on the left of COMPOSER
Expected Result:
There should not be a request money option on a task
Actual Result:
When you reload the page you'll see a request money option.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.31-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
There is no Request Money option after creating new Task, but it appears after reloading
What is the root cause of that problem?
We are missing add participantAccountIDs in buildOptimisticTaskReport and after creating task, BE return data of the task report also doesn't contain participantAccountIDs.
After reloading, openReport API is called, report data of task is fully correct and then request option appears.
What changes do you think we should make in order to solve the problem?
We should add participantAccountIDs with the value [assigneeAccount] in buildOptimisticTaskReport to make report.participantAccountIDs correctly even if we don't reload the page.
What alternative solutions did you explore? (Optional)
@Christinadobrzyn I think this is an inconsistent bug. Request money option is hidden after create a task but after reloading task report page, request money option appears.
I still can't reproduce this - I think it has something to do with my Desktop app loading when I refresh. Either way there are several reports of this including - #21800
changed the title [-]Web - There is no Request Money option after creating new Task[/-][+][$1000] Web - There is no Request Money option after creating new Task[/+]on Jun 30, 2023
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Not a regression, but a miss during task report implementation.
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
No. Minor miss during implementation and regression test wouldn't be beneficial here.
Activity
dukenv0307 commentedon Jun 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is no Request Money option after creating new Task, but it appears after reloading
What is the root cause of that problem?
We are missing add
participantAccountIDsinbuildOptimisticTaskReportand after creating task, BE return data of the task report also doesn't containparticipantAccountIDs.App/src/libs/ReportUtils.js
Line 1760 in 09a7432
That makes
report.participantAccountIDsisundefinedand thengetMoneyRequestOptionsreturn an empty array.App/src/libs/ReportUtils.js
Lines 2136 to 2138 in 09a7432
After reloading, openReport API is called, report data of task is fully correct and then request option appears.
What changes do you think we should make in order to solve the problem?
We should add
participantAccountIDswith the value[assigneeAccount]inbuildOptimisticTaskReportto makereport.participantAccountIDscorrectly even if we don't reload the page.What alternative solutions did you explore? (Optional)
melvin-bot commentedon Jun 28, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jun 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Christinadobrzyn commentedon Jun 28, 2023
I think this is expected that Request Money doesn't show in a Task - asking https://expensify.slack.com/archives/C01SKUP7QR0/p1687967168926109
I'm not able to reproduce this in https://staging.new.expensify.com - asking in slack to test in staging instead of dev
dukenv0307 commentedon Jun 28, 2023
The title of issue is a little bit confused
@Christinadobrzyn I think this is an inconsistent bug. Request money option is hidden after create a task but after reloading task report page, request money option appears.
Christinadobrzyn commentedon Jun 28, 2023
Asking in slack if this can be reproduced in staging https://expensify.slack.com/archives/C049HHMV9SM/p1687969709649929?thread_ts=1687721973.756379&cid=C049HHMV9SM
situchan commentedon Jun 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is Request Money option on task report
What is the root cause of that problem?
There's no check if report type is task in
ReportUtils.getMoneyRequestOptionsWhat changes do you think we should make in order to solve the problem?
Add one more check here:
App/src/libs/ReportUtils.js
Lines 2187 to 2191 in 3b721c4
So if
isTaskReport(report)return []Christinadobrzyn commentedon Jun 30, 2023
I still can't reproduce this - I think it has something to do with my Desktop app loading when I refresh. Either way there are several reports of this including - #21800
The discussion is we don't want Request Money to be enabled with a task - https://expensify.slack.com/archives/C01GTK53T8Q/p1688073096458079
[-]Web - There is no Request Money option after creating new Task[/-][+][$1000] Web - There is no Request Money option after creating new Task[/+]46 remaining items
melvin-bot commentedon Jul 14, 2023
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 14, 2023
abdulrahuman5196 commentedon Jul 17, 2023
Not a regression, but a miss during task report implementation.
No. Minor miss during implementation and regression test wouldn't be beneficial here.
abdulrahuman5196 commentedon Jul 17, 2023
@Christinadobrzyn / @sonialiap BZ checklist is complete.
Payment processing could be started on this issue.
sonialiap commentedon Jul 20, 2023
@tranvantoan-qn Offer sent for reporting issue - paid ✔️
@situchan for fix (+bonus) - paid ✔️
@abdulrahuman5196 for review (+bonus) - paid ✔️