Skip to content

[Awaiting payment] [$1000] Web - Compose box is distorted and messages are not loaded on reload after expand in compose box #21881

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the NewExpensify app at https://staging.new.expensify.com
  2. Click on an existing compose box or create a new compose box from a chat or task
  3. Shift enter in compose box to enable expand button > press enter a few times to make the compose box window wide
  4. Click on expand button
  5. Reload and observe that expand button and + button in compose box are distorted and app does not load the chats

Expected Result:

App should load the chats and display expanded view on reload when we expand compose box and reload

Actual Result:

App does not load the chats and compose box is distorted when we expand compose box and reload

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3312.mp4
expand.reload.does.not.work.mp4

Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687948877344299

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cb137372e1458408
  • Upwork Job ID: 1674819530237825024
  • Last Price Increase: 2023-07-11

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 29, 2023
  2. melvin-bot commented on Jun 29, 2023

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jun 29, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)

    Not the dupe but might be related to:
    #15596
    #16078
    #19642

    - If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. samh-nl commented on Jun 30, 2023

    @samh-nl
    Contributor

    The problem is that this.props.isSidebarLoaded for some reason remains false in ReportScreen.js, despite it actually being true (the first value is used and then never refreshed). Sometimes I'm unable to reproduce and it all works fine. Ideas?

  5. Christinadobrzyn commented on Jun 30, 2023

    @Christinadobrzyn
    Contributor

    I can reproduce it - seems to only be affecting Mac/Chrome/Safari. Adding external label

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 30, 2023
  7. changed the title [-]Web - Compose box is distorted and messages are not loaded on reload after expand in compose box[/-] [+][$1000] Web - Compose box is distorted and messages are not loaded on reload after expand in compose box[/+] on Jun 30, 2023
  8. melvin-bot commented on Jun 30, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 30, 2023
  10. melvin-bot commented on Jun 30, 2023

    @melvin-bot

    Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

  11. melvin-bot commented on Jun 30, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  12. 94 remaining items

  13. aimane-chnaif commented on Sep 29, 2023

    @aimane-chnaif
    Contributor

    I am using upwork. 25% is fine if you think it's fair, though I expected higher percent as bug was fixed and PR was in mergeable state.

  14. Julesssss commented on Sep 29, 2023

    @Julesssss
    Contributor

    Yeah I agree. @Christinadobrzyn this was only not merged because our internal review was too slow. We should pay 100% IMO

  15. Christinadobrzyn commented on Sep 29, 2023

    @Christinadobrzyn
    Contributor

    Sounds good, sorry @aimane-chnaif I should've asked you what seemed fair.

    Payouts due:

    Issue Reporter: $250 @dhanashree-sawant (paid in Upwork with this job posting - now closed)
    Contributor: NA
    Contributor+: $1000 @aimane-chnaif (please accept the offer in this Upwork posting )

    Eligible for 50% #urgency bonus? N

    Upwork job is here.

  16. melvin-bot commented on Sep 29, 2023

    @melvin-bot

    📣 @perfectdev95! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  17. added and removed on Oct 2, 2023
  18. Julesssss commented on Oct 2, 2023

    @Julesssss
    Contributor

    Just awaiting payment now

  19. changed the title [-][HOLD - seeking underlying cause] [$1000] Web - Compose box is distorted and messages are not loaded on reload after expand in compose box[/-] [+][Awaiting payment] [$1000] Web - Compose box is distorted and messages are not loaded on reload after expand in compose box[/+] on Oct 2, 2023
  20. aimane-chnaif commented on Oct 2, 2023

    @aimane-chnaif
    Contributor

    @Christinadobrzyn accepted offer. thanks

  21. Christinadobrzyn commented on Oct 10, 2023

    @Christinadobrzyn
    Contributor

    Thanks @aimane-chnaif paid you in Upwork based on this payment plan - #21881 (comment)

    Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions