Skip to content

[HOLD for payment 2023-07-17] [$1000] Text "Invite new members" is jerked #22036

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any workspaces
  2. Go member
  3. Click invite, Observe that The word "Invite new member" is jerked, Easier see on the big screen

Expected Result:

The word "Invite member" is not jerked

Actual Result:

The word "Invite member" is not jerked

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-30.at.15.07.51.mov
2023-07-01.19.56.44.mov

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688112890310839

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c2fb2aaa7db7f478
  • Upwork Job ID: 1675919369069428736
  • Last Price Increase: 2023-07-03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 2, 2023
  2. melvin-bot commented on Jul 2, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Jul 2, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. puneetlath commented on Jul 2, 2023

    @puneetlath
    Contributor

    I don't really understand the bug report. Asked in the slack thread.

  5. puneetlath commented on Jul 3, 2023

    @puneetlath
    Contributor

    We chatted in the Slack thread and I think this issue stems from the fact that we don't push the invite members page on top of the existing page, like we do in all other scenarios. The page is just updated in-place.

    So I think we should update this to work like all other page in the right-hand-pane, where the new page slides in from the right on top of the existing page.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 3, 2023
  7. changed the title [-] Text "Invite new members" is jerked[/-] [+][$1000] Text "Invite new members" is jerked[/+] on Jul 3, 2023
  8. melvin-bot commented on Jul 3, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 3, 2023
  10. melvin-bot commented on Jul 3, 2023

    @melvin-bot

    Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

  11. melvin-bot commented on Jul 3, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  12. b4s36t4 commented on Jul 3, 2023

    @b4s36t4
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Text "Invite new members" is jerked

    What is the root cause of that problem?

    Although navigation and everything is going fine, the root issue causing the issue is the input we have inside the invite member page.

    If we observe closely that whenever we click on Invite the input is instantly getting focus which is kind of reason for the transition not to show.

    What changes do you think we should make in order to solve the problem?

    We should delay the focusing the input while rendering component, we should use the prop to delay focus.

    Take a look at here ->

    What alternative solutions did you explore? (Optional)

    NA

  13. 56 remaining items

  14. mountiny commented on Jul 20, 2023

    @mountiny
    Contributor

    @anmurali Puneet is ooo so to move this forward I have reassigned the bug zero

    The payments should be:

  15. mountiny commented on Jul 24, 2023

    @mountiny
    Contributor

    @anmurali This is ready for payment

  16. puneetlath commented on Jul 24, 2023

    @puneetlath
    Contributor

    I'm back and can take care of this. Thanks for the help while I was out!

  17. puneetlath commented on Jul 24, 2023

    @puneetlath
    Contributor

    All paid!

  18. b4s36t4 commented on Jul 24, 2023

    @b4s36t4
    Contributor

    @puneetlath i think this is eligible for urgency bonus? PR got merged with in 3 days, any issues?

  19. mountiny commented on Jul 24, 2023

    @mountiny
    Contributor

    @puneetlath Thats correct, apologies, the automation must failed here so there was no urgency comment and I did not look into this.

    it should be $1500 for @b4s36t4 and @s77rt

  20. puneetlath commented on Jul 24, 2023

    @puneetlath
    Contributor

    Whoops. Sent contracts for the missed bonus payments.

  21. puneetlath commented on Jul 25, 2023

    @puneetlath
    Contributor

    Bonuses paid. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions