You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-17] [$1000] Text "Invite new members" is jerked #22036
Click invite, Observe that The word "Invite new member" is jerked, Easier see on the big screen
Expected Result:
The word "Invite member" is not jerked
Actual Result:
The word "Invite member" is not jerked
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.35-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
We chatted in the Slack thread and I think this issue stems from the fact that we don't push the invite members page on top of the existing page, like we do in all other scenarios. The page is just updated in-place.
So I think we should update this to work like all other page in the right-hand-pane, where the new page slides in from the right on top of the existing page.
Activity
melvin-bot commentedon Jul 2, 2023
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)puneetlath commentedon Jul 2, 2023
I don't really understand the bug report. Asked in the slack thread.
puneetlath commentedon Jul 3, 2023
We chatted in the Slack thread and I think this issue stems from the fact that we don't push the invite members page on top of the existing page, like we do in all other scenarios. The page is just updated in-place.
So I think we should update this to work like all other page in the right-hand-pane, where the new page slides in from the right on top of the existing page.
[-] Text "Invite new members" is jerked[/-][+][$1000] Text "Invite new members" is jerked[/+]melvin-bot commentedon Jul 3, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01c2fb2aaa7db7f478
melvin-bot commentedon Jul 3, 2023
Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jul 3, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)b4s36t4 commentedon Jul 3, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Text "Invite new members" is jerked
What is the root cause of that problem?
Although navigation and everything is going fine, the root issue causing the issue is the input we have inside the invite member page.
If we observe closely that whenever we click on Invite the input is instantly getting focus which is kind of reason for the transition not to show.
What changes do you think we should make in order to solve the problem?
We should delay the focusing the input while rendering component, we should use the prop to delay focus.
Take a look at here ->
App/src/pages/workspace/WorkspaceInvitePage.js
Line 295 in e7a17f8
What alternative solutions did you explore? (Optional)
NA
56 remaining items
mountiny commentedon Jul 20, 2023
@anmurali Puneet is ooo so to move this forward I have reassigned the bug zero
The payments should be:
mountiny commentedon Jul 24, 2023
@anmurali This is ready for payment
puneetlath commentedon Jul 24, 2023
I'm back and can take care of this. Thanks for the help while I was out!
puneetlath commentedon Jul 24, 2023
All paid!
b4s36t4 commentedon Jul 24, 2023
@puneetlath i think this is eligible for urgency bonus? PR got merged with in 3 days, any issues?
mountiny commentedon Jul 24, 2023
@puneetlath Thats correct, apologies, the automation must failed here so there was no urgency comment and I did not look into this.
it should be $1500 for @b4s36t4 and @s77rt
puneetlath commentedon Jul 24, 2023
Whoops. Sent contracts for the missed bonus payments.
puneetlath commentedon Jul 25, 2023
Bonuses paid. Thanks again!