Skip to content

[HOLD for payment 2023-07-17] Chat -App crash after remove the member #22351

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. From userA, go to Settings > Workspaces
  2. Click on New workspace button
  3. Go to the #announce room and send a message
  4. Click on the room header
  5. Go to Settings > Welcome message
  6. Add any message and click on the save button
  7. Go to Settings > Workspaces >Members > Invite
  8. Invite userB
  9. From userB, go to #announce
  10. Hover over welcome message > click reply in thread option > 11. send a message in thread
  11. From userA, remove the userB from workspace

Expected Result:

App should not crash

Actual Result:

App crash for userB

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.37-3
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-06.at.9.59.35.PM.mov
Recording.3452.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688661191934669

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 6, 2023
  2. melvin-bot commented on Jul 6, 2023

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 6, 2023
  4. melvin-bot commented on Jul 6, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. changed the title [-]Web -App crash after remove the member[/-] [+]Chat -App crash after remove the member[/+] on Jul 6, 2023
  6. OSBotify commented on Jul 6, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. 51 remaining items

  8. lschurr commented on Jul 17, 2023

    @lschurr
    Contributor
  9. gadhiyamanan commented on Jul 17, 2023

    @gadhiyamanan
    Contributor

    @lschurr can you send me an offer, i don't have connects to apply

  10. situchan commented on Jul 17, 2023

    @situchan
    Contributor
  11. situchan commented on Jul 17, 2023

    @situchan
    Contributor

    If you can send direct offer, that would be much appreciated.
    profile link: https://www.upwork.com/freelancers/~01223f6e853d3d82b4

  12. lschurr commented on Jul 17, 2023

    @lschurr
    Contributor

    Could you both put your Upwork profile here?

  13. gadhiyamanan commented on Jul 17, 2023

    @gadhiyamanan
    Contributor
  14. lschurr commented on Jul 17, 2023

    @lschurr
    Contributor

    Great, I've sent invites to you both.

  15. gadhiyamanan commented on Jul 17, 2023

    @gadhiyamanan
    Contributor

    @lschurr applied, thanks!

  16. situchan commented on Jul 17, 2023

    @situchan
    Contributor

    Great, I've sent invites to you both.

    Accepted, thanks

  17. situchan commented on Jul 17, 2023

    @situchan
    Contributor

    @lschurr I maybe eligible for speed bonus as well

  18. lschurr commented on Jul 17, 2023

    @lschurr
    Contributor

    I think since this was a minor change, we would only pay the base pay - @chiragsalian - do you have thoughts on this?

  19. lschurr commented on Jul 18, 2023

    @lschurr
    Contributor

    Issued the bonus. All paid. Closing this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions