You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] [$1000] Chat - Area outside the group avatar is clickable #22445
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
We are using left for positioning/shifting avatars but the PressableWithoutFeedback itself is not shifted, which causes it to be clickable in both the original and shifted positions.
Okay so everyone so far has pointed to this line as the culprit, but as far as I can tell that hasn't been updated in 6 months. What happened in this staging deploy that caused things to break since it's working properly on production?
Activity
OSBotify commentedon Jul 7, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 7, 2023
Triggered auto assignment to @stitesExpensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.allroundexperts commentedon Jul 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Area outside the group avatar is clickable
What is the root cause of that problem?
The horizontal padding included here is considered to be part of the
Pressablewhen clicking on the avatar group.What changes do you think we should make in order to solve the problem?
We need to replace the padding here with margins.
If we want to keep on using the paddings, then we have to shift them to the wrapping component instead.
What alternative solutions did you explore? (Optional)
None
DrLoopFall commentedon Jul 8, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The area outside the group avatar is clickable
What is the root cause of that problem?
There are actually two problems here,
App/src/pages/home/report/ReportActionItemCreated.js
Line 76 in 60f4817
leftfor positioning/shifting avatars but thePressableWithoutFeedbackitself is not shifted, which causes it to be clickable in both the original and shifted positions.App/src/styles/StyleUtils.js
Line 906 in 60f4817
What changes do you think we should make in order to solve the problem?
Make individual avatars/row clickable.
Remove pressable from here
App/src/pages/home/report/ReportActionItemCreated.js
Line 74 in 60f4817
Wrap this with
PressableWithoutFeedbackApp/src/components/MultipleAvatars.js
Line 157 in 60f4817
or this
App/src/components/MultipleAvatars.js
Line 152 in 60f4817
We add
onPressprop inMultipleAvatarsWhat alternative solutions did you explore? (Optional)
Replace paddings with margins.
Use
margin-leftinstead ofleftfor positioning the avatar.We also need to update(or remove) the width
App/src/components/MultipleAvatars.js
Lines 138 to 144 in 60f4817
NOTE: In alternate solution this gap is still clickable.

situchan commentedon Jul 10, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - welcome area outside the group avatar is clickable
What is the root cause of that problem?
There are 2 root causes.
ReportActionItemCreatedavatarContainerStyleswidth. It was old logic to treat count of avatars as 4 if more than 4 but after [HOLD for payment 2023-07-17] [$2000] Feature Request: Update header for 6 person DMs to show all avatars #15929, they're wrapped into 2 lines so count is nowMath.ceil(icon length / 2). In above example, count is 3.What changes do you think we should make in order to solve the problem?
Based on above analysis,
App/src/pages/home/report/ReportActionItemCreated.js
Line 76 in 60f4817
After fix:

After fix:

stitesExpensify commentedon Jul 10, 2023
Okay so everyone so far has pointed to this line as the culprit, but as far as I can tell that hasn't been updated in 6 months. What happened in this staging deploy that caused things to break since it's working properly on production?
stitesExpensify commentedon Jul 10, 2023
Was it just something that was missed by this pr maybe? https://github.com/Expensify/App/pull/20512/files
44 remaining items
melvin-bot commentedon Jul 14, 2023
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 14, 2023
Christinadobrzyn commentedon Jul 14, 2023
Reassigning as I'm going ooo. @sonialiap This is just waiting for payment based on #22445 (comment) Thanks!
sonialiap commentedon Jul 20, 2023
Paid ✔️