Skip to content

[$1000] Dev: Web - After deleting a thread message, the message "You" briefly shows up in the LHN before disappearing #22487

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat
  2. Go to the "Assign task" section
  3. Enter a title and create task
  4. After creating Assign yourself that task
  5. Send a thread message and delete it
  6. Notice that the message "You" appears briefly in the LHN

Expected Result:

The message "You" should not appear in the LHN after deleting a thread message

Actual Result:

After deleting a thread message, the message "You" briefly shows up in the LHN before disappearing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev v1.3.38-3
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-07-08-at-21933-am_7euWaLII.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688765209026689

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b93ac0fe26c1d0de
  • Upwork Job ID: 1678417861188857856
  • Last Price Increase: 2023-07-24

Activity

  1. OSBotify commented on Jul 8, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jul 8, 2023

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. ayazhussain79 commented on Jul 8, 2023

    @ayazhussain79
    Contributor

    Updated Step 4:

    1. Open a chat
    2. Go to the "Assign task" section
    3. Enter a title and create task
    4. After creating Assign yourself that task
    5. Send a thread message and delete it
    6. Notice that the message "You" appears briefly in the LHN
  4. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 8, 2023
  5. melvin-bot commented on Jul 8, 2023

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. 32 remaining items

  7. hungvu193 commented on Jul 25, 2023

    @hungvu193
    Contributor

    Bump to review updated proposal @aimane-chnaif - thank you!

    @hungvu193's solution still doesn't work.

    Screenshot 2023-07-24 at 5 22 38 PM

    Thanks for your patience. You're right. I missed this case. I updated my proposal again
    #22487 (comment)

  8. bfitzexpensify commented on Jul 27, 2023

    @bfitzexpensify
    Contributor
  9. jjcoffee commented on Jul 28, 2023

    @jjcoffee
    Contributor

    Unable to repro on latest main.

  10. hungvu193 commented on Jul 28, 2023

    @hungvu193
    Contributor

    Yeah, I think it's fixed. We can close

  11. aimane-chnaif commented on Jul 28, 2023

    @aimane-chnaif
    Contributor

    @hungvu193 which PR do you think it's fixed by?

  12. hungvu193 commented on Jul 28, 2023

    @hungvu193
    Contributor

    This one #23341 @aimane-chnaif .
    It filtered the last visible action, similar my updated proposal.

  13. ayazhussain79 commented on Jul 28, 2023

    @ayazhussain79
    Contributor

    i have reported this bug 3 weeks ago so maybe a PR fixed this bug after i reported so am i eligible for reporting bonus ?

  14. melvin-bot commented on Jul 29, 2023

    @melvin-bot

    @bfitzexpensify @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

  15. bfitzexpensify commented on Jul 31, 2023

    @bfitzexpensify
    Contributor

    Great, closing this out. @ayazhussain79 since you reported the other bug that led to this fix, we wouldn't pay out the reporting bonus twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNeeds ReproductionReproducible steps needed

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions