Skip to content

[HOLD for payment 2023-07-26] [$1000] Dev: Clicking on task header sometimes opens assignee page #22498

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat
  2. Go to the "Assign task" section
  3. Enter a title and create task
  4. After creating click on task header somewhere

Expected Result:

Clicking on task header should not open assignee page

Actual Result:

Clicking on task header sometime open assignee page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev 1.3.38-3
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3517.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688771023484909

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0188e528004d0d6c31
  • Upwork Job ID: 1678461651273142272
  • Last Price Increase: 2023-07-10

Activity

  1. OSBotify commented on Jul 8, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jul 8, 2023

    @melvin-bot

    Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. hungvu193 commented on Jul 10, 2023

    @hungvu193
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Dev: Clicking on task header sometimes opens assignee page

    What is the root cause of that problem?

    We're wrapping our subTitle inside a Pressable that filled the width of the header here:

    <PressableWithoutFeedback
    onPress={() => {
    Navigation.navigate(ROUTES.getReportRoute(props.report.parentReportID));
    }}
    accessibilityLabel={parentNavigationSubtitle}
    accessibilityRole={CONST.ACCESSIBILITY_ROLE.LINK}
    >
    <Text
    style={[styles.optionAlternateText, styles.textLabelSupporting, styles.link]}
    numberOfLines={1}
    >
    {parentNavigationSubtitle}
    </Text>
    </PressableWithoutFeedback>

    Screenshot 2023-07-10 at 13 29 52

    Because of that, when user click on header, sometimes it will trigger the onPress function of the subTitle, which will open the
    assignee page.

    What changes do you think we should make in order to solve the problem?

    Instead of making it fill the width of the header, we should only make the subTitle clickable in its actual width.

    What alternative solutions did you explore? (Optional)

    N/A

  4. thienlnam commented on Jul 10, 2023

    @thienlnam
    Contributor

    Only reproducible on dev so removing blocker

  5. thienlnam commented on Jul 10, 2023

    @thienlnam
    Contributor

    Actually, with the latest task redesign I don't think this bug exists anymore. If by assignee page you mean the DM - that is expected

  6. ayazhussain79 commented on Jul 10, 2023

    @ayazhussain79
    Contributor

    @thienlnam this bug is on after new task redesign you can check that that is regression of this PR

  7. 23 remaining items

  8. tjferriss commented on Jul 12, 2023

    @tjferriss
    Contributor

    Assigning @jasperhuangg and un-assigning @yuwenmemon as Jasper is working on the PR.

  9. jasperhuangg commented on Jul 17, 2023

    @jasperhuangg
    Contributor

    The PR is on prod cc @tjferriss

    Let's get @ayazhussain79 paid out for reporting the bug and we should be good to close this out

  10. tjferriss commented on Jul 18, 2023

    @tjferriss
    Contributor

    @ayazhussain79 offer has been sent via Upworks

  11. ayazhussain79 commented on Jul 18, 2023

    @ayazhussain79
    Contributor

    @tjferriss offer accepted, Thank you

  12. tjferriss commented on Jul 18, 2023

    @tjferriss
    Contributor

    Payment has been sent.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 19, 2023
  14. changed the title [-][$1000] Dev: Clicking on task header sometimes opens assignee page[/-] [+][HOLD for payment 2023-07-26] [$1000] Dev: Clicking on task header sometimes opens assignee page[/+] on Jul 19, 2023
  15. melvin-bot commented on Jul 19, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jul 19, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-07-26. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions