You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-07-26] [$1000] Dev: Clicking on task header sometimes opens assignee page #22498
Clicking on task header should not open assignee page
Actual Result:
Clicking on task header sometime open assignee page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev 1.3.38-3 Reproducible in staging?: no Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$1000] Dev: Clicking on task header sometimes opens assignee page[/-][+][HOLD for payment 2023-07-26] [$1000] Dev: Clicking on task header sometimes opens assignee page[/+]on Jul 19, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-26. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Activity
OSBotify commentedon Jul 8, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 8, 2023
Triggered auto assignment to @yuwenmemon (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.hungvu193 commentedon Jul 10, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Dev: Clicking on task header sometimes opens assignee page
What is the root cause of that problem?
We're wrapping our subTitle inside a Pressable that filled the width of the header here:
App/src/pages/home/HeaderView.js
Lines 193 to 206 in 60f4817
Because of that, when user click on header, sometimes it will trigger the onPress function of the subTitle, which will open the
assignee page.
What changes do you think we should make in order to solve the problem?
Instead of making it fill the width of the header, we should only make the subTitle clickable in its actual width.
What alternative solutions did you explore? (Optional)
N/A
thienlnam commentedon Jul 10, 2023
Only reproducible on dev so removing blocker
thienlnam commentedon Jul 10, 2023
Actually, with the latest task redesign I don't think this bug exists anymore. If by assignee page you mean the DM - that is expected
ayazhussain79 commentedon Jul 10, 2023
@thienlnam this bug is on after new task redesign you can check that that is regression of this PR
23 remaining items
tjferriss commentedon Jul 12, 2023
Assigning @jasperhuangg and un-assigning @yuwenmemon as Jasper is working on the PR.
jasperhuangg commentedon Jul 17, 2023
The PR is on prod cc @tjferriss
Let's get @ayazhussain79 paid out for reporting the bug and we should be good to close this out
tjferriss commentedon Jul 18, 2023
@ayazhussain79 offer has been sent via Upworks
ayazhussain79 commentedon Jul 18, 2023
@tjferriss offer accepted, Thank you
tjferriss commentedon Jul 18, 2023
Payment has been sent.
[-][$1000] Dev: Clicking on task header sometimes opens assignee page[/-][+][HOLD for payment 2023-07-26] [$1000] Dev: Clicking on task header sometimes opens assignee page[/+]melvin-bot commentedon Jul 19, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 19, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-07-26. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue: