Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributorsInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staff
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Log out of NewDot
- Go to https://staging.new.expensify.com/concierge
- Verify that you are taken to the login screen
- Log in to NewDot with any account
Expected Result:
You're navigated to the concierge chat after login
Actual Result:
App crashes
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.38.3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6121132_Recording__5388.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01cdf0596ececb29a0
- Upwork Job ID: 1683603845958860801
- Last Price Increase: 2023-07-24
Metadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributorsInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staff

Activity
OSBotify commentedon Jul 8, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 8, 2023
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.c3024 commentedon Jul 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when navigating to Conceirge page via deeplink after login
What is the root cause of that problem?
In the navigateToConveirgeChat in Report.js, this is the condition
This Navigation has no function called getReportIDFromRoute, so app crashes
What changes do you think we should make in order to solve the problem?
We change that check to
francoisl commentedon Jul 10, 2023
@c3024 are you available to submit a PR for this please?
francoisl commentedon Jul 10, 2023
Since this is a deploy blocker, I'm going to submit a PR now.
c3024 commentedon Jul 10, 2023
@francoisl Sorry, I was sleeping and could not check the message. Would I be considered for payment for the proposal?
36 remaining items
melvin-bot commentedon Jul 24, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01cdf0596ececb29a0
melvin-bot commentedon Jul 24, 2023
Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.
alexpensify commentedon Jul 24, 2023
I'm confirming the payment amounts and will prepare them tomorrow. Sorry for the delay!
Upwork link for payment: https://www.upwork.com/jobs/~01cdf0596ececb29a0
alexpensify commentedon Jul 25, 2023
Alright, the payment process has started in Upwork. @c3024 please accept and I can complete the payment process.
Heads up, I didn't include the bonus because we just used the proposal, and an Expensify engineer implemented the code. Let me know if there are other questions.
@thesahindia - please update the checklist and within ND, please request payment + urgency bonus since you were involved in the review process.
c3024 commentedon Jul 25, 2023
Accepted the offer on Upwork @alexpensify
I understand, thanks.
alexpensify commentedon Jul 26, 2023
Here is the payment summary:
Upwork Job:
https://www.upwork.com/jobs/~01cdf0596ececb29a0
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment: #22502 (comment)
alexpensify commentedon Jul 26, 2023
The payment has been sent to @c3024 via Upwork.
@thesahindia please complete the checklist, so we can close this GH. Heads up, please request payment from @JmillsExpensify. Anu is currently OOO. Thank you!
thesahindia commentedon Jul 26, 2023
I will do it in the morning!
alexpensify commentedon Jul 28, 2023
@thesahindia any update on the checklist here? I'd like to close this out soon. Thank you!
thesahindia commentedon Jul 28, 2023
Ahh, I missed it somehow. We already have added a comment on the offending PR. We were using incorrect function. I don't think we need any change in the checklist and it doesn't need a regression test. So we don't have to do anything.
alexpensify commentedon Jul 31, 2023
Thank you for that update! I'm going to close this out now.
JmillsExpensify commentedon Sep 22, 2023
$1,500 payment for @thesahindia approved based on BZ summary.