Skip to content

[HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] Login - Crash when navigating to the concierge chat via deeplink after login #22502

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log out of NewDot
  2. Go to https://staging.new.expensify.com/concierge
  3. Verify that you are taken to the login screen
  4. Log in to NewDot with any account

Expected Result:

You're navigated to the concierge chat after login

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.38.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6121132_Recording__5388.mp4

Bug6121132_image__129_

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cdf0596ececb29a0
  • Upwork Job ID: 1683603845958860801
  • Last Price Increase: 2023-07-24

Activity

  1. OSBotify commented on Jul 8, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jul 8, 2023

    @melvin-bot

    Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. c3024 commented on Jul 9, 2023

    @c3024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    App crashes when navigating to Conceirge page via deeplink after login

    What is the root cause of that problem?

    In the navigateToConveirgeChat in Report.js, this is the condition

    if (!Navigation.getReportIDFromRoute()) {
                Navigation.navigate(ROUTES.REPORT);
            }
    

    This Navigation has no function called getReportIDFromRoute, so app crashes

    What changes do you think we should make in order to solve the problem?

    We change that check to

    if (!Navigation.getTopmostReportID()) {
                Navigation.navigate(ROUTES.REPORT);
            }
    
  4. francoisl commented on Jul 10, 2023

    @francoisl
    Contributor

    @c3024 are you available to submit a PR for this please?

  5. francoisl commented on Jul 10, 2023

    @francoisl
    Contributor

    Since this is a deploy blocker, I'm going to submit a PR now.

  6. c3024 commented on Jul 10, 2023

    @c3024
    Contributor

    @francoisl Sorry, I was sleeping and could not check the message. Would I be considered for payment for the proposal?

  7. 36 remaining items

  8. melvin-bot commented on Jul 24, 2023

    @melvin-bot
  9. melvin-bot commented on Jul 24, 2023

    @melvin-bot

    Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.

  10. alexpensify commented on Jul 24, 2023

    @alexpensify
    Contributor

    I'm confirming the payment amounts and will prepare them tomorrow. Sorry for the delay!

    Upwork link for payment: https://www.upwork.com/jobs/~01cdf0596ececb29a0

  11. alexpensify commented on Jul 25, 2023

    @alexpensify
    Contributor

    Alright, the payment process has started in Upwork. @c3024 please accept and I can complete the payment process.

    Heads up, I didn't include the bonus because we just used the proposal, and an Expensify engineer implemented the code. Let me know if there are other questions.


    @thesahindia - please update the checklist and within ND, please request payment + urgency bonus since you were involved in the review process.

  12. c3024 commented on Jul 25, 2023

    @c3024
    Contributor

    Accepted the offer on Upwork @alexpensify

    Heads up, I didn't include the bonus because we just used the proposal, and an Expensify engineer implemented the code

    I understand, thanks.

  13. alexpensify commented on Jul 26, 2023

    @alexpensify
    Contributor

    Here is the payment summary:

    • External issue reporter - N/A
    • Contributor that fixed the issue - @c3024 $1000
    • Contributor+ that helped on the issue and/or PR - @thesahindia $1500

    Upwork Job:
    https://www.upwork.com/jobs/~01cdf0596ececb29a0

    *If applicable, the bonuses will be applied on the final payment

    Extra Notes regarding payment: #22502 (comment)

  14. alexpensify commented on Jul 26, 2023

    @alexpensify
    Contributor

    The payment has been sent to @c3024 via Upwork.


    @thesahindia please complete the checklist, so we can close this GH. Heads up, please request payment from @JmillsExpensify. Anu is currently OOO. Thank you!

  15. thesahindia commented on Jul 26, 2023

    @thesahindia
    Member

    I will do it in the morning!

  16. alexpensify commented on Jul 28, 2023

    @alexpensify
    Contributor

    @thesahindia any update on the checklist here? I'd like to close this out soon. Thank you!

  17. thesahindia commented on Jul 28, 2023

    @thesahindia
    Member

    Ahh, I missed it somehow. We already have added a comment on the offending PR. We were using incorrect function. I don't think we need any change in the checklist and it doesn't need a regression test. So we don't have to do anything.

  18. alexpensify commented on Jul 31, 2023

    @alexpensify
    Contributor

    Thank you for that update! I'm going to close this out now.

  19. JmillsExpensify commented on Sep 22, 2023

    @JmillsExpensify
    Contributor

    $1,500 payment for @thesahindia approved based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringHelp WantedApply this label when an issue is open to proposals by contributorsInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions