You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - Background image on request money page looks clipped on high resolution screen #23477
Navigate to a request money page on a high resolution screen. Preferably above 1500px horizontal in resolution.
Scroll to the top of the conversation
Observe the background graphic
Expected Result:
Background image gets resized appropriately or gradually fades into solid background colour.
Actual Result:
Top edge of background image gets clipped off on high resolution screens.
Workaround:
UNknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.44-0 Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
Background image in report screen is clipped on large screens
What is the root cause of that problem?
The background image has set value for height which is 450 for large screens and 100% for width. When screen gets larger the image is exceeding its height and appearing as cropped.
What changes do you think we should make in order to solve the problem?
In default behavior the image is set to cover the whole area. I think this is a problem and we should change it to contain. We can do it by applying resizeMode="contain" on Image component, but it doesn't work in mobile and we should keep current behavior in mobile. So we can apply above changed based on props.isSmallScreenWidth
I should note that, this will change the default appearance of background image. But I think this way it looks better.
Notice that, before even on default screen image was zoomed in, and wasn't fully visible(two sides were out of screen). After above fix, even on default screen image appears fully as it is, which I think was expected behavior
Before:
After:
What alternative solutions did you explore? (Optional)
changed the title [-]Web - Background image on request money page looks clipped on high resolution screen[/-][+][$1000] Web - Background image on request money page looks clipped on high resolution screen[/+]on Jul 25, 2023
changed the title [-][HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - Background image on request money page looks clipped on high resolution screen[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - Background image on request money page looks clipped on high resolution screen[/+]on Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - Background image on request money page looks clipped on high resolution screen[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - Background image on request money page looks clipped on high resolution screen[/+]on Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
No. Not a regression. Seems to be the case for larger screens from start.
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
No. Not beneficial since it happens only of large screen devices.
Activity
melvin-bot commentedon Jul 24, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jul 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)alitoshmatov commentedon Jul 24, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Background image in report screen is clipped on large screens
What is the root cause of that problem?
The background image has set value for height which is 450 for large screens and 100% for width. When screen gets larger the image is exceeding its height and appearing as cropped.
What changes do you think we should make in order to solve the problem?
In default behavior the image is set to
coverthe whole area. I think this is a problem and we should change it tocontain. We can do it by applyingresizeMode="contain"onImagecomponent, but it doesn't work in mobile and we should keep current behavior in mobile. So we can apply above changed based onprops.isSmallScreenWidthApp/src/pages/home/report/ReportActionItemCreated.js
Line 65 in 87113e0
App/src/components/ReportActionItem/MoneyRequestView.js
Line 55 in b9d2df8
I should note that, this will change the default appearance of background image. But I think this way it looks better.
Notice that, before even on default screen image was zoomed in, and wasn't fully visible(two sides were out of screen). After above fix, even on default screen image appears fully as it is, which I think was expected behavior
Before:
After:
What alternative solutions did you explore? (Optional)
kadiealexander commentedon Jul 25, 2023
Reproduced:
[-]Web - Background image on request money page looks clipped on high resolution screen[/-][+][$1000] Web - Background image on request money page looks clipped on high resolution screen[/+]melvin-bot commentedon Jul 25, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017c719273b062400c
melvin-bot commentedon Jul 25, 2023
Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.
88 remaining items
[-][HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - Background image on request money page looks clipped on high resolution screen[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - Background image on request money page looks clipped on high resolution screen[/+]melvin-bot commentedon Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - Background image on request money page looks clipped on high resolution screen[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - Background image on request money page looks clipped on high resolution screen[/+]melvin-bot commentedon Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Oct 23, 2023
@aswin-s, @grgia, @abdulrahuman5196, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!
abdulrahuman5196 commentedon Oct 23, 2023
No. Not a regression. Seems to be the case for larger screens from start.
No. Not beneficial since it happens only of large screen devices.