Skip to content

[HOLD for payment 2023-10-02] [$1000] Add a mandatory route param to Navigation.goBack to prevent bugs #24291

Closed

Description

@neil-marcellini

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

Calling Navigation.goBack() in App without a route can cause problems since it will navigate to the wrong page if the desired page to go back to is not the last page in the navigation history.

Solution

Add a mandatory route param to Navigation.goBack so that the screen to navigate back to must be specified. Discussed in Slack here.

Platforms:

Which of our officially supported platforms is this issue occurring on?
All

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ee5e103f65c1a8fa
  • Upwork Job ID: 1688984859314130944
  • Last Price Increase: 2023-08-08
  • Automatic offers:
    • abdulrahuman5196 | Contributor | 26164451

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 8, 2023
  2. melvin-bot commented on Aug 8, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 8, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 8, 2023
  5. changed the title [-]Add a mandatory route param to Navigation.goBack to prevent bugs[/-] [+][$1000] Add a mandatory route param to Navigation.goBack to prevent bugs[/+] on Aug 8, 2023
  6. melvin-bot commented on Aug 8, 2023

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 8, 2023
  8. melvin-bot commented on Aug 8, 2023

    @melvin-bot

    Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

  9. melvin-bot commented on Aug 8, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  10. situchan commented on Aug 8, 2023

    @situchan
    Contributor

    Dupe of #22041?

  11. neil-marcellini commented on Aug 8, 2023

    @neil-marcellini
    ContributorAuthor

    No this is a general improvement coming from Slack. Oh lol but I do see that we're having parallel conversations.

  12. 58 remaining items

  13. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

    • when @Prince-Mendiratta got assigned: 2023-09-04 18:27:08 Z
    • when the PR got merged: 2023-09-20 08:48:05 UTC
    • days elapsed: 11

    On to the next one 🚀

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 25, 2023
  15. changed the title [-][$1000] Add a mandatory route param to Navigation.goBack to prevent bugs[/-] [+][HOLD for payment 2023-10-02] [$1000] Add a mandatory route param to Navigation.goBack to prevent bugs[/+] on Sep 25, 2023
  16. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-02. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  18. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav / @abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
    • [@mananjadhav / @abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mananjadhav / @abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mananjadhav / @abdulrahuman5196] Determine if we should create a regression test for this bug.
    • [@mananjadhav / @abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  19. sophiepintoraetz commented on Oct 1, 2023

    @sophiepintoraetz
    Contributor

    Payouts due:

    Issue Reporter: $250 N/A - Neil
    Splitting payment as per this comment here
    Contributor: $500 @abdulrahuman5196
    Contributor: $500 @Prince-Mendiratta
    Contributor+: $1000 @mananjadhav

    Eligible for 50% #urgency bonus? N

  20. mananjadhav commented on Oct 2, 2023

    @mananjadhav
    Collaborator

    We can treat this as a feature request, and not directly related to any specific feature here. We don't need a regression suite here as these can be covered in other features. We only changed by forcing an arg in the method call.

  21. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    $1,000 payment approved for @mananjadhav based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions