You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-02] [$1000] Add a mandatory route param to Navigation.goBack to prevent bugs #24291
Calling Navigation.goBack() in App without a route can cause problems since it will navigate to the wrong page if the desired page to go back to is not the last page in the navigation history.
Solution
Add a mandatory route param to Navigation.goBack so that the screen to navigate back to must be specified. Discussed in Slack here.
Platforms:
Which of our officially supported platforms is this issue occurring on?
All
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by:@neil-marcellini Slack conversation:
changed the title [-]Add a mandatory route param to Navigation.goBack to prevent bugs[/-][+][$1000] Add a mandatory route param to Navigation.goBack to prevent bugs[/+]on Aug 8, 2023
changed the title [-][$1000] Add a mandatory route param to Navigation.goBack to prevent bugs[/-][+][HOLD for payment 2023-10-02] [$1000] Add a mandatory route param to Navigation.goBack to prevent bugs[/+]on Sep 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
@mananjadhavdoes not require payment (Eligible for Manual Requests)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mananjadhav / @abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav / @abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav / @abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
We can treat this as a feature request, and not directly related to any specific feature here. We don't need a regression suite here as these can be covered in other features. We only changed by forcing an arg in the method call.
Activity
melvin-bot commentedon Aug 8, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 8, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Add a mandatory route param to Navigation.goBack to prevent bugs[/-][+][$1000] Add a mandatory route param to Navigation.goBack to prevent bugs[/+]melvin-bot commentedon Aug 8, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ee5e103f65c1a8fa
melvin-bot commentedon Aug 8, 2023
Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Aug 8, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)situchan commentedon Aug 8, 2023
Dupe of #22041?
neil-marcellini commentedon Aug 8, 2023
No this is a general improvement coming from Slack. Oh lol but I do see that we're having parallel conversations.
58 remaining items
melvin-bot commentedon Sep 20, 2023
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀
[-][$1000] Add a mandatory route param to Navigation.goBack to prevent bugs[/-][+][HOLD for payment 2023-10-02] [$1000] Add a mandatory route param to Navigation.goBack to prevent bugs[/+]melvin-bot commentedon Sep 25, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-02. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 25, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sophiepintoraetz commentedon Oct 1, 2023
Payouts due:
Issue Reporter: $250 N/A - Neil
Splitting payment as per this comment here
Contributor: $500 @abdulrahuman5196
Contributor: $500 @Prince-Mendiratta
Contributor+: $1000 @mananjadhav
Eligible for 50% #urgency bonus? N
mananjadhav commentedon Oct 2, 2023
We can treat this as a feature request, and not directly related to any specific feature here. We don't need a regression suite here as these can be covered in other features. We only changed by forcing an arg in the method call.
JmillsExpensify commentedon Oct 5, 2023
$1,000 payment approved for @mananjadhav based on BZ summary.