You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Payment Sep 25 [$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS #24341
changed the title [-]Workspaces - Visual flickering when navigating back to workspace list from a WS[/-][+][$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS[/+]on Aug 10, 2023
Please re-state the problem that we are trying to solve in this issue.
On ios/ Safari, when navigating back to the Workspace list from a particular workspaces' setting, there is a visual flickering and occasional movement of "New Workspace" text.
What is the root cause of that problem?
On moving between the Workspace list and Workspace Setting page, there is a change in the safe area background. When the Workspace setting page is unmounted, it is causing a slightly delayed re-render of the footer and safe area which is causing the 'flickering' effect.
What changes do you think we should make in order to solve the problem?
We need to inspect the state and find the root cause of the re-render. And ensure it does not perform the re-render when coming back from the workspace setting page.
What alternative solutions did you explore? (Optional)
I checked the transition effects on the footer and headerPageLayout and its child components to see what could have caused the re-render, but did not find anything.
Just doing Melvin's job for him (🙄) this was deployed to production 18 hours ago, so we can handle payment (assuming no regressions) September 25th 6:13PM GMT+8!
changed the title [-][$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS[/-][+]Payment Sep 25 [$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS[/+]on Sep 19, 2023
Just doing Melvin's job for him (🙄) this was deployed to production 18 hours ago, so we can handle payment (assuming no regressions) September 25th 6:13PM GMT+8!
@studentofcoding - here's the new job for you to apply to. It would help if you referenced your Upworks profile or GH handle so we can identify you and hire you directly.
@allroundexperts - I think you can raise a ND request for $1000 (potentially including the bonus if there are no regressions that arise).
@studentofcoding - here's the new job for you to apply to. It would help if you referenced your Upworks profile or GH handle so we can identify you and hire you directly.
@allroundexperts - I think you can raise a ND request for $1000 (potentially including the bonus if there are no regressions that arise).
Sure, the Upwork and GH handle are sended also within the Proposal @sophiepintoraetz
My current IOU report contains a lot of entries right now. The report can be paid only if ALL the entries are approved for payment. If one of the entry is on hold, the rest of the entries couldn't be paid as well. Hope that makes sense 😄
@studentofcoding - here's the new job for you to apply to. It would help if you referenced your Upworks profile or GH handle so we can identify you and hire you directly.
@allroundexperts - I think you can raise a ND request for $1000 (potentially including the bonus if there are no regressions that arise).
Anyway, I registered the GH and Upwork profile on another Issue a week ago too @sophiepintoraetz. But if it's still needed here, here are the details:
Activity
melvin-bot commentedon Aug 9, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 9, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)sophiepintoraetz commentedon Aug 10, 2023
I'm able to reproduce this and I think this is a design polish (but necessary)
RPReplay_Final1691647496.MP4
[-]Workspaces - Visual flickering when navigating back to workspace list from a WS[/-][+][$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS[/+]melvin-bot commentedon Aug 10, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01cbc57cc70a4d58dc
melvin-bot commentedon Aug 10, 2023
Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Aug 10, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)swakeert commentedon Aug 10, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
On ios/ Safari, when navigating back to the Workspace list from a particular workspaces' setting, there is a visual flickering and occasional movement of "New Workspace" text.
What is the root cause of that problem?
On moving between the Workspace list and Workspace Setting page, there is a change in the safe area background. When the Workspace setting page is unmounted, it is causing a slightly delayed re-render of the footer and safe area which is causing the 'flickering' effect.
What changes do you think we should make in order to solve the problem?
We need to inspect the state and find the root cause of the re-render. And ensure it does not perform the re-render when coming back from the workspace setting page.
What alternative solutions did you explore? (Optional)
I checked the transition effects on the footer and headerPageLayout and its child components to see what could have caused the re-render, but did not find anything.
Thanos30 commentedon Aug 10, 2023
I personally can't replicate it in my local environment, so that makes it hard to test. I found this which might be useful:
react-navigation/react-navigation#9530
74 remaining items
dangrous commentedon Sep 19, 2023
Just doing Melvin's job for him (🙄) this was deployed to production 18 hours ago, so we can handle payment (assuming no regressions) September 25th 6:13PM GMT+8!
[-][$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS[/-][+]Payment Sep 25 [$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS[/+]studentofcoding commentedon Sep 19, 2023
What a lazy Melvin! 😂
Thanks for this @dangrous !
sophiepintoraetz commentedon Sep 19, 2023
@studentofcoding - here's the new job for you to apply to. It would help if you referenced your Upworks profile or GH handle so we can identify you and hire you directly.
@allroundexperts - I think you can raise a ND request for $1000 (potentially including the bonus if there are no regressions that arise).
studentofcoding commentedon Sep 19, 2023
Sure, the Upwork and GH handle are sended also within the Proposal @sophiepintoraetz
allroundexperts commentedon Sep 19, 2023
Hi Sophie!
I'll do that on Sep 25 so that it does not block my current payment.
sophiepintoraetz commentedon Sep 19, 2023
Oh interesting, why would it do that??
allroundexperts commentedon Sep 19, 2023
My current
IOUreport contains a lot of entries right now. The report can be paid only if ALL the entries are approved for payment. If one of the entry is on hold, the rest of the entries couldn't be paid as well. Hope that makes sense 😄studentofcoding commentedon Sep 24, 2023
Anyway, I registered the GH and Upwork profile on another Issue a week ago too @sophiepintoraetz. But if it's still needed here, here are the details:
Contributor details
Your Expensify account email: yonathanevan@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01ca6ccb72fa9cc678
On another note, I think Upwork Job is still not accepted, thanks!
melvin-bot commentedon Sep 24, 2023
melvin-bot commentedon Sep 24, 2023
studentofcoding commentedon Sep 26, 2023
Looking forward for the Job acceptance on Upwork and Payment @sophiepintoraetz
Also, Share the context above, as it's on 50% Urgency bonuses
cc: @dangrous @allroundexperts
sophiepintoraetz commentedon Sep 26, 2023
Payouts due:
Issue Reporter: N/A (Applause)
Contributor: $1500 @studentofcoding
Contributor+: $1500 @allroundexperts
Eligible for 50% #urgency bonus? Y
JmillsExpensify commentedon Oct 5, 2023
$1,500 payment approved for @allroundexperts based on BZ summary.