Skip to content

Payment Sep 25 [$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS #24341

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the staging web link
  2. Go to Settings > Workspaces
  3. Select a workspace to open WS settings
  4. Go back to workspace list by tapping on the back button

Expected Result:

No visual issues / screen should slide smoothly

Actual Result:

Visual flickering on the button "New workspace" when going back to workspace list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.52.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6159271_RPReplay_Final1691599332__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cbc57cc70a4d58dc
  • Upwork Job ID: 1689518567778115584
  • Last Price Increase: 2023-08-24

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 9, 2023
  2. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. sophiepintoraetz commented on Aug 10, 2023

    @sophiepintoraetz
    Contributor

    I'm able to reproduce this and I think this is a design polish (but necessary)

    RPReplay_Final1691647496.MP4
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 10, 2023
  6. changed the title [-]Workspaces - Visual flickering when navigating back to workspace list from a WS[/-] [+][$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS[/+] on Aug 10, 2023
  7. melvin-bot commented on Aug 10, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 10, 2023
  9. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  11. swakeert commented on Aug 10, 2023

    @swakeert

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On ios/ Safari, when navigating back to the Workspace list from a particular workspaces' setting, there is a visual flickering and occasional movement of "New Workspace" text.

    What is the root cause of that problem?

    On moving between the Workspace list and Workspace Setting page, there is a change in the safe area background. When the Workspace setting page is unmounted, it is causing a slightly delayed re-render of the footer and safe area which is causing the 'flickering' effect.

    What changes do you think we should make in order to solve the problem?

    We need to inspect the state and find the root cause of the re-render. And ensure it does not perform the re-render when coming back from the workspace setting page.

    What alternative solutions did you explore? (Optional)

    I checked the transition effects on the footer and headerPageLayout and its child components to see what could have caused the re-render, but did not find anything.

  12. Thanos30 commented on Aug 10, 2023

    @Thanos30
    Contributor

    I personally can't replicate it in my local environment, so that makes it hard to test. I found this which might be useful:

    react-navigation/react-navigation#9530

  13. 74 remaining items

  14. dangrous commented on Sep 19, 2023

    @dangrous
    Contributor

    Just doing Melvin's job for him (🙄) this was deployed to production 18 hours ago, so we can handle payment (assuming no regressions) September 25th 6:13PM GMT+8!

  15. changed the title [-][$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS[/-] [+]Payment Sep 25 [$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS[/+] on Sep 19, 2023
  16. studentofcoding commented on Sep 19, 2023

    @studentofcoding
    Contributor

    Just doing Melvin's job for him (🙄) this was deployed to production 18 hours ago, so we can handle payment (assuming no regressions) September 25th 6:13PM GMT+8!

    What a lazy Melvin! 😂

    Thanks for this @dangrous !

  17. sophiepintoraetz commented on Sep 19, 2023

    @sophiepintoraetz
    Contributor

    @studentofcoding - here's the new job for you to apply to. It would help if you referenced your Upworks profile or GH handle so we can identify you and hire you directly.

    @allroundexperts - I think you can raise a ND request for $1000 (potentially including the bonus if there are no regressions that arise).

  18. studentofcoding commented on Sep 19, 2023

    @studentofcoding
    Contributor

    @studentofcoding - here's the new job for you to apply to. It would help if you referenced your Upworks profile or GH handle so we can identify you and hire you directly.

    @allroundexperts - I think you can raise a ND request for $1000 (potentially including the bonus if there are no regressions that arise).

    Sure, the Upwork and GH handle are sended also within the Proposal @sophiepintoraetz

  19. allroundexperts commented on Sep 19, 2023

    @allroundexperts
    Contributor

    Hi Sophie!
    I'll do that on Sep 25 so that it does not block my current payment.

  20. sophiepintoraetz commented on Sep 19, 2023

    @sophiepintoraetz
    Contributor

    so that it does not block my current payment.

    Oh interesting, why would it do that??

  21. allroundexperts commented on Sep 19, 2023

    @allroundexperts
    Contributor

    Oh interesting, why would it do that??

    My current IOU report contains a lot of entries right now. The report can be paid only if ALL the entries are approved for payment. If one of the entry is on hold, the rest of the entries couldn't be paid as well. Hope that makes sense 😄

  22. studentofcoding commented on Sep 24, 2023

    @studentofcoding
    Contributor

    @studentofcoding - here's the new job for you to apply to. It would help if you referenced your Upworks profile or GH handle so we can identify you and hire you directly.

    @allroundexperts - I think you can raise a ND request for $1000 (potentially including the bonus if there are no regressions that arise).

    Anyway, I registered the GH and Upwork profile on another Issue a week ago too @sophiepintoraetz. But if it's still needed here, here are the details:

    Contributor details
    Your Expensify account email: yonathanevan@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01ca6ccb72fa9cc678

    On another note, I think Upwork Job is still not accepted, thanks!

  23. melvin-bot commented on Sep 24, 2023

    @melvin-bot

    ⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

  24. melvin-bot commented on Sep 24, 2023

    @melvin-bot

    ⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

  25. studentofcoding commented on Sep 26, 2023

    @studentofcoding
    Contributor

    Leave this here for a context of merging within 3 days (or on 1 Sept) but it got delayed as Merge Freeze

    #26172 (comment) Screenshot 2023-09-12 at 22 07 16

    Looking forward for the Job acceptance on Upwork and Payment @sophiepintoraetz

    Also, Share the context above, as it's on 50% Urgency bonuses

    cc: @dangrous @allroundexperts

  26. sophiepintoraetz commented on Sep 26, 2023

    @sophiepintoraetz
    Contributor

    Payouts due:

    Issue Reporter: N/A (Applause)
    Contributor: $1500 @studentofcoding
    Contributor+: $1500 @allroundexperts

    Eligible for 50% #urgency bonus? Y

  27. JmillsExpensify commented on Oct 5, 2023

    @JmillsExpensify
    Contributor

    $1,500 payment approved for @allroundexperts based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions