Skip to content

[HOLD for payment 2023-09-21] [$1000] Add avatar details to the Lounge Access Page #24381

Closed

Description

@thienlnam

To help identify customers and address #nocreeps violations, we're going to add the avatar to the lounge access page for when users check in.

  1. Update the lounge access page to include the avatar, display name, and login like this mockup

image

Internal issue

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cb19c0e49400d07e
  • Upwork Job ID: 1689690079128702976
  • Last Price Increase: 2023-08-31
  • Automatic offers:
    • Pujan92 | Contributor | 26439127

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    NewFeatureSomething to build that is a new item.
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 10, 2023
  2. melvin-bot commented on Aug 10, 2023

    @melvin-bot
  3. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  4. changed the title [-]Add avatar details to the Lounge Access Page[/-] [+][$1000] Add avatar details to the Lounge Access Page[/+] on Aug 10, 2023
  5. melvin-bot commented on Aug 10, 2023

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 10, 2023
  7. melvin-bot commented on Aug 10, 2023

    @melvin-bot

    Triggered auto assignment to @tjferriss (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  8. 126 remaining items

  9. puneetlath commented on Sep 22, 2023

    @puneetlath
    Contributor

    @Pujan92 has been paid. @Santhosh-Sellavel please open a NewDot request and let me know when you have so that I can close out this issue.

    Thanks everyone!

  10. Pujan92 commented on Sep 22, 2023

    @Pujan92
    Contributor

    @puneetlath just to make a point for the urgency bonus, @roryabraham approved the PR within 3 working days and later it was delayed due to merge freeze. I know @Santhosh-Sellavel approved it a bit late without any additional change, which might be due to unavailability. So don't know whether it falls in the urgency bonus criteria or not.

  11. puneetlath commented on Sep 25, 2023

    @puneetlath
    Contributor

    @Santhosh-Sellavel bump on creating the NewDot request!

    @Pujan92 I think based on what we had previously announced, this would not qualify for the urgency bonus in that case.

  12. Santhosh-Sellavel commented on Sep 25, 2023

    @Santhosh-Sellavel
    Collaborator

    @puneetlath Can you add a payment summary here, so I can proceed with the request!

  13. Santhosh-Sellavel commented on Sep 25, 2023

    @Santhosh-Sellavel
    Collaborator

    @puneetlath Requested $1000 On ND, please leave a summary when you get a chance thanks!

  14. puneetlath commented on Sep 26, 2023

    @puneetlath
    Contributor

    Payment summary:

    Closing!

  15. parasharrajat commented on Sep 26, 2023

    @parasharrajat
    Member

    Hey everyone, great work on http://localhost:8082/settings/profile/lounge-access screen. But I see that does not match with the required mockups in the #24381 (comment).

    The avatar size is smaller than the mockups.

    This is the web.

    Screenshot 2023-09-26 at 10 06 25 PM

    Is there some discussion that I missed?

    cc: @shawnborton @Santhosh-Sellavel @Pujan92

  16. shawnborton commented on Sep 27, 2023

    @shawnborton
    Contributor

    I guess the avatar size is just using the standard 80x80 size we have elsewhere. I would have liked to have updated the global "big avatar" size everywhere, to something more like 100x100 to fill the space a bit better - not just here, but when viewing someone's profile, viewing room details, etc.

    I think we can just do a separate issue for that as a different project. cc @Expensify/design for visibility.

  17. parasharrajat commented on Sep 27, 2023

    @parasharrajat
    Member

    Thanks for your input. That works.

  18. JmillsExpensify commented on Sep 28, 2023

    @JmillsExpensify
    Contributor

    $1,000 payment approved for @Santhosh-Sellavel based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions