You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-10] [$1000] Web - Chat - Deleted message can be undo when in editing mode #24445
We have 2 delete cases while drafting the message:
Case 1: Delete the first message in a thread while the parent report is drafted edit
Case 2: Delete the message while drafting edit in the thread
In both cases, we have not clear draftMessage when deleting the message
In addition, we also have the case of using 2 devices and deleting the message on 1 device, we also need to delete the draft message in this case.
What changes do you think we should make in order to solve the problem?
We should clear draftMessage when deleting the message in successDatahere:
changed the title [-]Web - Chat - Deleted message can be undo when in editing mode[/-][+][$1000] Web - Chat - Deleted message can be undo when in editing mode[/+]on Aug 14, 2023
Link to the PR: This is not a regression, We have not synchronized the editing of the parent message and the top message within the thread from the initial implementation of the thread.
Determine if we should create a regression test for this bug: 🟢
Regression Test Proposal
Open the same account on two devices.
On both devices, open the same report.
On device 1, send a message.
On device 2, reply to the message in a new thread.
Within the thread, edit the message but do not save it.
On device 1 deletes that message.
On device 2, verify that the edited message exit the editing mode and displays [delete message]
@kadiealexander Sorry for the inconvenience, but all i have to do is clicking the apply now button or I have to do anything else as a reporter
Thanks for your patience
Activity
namhihi237 commentedon Aug 11, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The message should be deleted even in editing mode
What is the root cause of that problem?
Conditions to show edit message here
We have 2 delete cases while drafting the message:
Case 1: Delete the first message in a thread while the parent report is drafted edit
Case 2: Delete the message while drafting edit in the thread
In both cases, we have not clear draftMessage when deleting the message
In addition, we also have the case of using 2 devices and deleting the message on 1 device, we also need to delete the draft message in this case.
What changes do you think we should make in order to solve the problem?
We should clear draftMessage when deleting the message in
successDatahere:In the case we use 2 devices, we should check whether the message was deleted or not and clear the draft message of reportAction in here .
Result:
Case use on 2 devices online
https://github.com/Expensify/App/assets/39086067/0432925f-659c-4d0a-8739-7c5460f74c17
Case 2 devices but 1 device offline after going online
Screen.Recording.2023-08-16.at.00.16.48.mov
Case 1 device and offline:
Screen.Recording.2023-08-16.at.00.27.48.mov
What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Aug 11, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Web - Chat - Deleted message can be undo when in editing mode[/-][+][$1000] Web - Chat - Deleted message can be undo when in editing mode[/+]melvin-bot commentedon Aug 14, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ad60e1290e36e223
melvin-bot commentedon Aug 14, 2023
Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Aug 14, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)kadiealexander commentedon Aug 14, 2023
Not overdue!
46 remaining items
kadiealexander commentedon Oct 13, 2023
Payouts due:
Eligible for 50% #urgency bonus? No
Upwork job is here.
kadiealexander commentedon Oct 13, 2023
@RickyMasha please apply here - https://www.upwork.com/jobs/~014a63052d4722b668
@fedirjh please complete the checklist and accept the contract I sent over
@namhihi237 please accept the contract I sent over
namhihi237 commentedon Oct 13, 2023
@kadiealexander aceepted ,thanks
fedirjh commentedon Oct 13, 2023
BugZero Checklist:
Regression Test Proposal
[delete message]RickyMasha commentedon Oct 13, 2023
@kadiealexander Sorry for the inconvenience, but all i have to do is clicking the
apply nowbutton or I have to do anything else as a reporterThanks for your patience
kadiealexander commentedon Oct 16, 2023
Just clicking "apply now" is fine :)
RickyMasha commentedon Oct 16, 2023
@kadiealexander Thanks, applied
kadiealexander commentedon Oct 17, 2023
@RickyMasha I haven't received your proposal in Upwork, please take a look and apply again here https://www.upwork.com/jobs/~014a63052d4722b668
RickyMasha commentedon Oct 17, 2023
@kadiealexander I just submitted the proposal for reporting this bug. Thank for your time
kadiealexander commentedon Oct 19, 2023
@RickyMasha Sent you an offer :)