Skip to content

[HOLD for payment 2023-10-09] [TS migration] Migrate 'CloseAccount.js' lib to TypeScript #24843

Closed

Description

@melvin-bot

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/actions/CloseAccount.js 3

Activity

  1. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    Author

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  2. blazejkustra commented on Sep 13, 2023

    @blazejkustra
    Contributor

    Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

  3. melvin-bot commented on Sep 25, 2023

    @melvin-bot
    Author

    Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  4. 10 remaining items

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 11, 2023
  6. melvin-bot commented on Oct 11, 2023

    @melvin-bot
    Author

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. melvin-bot commented on Oct 11, 2023

    @melvin-bot
    Author

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. neil-marcellini commented on Oct 11, 2023

    @neil-marcellini
    Contributor

    @zanyrenney would you please handle payment for this issue 🙏

  9. zanyrenney commented on Oct 16, 2023

    @zanyrenney
    Contributor

    Hi @neil-marcellini

    A few things:

    1. I am not seeing any linked bug fix - can you confirm what you're suggesting the payment is for?
    2. I am also not seeing a related upwork job so it's hard to see what this is for / what role the contributor played
    3. The contributor above says they are from an expert agency, so these are paid via invoice, not by BZ team.

    Thanks in advance for those details so I can help.

  10. neil-marcellini commented on Oct 16, 2023

    @neil-marcellini
    Contributor
    • I am not seeing any linked bug fix - can you confirm what you're suggesting the payment is for?

    This is part of the Typescript migration project. I requested help on payment because I thought a C+ reviewed the PR, but it looks like it was actually a contributor for an agency hired for this project.

    • I am also not seeing a related upwork job so it's hard to see what this is for / what role the contributor played

    Yeah understandable.

    • The contributor above says they are from an expert agency, so these are paid via invoice, not by BZ team.

    Ok then I think we're all set. Thanks for asking the right questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2TaskTypescript Migration

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions