Skip to content

[HOLD for payment 2024-03-13] [TS migration] Migrate 'Image' component to TypeScript #25107

Closed

Description

@melvin-bot

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/Image/resizeModes.js 0
src/components/Image/index.native.js 8
src/components/Image/index.js 8
src/components/Image/imagePropTypes.js 3
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c05b96f4228ff513
  • Upwork Job ID: 1727289054088720384
  • Last Price Increase: 2023-11-22

Activity

  1. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    Author

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  2. JKobrynski commented on Nov 9, 2023

    @JKobrynski
    Contributor

    Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

  3. JKobrynski commented on Nov 20, 2023

    @JKobrynski
    Contributor

    The PR is ready for review!

  4. added
    InternalRequires API changes or must be handled by Expensify staff
    on Nov 22, 2023
  5. melvin-bot commented on Nov 22, 2023

    @melvin-bot
    Author
  6. 15 remaining items

  7. melvin-bot commented on Feb 29, 2024

    @melvin-bot
    Author

    Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 6, 2024
  9. changed the title [-][TS migration] Migrate 'Image' component to TypeScript[/-] [+][HOLD for payment 2024-03-13] [TS migration] Migrate 'Image' component to TypeScript[/+] on Mar 6, 2024
  10. melvin-bot commented on Mar 6, 2024

    @melvin-bot
    Author

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Mar 6, 2024

    @melvin-bot
    Author

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ArekChr does not require payment (Contractor)
    • @JKobrynski does not require payment (Contractor)
  12. melvin-bot commented on Mar 6, 2024

    @melvin-bot
    Author

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ArekChr / @JKobrynski] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  13. slafortune commented on Mar 13, 2024

    @slafortune
    Contributor

    No regression test needed

    @ArekChr does not require payment (Contractor)
    @JKobrynski does not require payment (Contractor)

    closing

  14. aimane-chnaif commented on Mar 13, 2024

    @aimane-chnaif
    Contributor

    @slafortune I am eligible for reviewing PR

  15. slafortune commented on Mar 20, 2024

    @slafortune
    Contributor
  16. slafortune commented on Mar 20, 2024

    @slafortune
    Contributor

    Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionInternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.TaskTypescript MigrationWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions