Skip to content

[HOLD for payment 2024-01-18] [HOLD for payment 2023-10-23] Refactor Form to a custom hook #25397

Closed

Description

@luacmartins

Problem

Although our Form component has been working great so far, the migration to functional components has surfaced some issues with our design. Coming from this thread, our existing Form component either causes child functional components with hooks to crash the App or functional components without hooks don't work. Given that we're migrating the whole codebase to use hooks, we need to redesign Form to play nicely with child components with/without hooks.

Why is this important

We migrated to functional components and we need Form to work with child functional components that have hooks.

Solution

Redesign Form into a custom hook. This will be worked on by an external agency.

Activity

  1. melvin-bot commented on Aug 17, 2023

    @melvin-bot
  2. melvin-bot commented on Aug 17, 2023

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  3. luacmartins commented on Aug 17, 2023

    @luacmartins
    ContributorAuthor

    No design changes are necessary here. Removing @shawnborton as an assignee

  4. lukemorawski commented on Aug 17, 2023

    @lukemorawski
    Contributor

    Hi it's Lucas from Callstack. Happy to have a go on that one :) I assume, given the app is currently being migrated to TS, this new custom form hook should be written in TS too?

  5. luacmartins commented on Aug 17, 2023

    @luacmartins
    ContributorAuthor

    Thanks @lukemorawski! Assigned you to the issue. Writing it in TS sounds good.

  6. lukemorawski commented on Aug 17, 2023

    @lukemorawski
    Contributor

    Cool! Thanks @luacmartins. Starting the research :)

  7. 110 remaining items

  8. DylanDylann commented on Nov 27, 2023

    @DylanDylann
    Contributor
  9. luacmartins commented on Nov 27, 2023

    @luacmartins
    ContributorAuthor

    It should be this issue - #30312

  10. DylanDylann commented on Nov 27, 2023

    @DylanDylann
    Contributor

    @luacmartins I just checked the PR that related to the issue you mentioned above but it does not contain the https://github.com/Expensify/App/blob/main/src/components/AddressForm.js

  11. luacmartins commented on Nov 27, 2023

    @luacmartins
    ContributorAuthor

    Ah you're right, we refactored ReimbursementAccount/AddressForm in that one, not components/AddressForm. Created a new issue for it here. Thanks for catching that.

  12. changed the title [-][HOLD for payment 2023-10-23] Refactor Form to a custom hook[/-] [+][HOLD for payment 2024-01-18] [HOLD for payment 2023-10-23] Refactor Form to a custom hook[/+] on Jan 11, 2024
  13. melvin-bot commented on Jan 11, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jan 11, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-01-18. 🎊

    For reference, here are some details about the assignees on this issue:

    • @kowczarz does not require payment (Contractor)
  15. melvin-bot commented on Jan 11, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@kowczarz] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions