You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-18] [HOLD for payment 2023-10-23] Refactor Form to a custom hook #25397
Although our Form component has been working great so far, the migration to functional components has surfaced some issues with our design. Coming from this thread, our existing Form component either causes child functional components with hooks to crash the App or functional components without hooks don't work. Given that we're migrating the whole codebase to use hooks, we need to redesign Form to play nicely with child components with/without hooks.
Why is this important
We migrated to functional components and we need Form to work with child functional components that have hooks.
Solution
Redesign Form into a custom hook. This will be worked on by an external agency.
Hi it's Lucas from Callstack. Happy to have a go on that one :) I assume, given the app is currently being migrated to TS, this new custom form hook should be written in TS too?
Ah you're right, we refactored ReimbursementAccount/AddressForm in that one, not components/AddressForm. Created a new issue for it here. Thanks for catching that.
changed the title [-][HOLD for payment 2023-10-23] Refactor Form to a custom hook[/-][+][HOLD for payment 2024-01-18] [HOLD for payment 2023-10-23] Refactor Form to a custom hook[/+]on Jan 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@kowczarz] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Aug 17, 2023
Triggered auto assignment to @strepanier03 (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.melvin-bot commentedon Aug 17, 2023
Triggered auto assignment to Design team member for new feature review - @shawnborton (
NewFeature)luacmartins commentedon Aug 17, 2023
No design changes are necessary here. Removing @shawnborton as an assignee
lukemorawski commentedon Aug 17, 2023
Hi it's Lucas from Callstack. Happy to have a go on that one :) I assume, given the app is currently being migrated to TS, this new custom form hook should be written in TS too?
luacmartins commentedon Aug 17, 2023
Thanks @lukemorawski! Assigned you to the issue. Writing it in TS sounds good.
lukemorawski commentedon Aug 17, 2023
Cool! Thanks @luacmartins. Starting the research :)
110 remaining items
DylanDylann commentedon Nov 27, 2023
@luacmartins Do we have the issue to migrate this one ?https://github.com/Expensify/App/blob/main/src/components/AddressForm.js
luacmartins commentedon Nov 27, 2023
It should be this issue - #30312
DylanDylann commentedon Nov 27, 2023
@luacmartins I just checked the PR that related to the issue you mentioned above but it does not contain the https://github.com/Expensify/App/blob/main/src/components/AddressForm.js
luacmartins commentedon Nov 27, 2023
Ah you're right, we refactored ReimbursementAccount/AddressForm in that one, not components/AddressForm. Created a new issue for it here. Thanks for catching that.
[-][HOLD for payment 2023-10-23] Refactor Form to a custom hook[/-][+][HOLD for payment 2024-01-18] [HOLD for payment 2023-10-23] Refactor Form to a custom hook[/+]melvin-bot commentedon Jan 11, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Formcomponent #34132If no regressions arise, payment will be issued on 2024-01-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 11, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: