Skip to content

[HOLD for payment 2023-10-16] [$1000] Dev: The "No result found" message showing after selecting a address from the drop-down menu #25595

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to Settings > Wallet > Add a debit card.
  2. Click on "Billing address" and choose an address from the available options.
  3. Once an address is selected, click again on "Billing address"
  4. Observe that after making a selection, click once more on "Billing address" the "No result found" message remains displayed.

Expected Result:

After selecting address from dropdown the "No result found" message should not appear.

Actual Result:

The "No result found" message showing even after selecting a address from the drop-down menu.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-19-at-24128-am_2EFvuuXS.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692395824547839

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d8f6143e301cae99
  • Upwork Job ID: 1693665091835113472
  • Last Price Increase: 2023-09-04
  • Automatic offers:
    • shubham1206agra | Contributor | 26553257

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 21, 2023
  2. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. OSBotify commented on Aug 21, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 21, 2023

    @melvin-bot

    Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. mountiny commented on Aug 21, 2023

    @mountiny
    Contributor

    This is repro in dev only so deploy blocker for next release, keeping this hourly

  7. 68 remaining items

  8. changed the title [-][$1000] Dev: The "No result found" message showing after selecting a address from the drop-down menu[/-] [+][HOLD for payment 2023-10-16] [$1000] Dev: The "No result found" message showing after selecting a address from the drop-down menu[/+] on Oct 9, 2023
  9. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-16. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
    • [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mananjadhav] Determine if we should create a regression test for this bug.
    • [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. sonialiap commented on Oct 13, 2023

    @sonialiap
    Contributor

    @ayazhussain79 report = $250 - offer sent
    @shubham1206agra fix + bonus = $1500 - offer sent
    @mananjadhav review + bonus = $1500 - in NewDot

    PR was delayed due to upstream changes and design decision conversations. Since these were outside of the contributors' controll and the final PR was ready for review Oct 3 and was approved on Oct 4, I'm applying bonus

    https://www.upwork.com/jobs/~0108a5f3d393bfcf89

  13. mananjadhav commented on Oct 13, 2023

    @mananjadhav
    Collaborator

    Thanks @sonialiap. Appreciate it.

  14. ayazhussain79 commented on Oct 13, 2023

    @ayazhussain79
    Contributor

    @sonialiap Offer accepted, Thank you

  15. sonialiap commented on Oct 15, 2023

    @sonialiap
    Contributor

    Both upwork contracts paid ✔️

  16. JmillsExpensify commented on Oct 16, 2023

    @JmillsExpensify
    Contributor

    $1,500 payment approved for @mananjadhav based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions