Skip to content

[HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] [HOLD for payment 2023-09-27] [$1000] Stop using report.participants in favor of report.participantAccountIDs #25714

Closed

Description

@puneetlath

We need to stop using report.participants and instead use report.participantAccountIDs. Now that #24320 is done, we should be able to remove all uses of report.participants in the App.

Let's go through and find everywhere that we use the participants array from the Onyx report object and instead use the participantAccountIDs array instead.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0155ce6d585250b4c1
  • Upwork Job ID: 1694376588443893760
  • Last Price Increase: 2023-08-23

Activity

  1. self-assigned this
    on Aug 22, 2023
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

  3. lukemorawski commented on Aug 23, 2023

    @lukemorawski
    Contributor

    Hey it's Lucas from Callstack. Happy to work on that ticket

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 23, 2023
  5. changed the title [-]Stop using report.participants in favor of report.participantAccountIDs[/-] [+][$1000] Stop using report.participants in favor of report.participantAccountIDs[/+] on Aug 23, 2023
  6. melvin-bot commented on Aug 23, 2023

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 23, 2023
  8. melvin-bot commented on Aug 23, 2023

    @melvin-bot

    Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

  9. 45 remaining items

  10. changed the title [-][HOLD for payment 2023-09-27] [$1000] Stop using report.participants in favor of report.participantAccountIDs[/-] [+][HOLD for payment 2023-10-05] [HOLD for payment 2023-09-27] [$1000] Stop using report.participants in favor of report.participantAccountIDs[/+] on Sep 28, 2023
  11. melvin-bot commented on Sep 28, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Sep 28, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-05. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. puneetlath commented on Oct 1, 2023

    @puneetlath
    ContributorAuthor

    There are no contributors to pay out here, so I'm going to go ahead and close this.

    Thanks again for your help getting this across the finish line @koko57 @burczu and @lukemorawski!

  14. changed the title [-][HOLD for payment 2023-10-05] [HOLD for payment 2023-09-27] [$1000] Stop using report.participants in favor of report.participantAccountIDs[/-] [+][HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] [HOLD for payment 2023-09-27] [$1000] Stop using report.participants in favor of report.participantAccountIDs[/+] on Oct 2, 2023
  15. melvin-bot commented on Oct 2, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-09. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions