Skip to content

[C+ Checklist Needs Completion] [$250] Fix styling of Google Sign In button on Safari #25864

Closed

Description

@dangrous

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  • Open the main page on desktop Safari, with Apple and Google sign in links

Expected Result:

Describe what you think should've happened

  • Google button should appear in full, and stay static once loaded

Actual Result:

Describe what actually happened

  • The G part of the button looks fine, but right after it loads the white background shifts one pixel right and is cut off by that amount.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Yes

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Safari
  • MacOS / Desktop

Version Number: 1.3.57-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: https://expensify.slack.com/archives/C01GTK53T8Q/p1692805800476329?thread_ts=1692802374.824749&cid=C01GTK53T8Q

hidden.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1692805800476329?thread_ts=1692802374.824749&cid=C01GTK53T8Q

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0131c050705af6ac9f
  • Upwork Job ID: 1695197552733020160
  • Last Price Increase: 2023-08-25
  • Automatic offers:
    • Pujan92 | Contributor | 26508718

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 24, 2023
  2. melvin-bot commented on Aug 24, 2023

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 24, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. Pujan92 commented on Aug 24, 2023

    @Pujan92
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Google sign in button cuts from right in safari

    What is the root cause of that problem?

    Seems after adding overflow hidden in this PR started causing the issue. When parent width and overflow hidden gets given it seems to create the problem for safari.
    https://stackoverflow.com/questions/75306089/safari-when-using-border-radius-and-overflow-hidden-to-parent-and-the-child-th

    What changes do you think we should make in order to solve the problem?

    We can use styles.willChangeTransform(will-change: transform) for the layout glitch for the safari as suggested in the comment and I think we are already using the same at other places.

    <View style={styles.googleButtonContainer}>

    <View style={[styles.googleButtonContainer, styles.willChangeTransform]}>

    OR

    We can increase the width of the container and apply some padding so it cut part can be visible on the padding area.

    Screenshot 2023-08-24 at 23 56 15
  5. changed the title [-]Fix styling of Google Sign In button on Safari[/-] [+][$250] Fix styling of Google Sign In button on Safari[/+] on Aug 25, 2023
  6. melvin-bot commented on Aug 25, 2023

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  7. greg-schroeder commented on Aug 25, 2023

    @greg-schroeder
    Contributor

    Setting this to $250 as a minor adjustment

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 25, 2023
  9. melvin-bot commented on Aug 25, 2023

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 25, 2023
  11. melvin-bot commented on Aug 25, 2023

    @melvin-bot

    Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

  12. melvin-bot commented on Aug 25, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

  13. 34 remaining items

  14. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@burczu] The PR that introduced the bug has been identified. Link to the PR:
    • [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@burczu] Determine if we should create a regression test for this bug.
    • [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. greg-schroeder commented on Sep 25, 2023

    @greg-schroeder
    Contributor

    Sorry for the delay, I've been out with an illness. Processing this today.

  17. greg-schroeder commented on Sep 25, 2023

    @greg-schroeder
    Contributor

    @burczu does not require payment (Contractor)
    @Pujan92 requires payment offer (Contributor)

  18. greg-schroeder commented on Sep 25, 2023

    @greg-schroeder
    Contributor

    Paid. @burczu can you take care of the checklist?

  19. changed the title [-][HOLD for payment 2023-09-21] [$250] Fix styling of Google Sign In button on Safari[/-] [+][C+ Checklist Needs Completion] [$250] Fix styling of Google Sign In button on Safari[/+] on Sep 25, 2023
  20. Pujan92 commented on Sep 25, 2023

    @Pujan92
    Contributor

    @greg-schroeder is this eligible for urgency bonus as @burczu wasn't available for 2 days based on this comment?

  21. burczu commented on Sep 25, 2023

    @burczu
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@burczu] The PR that introduced the bug has been identified. Link to the PR: It's not a regression - it was just hard to be noticed during initial testing, I guess.
    • [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
    • [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
    • [@burczu] Determine if we should create a regression test for this bug.
    • [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions