Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Break down in numbered steps
- Open the main page on desktop Safari, with Apple and Google sign in links
Expected Result:
Describe what you think should've happened
- Google button should appear in full, and stay static once loaded
Actual Result:
Describe what actually happened
- The G part of the button looks fine, but right after it loads the white background shifts one pixel right and is cut off by that amount.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Yes
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Safari
- MacOS / Desktop
Version Number: 1.3.57-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: https://expensify.slack.com/archives/C01GTK53T8Q/p1692805800476329?thread_ts=1692802374.824749&cid=C01GTK53T8Q
hidden.mp4
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1692805800476329?thread_ts=1692802374.824749&cid=C01GTK53T8Q
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0131c050705af6ac9f
- Upwork Job ID: 1695197552733020160
- Last Price Increase: 2023-08-25
- Automatic offers:
- Pujan92 | Contributor | 26508718
Activity
melvin-bot commentedon Aug 24, 2023
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Pujan92 commentedon Aug 24, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Google sign in button cuts from right in safari
What is the root cause of that problem?
Seems after adding overflow hidden in this PR started causing the issue. When parent width and overflow hidden gets given it seems to create the problem for safari.
https://stackoverflow.com/questions/75306089/safari-when-using-border-radius-and-overflow-hidden-to-parent-and-the-child-th
What changes do you think we should make in order to solve the problem?
We can use
styles.willChangeTransform(will-change: transform)for the layout glitch for the safari as suggested in the comment and I think we are already using the same at other places.App/src/components/SignInButtons/GoogleSignIn/index.website.js
Line 80 in 165e1b8
<View style={[styles.googleButtonContainer, styles.willChangeTransform]}>OR
We can increase the width of the container and apply some padding so it cut part can be visible on the padding area.
[-]Fix styling of Google Sign In button on Safari[/-][+][$250] Fix styling of Google Sign In button on Safari[/+]melvin-bot commentedon Aug 25, 2023
greg-schroeder commentedon Aug 25, 2023
Setting this to $250 as a minor adjustment
melvin-bot commentedon Aug 25, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0131c050705af6ac9f
melvin-bot commentedon Aug 25, 2023
Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Aug 25, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (
External)34 remaining items
melvin-bot commentedon Sep 14, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-21. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 14, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
greg-schroeder commentedon Sep 25, 2023
Sorry for the delay, I've been out with an illness. Processing this today.
greg-schroeder commentedon Sep 25, 2023
@burczu does not require payment (Contractor)
@Pujan92 requires payment offer (Contributor)
greg-schroeder commentedon Sep 25, 2023
Paid. @burczu can you take care of the checklist?
[-][HOLD for payment 2023-09-21] [$250] Fix styling of Google Sign In button on Safari[/-][+][C+ Checklist Needs Completion] [$250] Fix styling of Google Sign In button on Safari[/+]Pujan92 commentedon Sep 25, 2023
@greg-schroeder is this eligible for urgency bonus as @burczu wasn't available for 2 days based on this comment?
burczu commentedon Sep 25, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: