Skip to content

[HOLD for payment 2023-11-06] [$1000] Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear #26012

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login
  2. Enter a chat
  3. Write a message A and click the Send button
  4. Click in Reply in thread
  5. Write a message B and click the Send button
  6. Click in Reply in thread
  7. Write a message C and click the Send button
  8. Click in Reply in thread
  9. Write a message D and click the Send button
  10. Click in Reply in thread
  11. Write a message E and click the Send button
  12. Now delete the message D and B and you will see the rest of the messages for a moment and then they disappear from the thread

Expected Result:

When we delete a message from a thread, the rest of the thread should not be deleted

Actual Result:

When we delete a message from a thread, the rest of the thread is deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Safari

Version Number: 1.3.57-5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Compartir.pantalla.-.2023-08-17.02_54_42.mp4

Screenshot 2023-08-17 at 03 23 43

Recording.6010.mp4

Expensify/Expensify Issue URL:

Issue reported by:@eusalazar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692252890687509

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0162c908765ad3ae06
  • Upwork Job ID: 1697250502676635648
  • Last Price Increase: 2023-09-21

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 26, 2023
  2. melvin-bot commented on Aug 26, 2023

    @melvin-bot

    Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 26, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    @michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. michaelhaxhiu commented on Aug 31, 2023

    @michaelhaxhiu
    Contributor

    This is a little bit confusing and I will need input from a C+ or Engineer on the expected behavior here.

    https://recordit.co/F1uorCO0ij

    I tried to reproduce it here and noticed that we deleted/removed more than just the deleted thread response, which looks like the bug report made. But I want to confirm this behavior is wrong or incorrect. Assigning external to get a hand with this step!

  6. melvin-bot commented on Aug 31, 2023

    @melvin-bot
  7. changed the title [-]Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear[/-] [+][$500] Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear[/+] on Aug 31, 2023
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 31, 2023
  9. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

  10. 100 remaining items

  11. melvin-bot commented on Oct 30, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-11-06. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    • @situchan requires payment
    • @s-alves10 requires payment
  12. melvin-bot commented on Oct 30, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/333713
  13. abekkala commented on Oct 31, 2023

    @abekkala
    Contributor

    PAYMENTS FOR NOV 6

    • Reporter: @eusalazar [$250] (this was reported prior to price change)
    • Fix: @s-alves10 [$1000 + $500 Bonus]
    • PR Review: @situchan [$1000 + $500 Bonus]

    assigned Oct 24 - merged PR Oct 26

    @situchan can you complete the checklist?

    Upwork is not letting me create a job posting right now. I'll keep checking and post the offer links here when I'm able.

  14. abekkala commented on Nov 6, 2023

    @abekkala
    Contributor

    @eusalazar offer sent. Once accepted I can process payment!

    @s-alves10 offer sent. Once accepted I can process payment!

    @situchan please complete checklist and I can send payment

  15. situchan commented on Nov 6, 2023

    @situchan
    Contributor

    I think this is unusual case and users will most likely not face this.
    But in case regression test is still needed:

    Regression Test Proposal

    1. Navigate to any chat
    2. Send message A and reply in thread
    3. Send message B and reply in thread
    4. Send message C
    5. Disable network
    6. Delete message B
    7. Verify that the message A still has 1 reply in the chat at Step 2
  16. abekkala commented on Nov 6, 2023

    @abekkala
    Contributor

    @eusalazar and @situchan payment made and contract ended - Thank you! 🎉

    @s-alves10 once offer is accepted I'll process payment!

  17. dummy-1111 commented on Nov 6, 2023

    @dummy-1111
    Contributor

    @abekkala

    Offer accepted. Thanks

  18. abekkala commented on Nov 7, 2023

    @abekkala
    Contributor

    @s-alves10 payment made and contract ended - Thank you! 🎉

  19. puneetlath commented on Jan 17, 2024

    @puneetlath
    Contributor

    Yup looks good, agree we should also make the internal changes here

    @thienlnam @abekkala is this being handled somewhere?

  20. thienlnam commented on Jan 18, 2024

    @thienlnam
    Contributor

    Good question, I don't remember following up with a change here.

    It looks like the last conversation about that happened here https://expensify.slack.com/archives/C049HHMV9SM/p1694502825117099, @chiragsalian do you happen to remember if we made a change here?

  21. thienlnam commented on Jan 18, 2024

    @thienlnam
    Contributor

    Oh, Chirag is on parental leave. Checking the BE code to see if we ended up excluding deleted parent actions from childVisibleActionCount

  22. thienlnam commented on Jan 18, 2024

    @thienlnam
    Contributor

    It doesn't look like we've added it for ADD_COMMENT reportActions. Created an internal issue to keep track of that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions