You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-11-06] [$1000] Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear #26012
I tried to reproduce it here and noticed that we deleted/removed more than just the deleted thread response, which looks like the bug report made. But I want to confirm this behavior is wrong or incorrect. Assigning external to get a hand with this step!
changed the title [-]Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear[/-][+][$500] Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear[/+]on Aug 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
I think this is unusual case and users will most likely not face this.
But in case regression test is still needed:
Regression Test Proposal
Navigate to any chat
Send message A and reply in thread
Send message B and reply in thread
Send message C
Disable network
Delete message B
Verify that the message A still has 1 reply in the chat at Step 2
Activity
melvin-bot commentedon Aug 26, 2023
Triggered auto assignment to @michaelhaxhiu (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Aug 30, 2023
@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!
michaelhaxhiu commentedon Aug 31, 2023
This is a little bit confusing and I will need input from a C+ or Engineer on the expected behavior here.
https://recordit.co/F1uorCO0ij
I tried to reproduce it here and noticed that we deleted/removed more than just the deleted thread response, which looks like the bug report made. But I want to confirm this behavior is wrong or incorrect. Assigning
externalto get a hand with this step!melvin-bot commentedon Aug 31, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0162c908765ad3ae06
[-]Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear[/-][+][$500] Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear[/+]melvin-bot commentedon Aug 31, 2023
Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.
100 remaining items
melvin-bot commentedon Oct 30, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-11-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 30, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abekkala commentedon Oct 31, 2023
PAYMENTS FOR NOV 6
assigned Oct 24 - merged PR Oct 26
@situchan can you complete the checklist?
Upwork is not letting me create a job posting right now. I'll keep checking and post the offer links here when I'm able.
abekkala commentedon Nov 6, 2023
@eusalazar offer sent. Once accepted I can process payment!
@s-alves10 offer sent. Once accepted I can process payment!
@situchan please complete checklist and I can send payment
situchan commentedon Nov 6, 2023
I think this is unusual case and users will most likely not face this.
But in case regression test is still needed:
Regression Test Proposal
abekkala commentedon Nov 6, 2023
@eusalazar and @situchan payment made and contract ended - Thank you! 🎉
@s-alves10 once offer is accepted I'll process payment!
dummy-1111 commentedon Nov 6, 2023
@abekkala
Offer accepted. Thanks
abekkala commentedon Nov 7, 2023
@s-alves10 payment made and contract ended - Thank you! 🎉
puneetlath commentedon Jan 17, 2024
@thienlnam @abekkala is this being handled somewhere?
thienlnam commentedon Jan 18, 2024
Good question, I don't remember following up with a change here.
It looks like the last conversation about that happened here https://expensify.slack.com/archives/C049HHMV9SM/p1694502825117099, @chiragsalian do you happen to remember if we made a change here?
thienlnam commentedon Jan 18, 2024
Oh, Chirag is on parental leave. Checking the BE code to see if we ended up excluding deleted parent actions from childVisibleActionCount
thienlnam commentedon Jan 18, 2024
It doesn't look like we've added it for ADD_COMMENT reportActions. Created an internal issue to keep track of that change