You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-21] [$500] Dev: Web - Console error on request money thread #26092
Console error appears (Warning: Failed prop type: Invalid prop source supplied to Image, expected one of type [number].)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev 1.3.57.5 Reproducible in staging?: no Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Thanks for confirming that we don't need a regression test. In that case I'm closing out the issue since we do not need to keep the issue open for payout via NewDot
Activity
namhihi237 commentedon Aug 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
should not show any console error
What is the root cause of that problem?
We are passing the
sourceprop ofImagewrong here:App/src/components/ReportActionItem/MoneyRequestView.js
Lines 98 to 100 in c029dc5
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
N/A
melvin-bot commentedon Aug 28, 2023
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Pujan92 commentedon Aug 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Console error for opening a report of money request view
What is the root cause of that problem?
It persists after this PR merged where the image source is passed as a string which should be the either number or object.
https://github.com/Expensify/App/pull/22562/files#diff-53a3b5c2e20375a2d0d3a700bd76dab7791ddc968e942d510a9e06572dc0e26fR57
App/src/components/Image/imagePropTypes.js
Lines 10 to 17 in 7b5fadf
What changes do you think we should make in order to solve the problem?
We need to pass it as an object by setting its
uriproperty.source={{uri: EmptyStateBackgroundImage}}App/src/components/ReportActionItem/MoneyRequestView.js
Line 120 in 7b5fadf
shubham1206agra commentedon Aug 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
DEV: console error on request money thread
What is the root cause of that problem?
This is due to difference in Image Resolver for web and native devices. RNWeb also accepts string as a source
What changes do you think we should make in order to solve the problem?
Add platform dependent types for source (example below, not exact)
What alternative solutions did you explore? (Optional)
sonialiap commentedon Aug 30, 2023
Reproducible, triaging to external
[-]Dev: Web - Console error on request money thread[/-][+][$500] Dev: Web - Console error on request money thread[/+]42 remaining items
sonialiap commentedon Sep 26, 2023
@gadhiyamanan agreed, thanks for pointing out that Melvin miscounted. I'm correcting that to $250 for the reporting
sonialiap commentedon Sep 26, 2023
@parasharrajat bump on the regression test question (are we writing one for this issue?)
parasharrajat commentedon Sep 26, 2023
@sonialiap I don't think regression tests are needed for this issue. It was just a console warning.
melvin-bot commentedon Sep 29, 2023
@sonialiap, @parasharrajat, @thienlnam, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!
thienlnam commentedon Sep 30, 2023
Agreed - seems like we're just waiting on NewDot payout before closing this one out?
melvin-bot commentedon Oct 3, 2023
@sonialiap, @parasharrajat, @thienlnam, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
sonialiap commentedon Oct 4, 2023
Thanks for confirming that we don't need a regression test. In that case I'm closing out the issue since we do not need to keep the issue open for payout via NewDot
parasharrajat commentedon Oct 5, 2023
Payment requested as per #26092 (comment)
JmillsExpensify commentedon Oct 5, 2023
$750 payment approved for @parasharrajat based on BZ summary.