You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-09] [$2000] Chat - The message got sent but it also stayed in the compose box #26347
changed the title [-][$2000] Chat - The message got sent but it also stayed in the compose box[/-][+][HOLD for payment 2024-02-09] [$2000] Chat - The message got sent but it also stayed in the compose box[/+]on Feb 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif / @situchan] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Not exactly sure about the amount. This was very old issue and maybe applies the same amount in issue title, similar to #10148? The size of PR was also large enough.
Repro step is same as stated in OP. Our PR was supposed to fix this in most devices (#30168 (comment))
But sometimes still occurring in heavy android devices (#30168 (comment))
So I'd like to say:
Originally, reproducible 20%
After #10148 fix, reproducible 5%
After #26347 (our fix), reproducible 3%
(This is just example numbers, not correct)
Activity
melvin-bot commentedon Aug 30, 2023
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 30, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)mallenexpensify commentedon Sep 5, 2023
I feel like this is an age-old issue that we used to run into a LOT.
https://github.com/Expensify/App/assets/22508304/13ddd9cc-dc69-4a57-a4fd-d4f7e358ec66
Checking on in #expensify-open-source
https://expensify.slack.com/archives/C01GTK53T8Q/p1693872831763299
melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)mallenexpensify commentedon Sep 5, 2023
@NicMendonca I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx
146 remaining items
[-][$2000] Chat - The message got sent but it also stayed in the compose box[/-][+][HOLD for payment 2024-02-09] [$2000] Chat - The message got sent but it also stayed in the compose box[/+]melvin-bot commentedon Feb 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 2, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mallenexpensify commentedon Feb 9, 2024
@mountiny, both @situchan and @aimane-chnaif have been paid $2k, Is that correct?
What regression tests do we need for this??!?!
mountiny commentedon Feb 14, 2024
Not sure what are the best regression steps for this. I think its one of those we would raise over time if it comes back
Has there been reliable reproduction steps?
mallenexpensify commentedon Feb 18, 2024
@situchan and @aimane-chnaif , from above, can you confirm this is correct?
I'm unaware of reliable reproduction steps. @hurali97 @kacper-mikolajczak @aimane-chnaif @situchan , any of you know?
aimane-chnaif commentedon Feb 18, 2024
Not exactly sure about the amount. This was very old issue and maybe applies the same amount in issue title, similar to #10148? The size of PR was also large enough.
Repro step is same as stated in OP. Our PR was supposed to fix this in most devices (#30168 (comment))
But sometimes still occurring in heavy android devices (#30168 (comment))
So I'd like to say:
Originally, reproducible 20%
After #10148 fix, reproducible 5%
After #26347 (our fix), reproducible 3%
(This is just example numbers, not correct)
mallenexpensify commentedon Feb 20, 2024
TestRail GH created - https://github.com/Expensify/Expensify/issues/371196
I'm going to leave as-is then and close this. Comment/reopen if you disagree.