Skip to content

[HOLD for payment 2024-02-09] [$2000] Chat - The message got sent but it also stayed in the compose box #26347

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open New Expensify app
  2. Open any conversation
  3. Quickly enter any text in the compose box
  4. Tap the icon to send a message
  5. Quickly repeat steps 3-4 several times

Expected Result:

The compose box should be scrubbed after each click on the send message icon

Actual Result:

The compose box doesn't have time to scrub after each click on the send icon and new text is added to the old text already sent

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.59

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6183207_Record_Android_CB.mp4
Bug6183207_Record_iOS_CB.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bb269a50709f3aa2
  • Upwork Job ID: 1699460288474398720
  • Last Price Increase: 2023-10-02
  • Automatic offers:
    • aimane-chnaif | Reviewer | 27043430
    • situchan | Contributor | 27503921

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 30, 2023
  2. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 30, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. mallenexpensify commented on Sep 5, 2023

    @mallenexpensify
    Contributor

    I feel like this is an age-old issue that we used to run into a LOT.
    https://github.com/Expensify/App/assets/22508304/13ddd9cc-dc69-4a57-a4fd-d4f7e358ec66

    Checking on in #expensify-open-source
    https://expensify.slack.com/archives/C01GTK53T8Q/p1693872831763299

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 5, 2023
  6. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. mallenexpensify commented on Sep 5, 2023

    @mallenexpensify
    Contributor

    @NicMendonca I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx

  9. 146 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 2, 2024
  11. changed the title [-][$2000] Chat - The message got sent but it also stayed in the compose box[/-] [+][HOLD for payment 2024-02-09] [$2000] Chat - The message got sent but it also stayed in the compose box[/+] on Feb 2, 2024
  12. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-09. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif / @situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif / @situchan] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. mallenexpensify commented on Feb 9, 2024

    @mallenexpensify
    Contributor

    @mountiny, both @situchan and @aimane-chnaif have been paid $2k, Is that correct?

    What regression tests do we need for this??!?!

  16. mountiny commented on Feb 14, 2024

    @mountiny
    Contributor

    Not sure what are the best regression steps for this. I think its one of those we would raise over time if it comes back

    Has there been reliable reproduction steps?

  17. mallenexpensify commented on Feb 18, 2024

    @mallenexpensify
    Contributor

    @situchan and @aimane-chnaif , from above, can you confirm this is correct?

    Contributor+: @situchan paid $2000 via Upwork
    Contributor+: @aimane-chnaif paid $2000 via Upwork.

    I'm unaware of reliable reproduction steps. @hurali97 @kacper-mikolajczak @aimane-chnaif @situchan , any of you know?

  18. aimane-chnaif commented on Feb 18, 2024

    @aimane-chnaif
    Contributor

    Not exactly sure about the amount. This was very old issue and maybe applies the same amount in issue title, similar to #10148? The size of PR was also large enough.

    Repro step is same as stated in OP. Our PR was supposed to fix this in most devices (#30168 (comment))
    But sometimes still occurring in heavy android devices (#30168 (comment))

    So I'd like to say:
    Originally, reproducible 20%
    After #10148 fix, reproducible 5%
    After #26347 (our fix), reproducible 3%
    (This is just example numbers, not correct)

  19. mallenexpensify commented on Feb 20, 2024

    @mallenexpensify
    Contributor

    TestRail GH created - https://github.com/Expensify/Expensify/issues/371196

    Not exactly sure about the amount.

    I'm going to leave as-is then and close this. Comment/reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions