You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Deprecate Paypal.me in product now that we're launching in-app payments and have settle-up elsewhere #26368
We're wasting a lot of time and money fixing Paypal related bugs, this just isn't worth it. It's also not a "real" feature so let's just deprecate it and focus on the stuff that matters.
Yes, sorry about that. I actually created this so we don't forget, as it's linked to an internal initiative. I'll put it on HOLD on now, though yes, I meant remove the remove the option and related code from the front-end.
changed the title [-]Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/-][+][HOLD] Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/+]on Sep 5, 2023
changed the title [-][HOLD] Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/-][+]Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/+]on Sep 8, 2023
Activity
b4s36t4 commentedon Aug 31, 2023
Deprecate in the sense? remove the option fully in frontend?
neonbhai commentedon Aug 31, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Deprecate Paypal.me in product now that we're launching in-app payments and have settle-up elsewhere
What is the root cause of that problem?
Feature Request
What changes do you think we should make in order to solve the problem?
Remove
AddPayPalMePage.jspage from here.Remove Paypal
paymentMethodfromSettlementButton.js:App/src/components/SettlementButton.js
Line 99 in c20c387
Remove
shouldShowPaypalmenuItem fromAddPaymentMethodMenu.js:App/src/components/AddPaymentMethodMenu.js
Lines 76 to 84 in c20c387
Remove
payPalMeDatafromPaymentMethodList.js:App/src/pages/settings/Wallet/PaymentMethodList.js
Lines 31 to 32 in c20c387
Also remove onyxKey from
withOnyxHOC:App/src/pages/settings/Wallet/PaymentMethodList.js
Lines 277 to 279 in c20c387
Remove the
add-paypal-meroute:App/src/ROUTES.js
Line 46 in c20c387
Remove the
shouldShowPaypallogic fromMoneyReportHeader.js:App/src/components/MoneyReportHeader.js
Line 82 in c20c387
Remove settledMessage for paypal from
MoneyRequestPreview.js:App/src/components/ReportActionItem/MoneyRequestPreview.js
Lines 164 to 165 in c20c387
Add
Deprecatedto function definitions handling paypalIOU.js:App/src/libs/actions/IOU.js
Line 1283 in c20c387
User.js:App/src/libs/actions/User.js
Line 501 in c20c387
ValidationUtils.js:App/src/libs/ValidationUtils.js
Line 198 in c20c387
PaymentUtils.js:App/src/libs/PaymentUtils.js
Line 33 in c20c387
PaymentMethods.js:App/src/libs/actions/PaymentMethods.js
Lines 14 to 17 in c20c387
What alternative solutions did you explore? (Optional)
xx
JmillsExpensify commentedon Sep 5, 2023
Yes, sorry about that. I actually created this so we don't forget, as it's linked to an internal initiative. I'll put it on HOLD on now, though yes, I meant remove the remove the option and related code from the front-end.
[-]Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/-][+][HOLD] Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/+]mountiny commentedon Sep 5, 2023
happy to help clear this up
JmillsExpensify commentedon Sep 8, 2023
Alright, I posted internally on this issue and we agree to move forward with this. I'm removing the hold. We'll keep it internal.
JmillsExpensify commentedon Sep 8, 2023
Noting the places that Paypal.me needs to be removed:
Paybutton on reportsAnd so on. Basically let's remove it everywhere it's referenced in the code and get this cleaned up.
[-][HOLD] Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/-][+]Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/+]melvin-bot commentedon Sep 8, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01406c39bc77fa5134
melvin-bot commentedon Sep 8, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @burczu (
Internal)73 remaining items
mountiny commentedon May 8, 2024
When travelling I have completed the Web and Auth PRs, I will clean them up and get them reviewed
mountiny commentedon May 13, 2024
Web PR is in a review
JmillsExpensify commentedon May 19, 2024
Nice work. Let's get this issue closed!
mountiny commentedon May 20, 2024
web is merged, but not yet in production, Auth is waiting for the merge freeze to be lifted
mountiny commentedon May 29, 2024
I have resolved merge conflicts on the auth PR, this might be more riskier change so might be fine to wait couple days
mountiny commentedon May 29, 2024
Now that Auth perf is slightly better, I have cleaned up the tests and last PR is ready for final review and merge. Maxence is on it
JmillsExpensify commentedon Jun 12, 2024
Still in the docket, looks like
mountiny commentedon Jun 12, 2024
No, this is done 🎉