Skip to content

Deprecate Paypal.me in product now that we're launching in-app payments and have settle-up elsewhere #26368

Closed

Description

@JmillsExpensify

We're wasting a lot of time and money fixing Paypal related bugs, this just isn't worth it. It's also not a "real" feature so let's just deprecate it and focus on the stuff that matters.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01406c39bc77fa5134
  • Upwork Job ID: 1699990475947565056
  • Last Price Increase: 2023-09-08

Activity

  1. b4s36t4 commented on Aug 31, 2023

    @b4s36t4
    Contributor

    Deprecate in the sense? remove the option fully in frontend?

  2. neonbhai commented on Aug 31, 2023

    @neonbhai
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Deprecate Paypal.me in product now that we're launching in-app payments and have settle-up elsewhere

    What is the root cause of that problem?

    Feature Request

    What changes do you think we should make in order to solve the problem?

    What alternative solutions did you explore? (Optional)

    xx

  3. JmillsExpensify commented on Sep 5, 2023

    @JmillsExpensify
    ContributorAuthor

    Yes, sorry about that. I actually created this so we don't forget, as it's linked to an internal initiative. I'll put it on HOLD on now, though yes, I meant remove the remove the option and related code from the front-end.

  4. changed the title [-]Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/-] [+][HOLD] Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/+] on Sep 5, 2023
  5. self-assigned this
    on Sep 5, 2023
  6. mountiny commented on Sep 5, 2023

    @mountiny
    Contributor

    happy to help clear this up

  7. JmillsExpensify commented on Sep 8, 2023

    @JmillsExpensify
    ContributorAuthor

    Alright, I posted internally on this issue and we agree to move forward with this. I'm removing the hold. We'll keep it internal.

  8. JmillsExpensify commented on Sep 8, 2023

    @JmillsExpensify
    ContributorAuthor

    Noting the places that Paypal.me needs to be removed:

    • Settings > Wallet > Add payment method > Paypal.me
    • Bank accounts
    • System messages
    • Pay button on reports

    And so on. Basically let's remove it everywhere it's referenced in the code and get this cleaned up.

  9. changed the title [-][HOLD] Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/-] [+]Deprecate Paypal.me in product now that we're launching in-app payments and have `settle-up elsewhere`[/+] on Sep 8, 2023
  10. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Sep 8, 2023
  11. melvin-bot commented on Sep 8, 2023

    @melvin-bot
  12. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @burczu (Internal)

  13. 73 remaining items

  14. mountiny commented on May 8, 2024

    @mountiny
    Contributor

    When travelling I have completed the Web and Auth PRs, I will clean them up and get them reviewed

  15. mountiny commented on May 13, 2024

    @mountiny
    Contributor

    Web PR is in a review

  16. JmillsExpensify commented on May 19, 2024

    @JmillsExpensify
    ContributorAuthor

    Nice work. Let's get this issue closed!

  17. mountiny commented on May 20, 2024

    @mountiny
    Contributor

    web is merged, but not yet in production, Auth is waiting for the merge freeze to be lifted

  18. mountiny commented on May 29, 2024

    @mountiny
    Contributor

    I have resolved merge conflicts on the auth PR, this might be more riskier change so might be fine to wait couple days

  19. mountiny commented on May 29, 2024

    @mountiny
    Contributor

    Now that Auth perf is slightly better, I have cleaned up the tests and last PR is ready for final review and merge. Maxence is on it

  20. JmillsExpensify commented on Jun 12, 2024

    @JmillsExpensify
    ContributorAuthor

    Still in the docket, looks like

  21. mountiny commented on Jun 12, 2024

    @mountiny
    Contributor

    No, this is done 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

ImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions