You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[WAITING ON SOBIT TO COMPLETE CHECKLIST] [$500] Changing Currency in IOU Causes Account Email to Replace Request Email #26392
Click on the plus sign and select "Request Money".
Enter the desired amount and email address for the money request.
Double-click on the requested money in IOU and change the currency by clicking on the amount.
Go back twice and observe that the requested email has been replaced by the account email.
Expected Result:
Changing the currency in IOU should not cause the account email to replace the requested email.
Actual Result:
Changing the currency in IOU causes the account email to replace the requested email.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.60-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Changing Currency in IOU Causes Account Email to Replace Request Email[/-][+][$500] Changing Currency in IOU Causes Account Email to Replace Request Email[/+]on Sep 6, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Not Required.
[@sobitneupane] Determine if we should create a regression test for this bug.
Yes.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @flaviadefaria (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 4, 2023
@flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Changing Currency in IOU Causes Account Email to Replace Request Email[/-][+][$500] Changing Currency in IOU Causes Account Email to Replace Request Email[/+]melvin-bot commentedon Sep 6, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0164ab47794feaee80
melvin-bot commentedon Sep 6, 2023
Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.
flaviadefaria commentedon Sep 6, 2023
Added the external label
68 remaining items
deetergp commentedon Oct 25, 2023
Still waiting on the checklist?
jliexpensify commentedon Oct 26, 2023
Yep to complete the checklist. I was told @sobitneupane would be back this week!
jliexpensify commentedon Oct 26, 2023
Pinged Sobit in Slack
sobitneupane commentedon Oct 27, 2023
Sorry for the delay. I was on leave. I will try to get to it in the weekend.
jliexpensify commentedon Oct 30, 2023
Thanks @sobitneupane and welcome back!
sobitneupane commentedon Oct 30, 2023
#23703
https://github.com/Expensify/App/pull/23703/files#r1375876861
Not Required.
Yes.
#26392 (comment)
sobitneupane commentedon Oct 30, 2023
Regression Test Proposal
Do we agree 👍 or 👎
sobitneupane commentedon Oct 30, 2023
#26392 (comment)
Requested payment on newDot.
jliexpensify commentedon Oct 30, 2023
Closing, thanks Sobit!
JmillsExpensify commentedon Nov 3, 2023
$750 payment approved for @sobitneupane based on this comment.