Skip to content

[WAITING ON SOBIT TO COMPLETE CHECKLIST] [$500] Changing Currency in IOU Causes Account Email to Replace Request Email #26392

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on the plus sign and select "Request Money".
  2. Enter the desired amount and email address for the money request.
  3. Double-click on the requested money in IOU and change the currency by clicking on the amount.
  4. Go back twice and observe that the requested email has been replaced by the account email.

Expected Result:

Changing the currency in IOU should not cause the account email to replace the requested email.

Actual Result:

Changing the currency in IOU causes the account email to replace the requested email.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.60-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.1404.mp4
screen-capture.-.2023-08-20T224541.860.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692596411940539

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0164ab47794feaee80
  • Upwork Job ID: 1699385618357227520
  • Last Price Increase: 2023-09-20
  • Automatic offers:
    • TewodrosGirmaA | Reporter | 26851433

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 31, 2023
  2. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    @flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 6, 2023
  6. changed the title [-]Changing Currency in IOU Causes Account Email to Replace Request Email[/-] [+][$500] Changing Currency in IOU Causes Account Email to Replace Request Email[/+] on Sep 6, 2023
  7. melvin-bot commented on Sep 6, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 6, 2023
  9. melvin-bot commented on Sep 6, 2023

    @melvin-bot

    Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

  10. flaviadefaria commented on Sep 6, 2023

    @flaviadefaria
    Contributor

    Added the external label

  11. 68 remaining items

  12. added and removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Oct 17, 2023
  13. deetergp commented on Oct 25, 2023

    @deetergp
    Contributor

    Still waiting on the checklist?

  14. jliexpensify commented on Oct 26, 2023

    @jliexpensify
    Contributor

    Yep to complete the checklist. I was told @sobitneupane would be back this week!

  15. jliexpensify commented on Oct 26, 2023

    @jliexpensify
    Contributor

    Pinged Sobit in Slack

  16. sobitneupane commented on Oct 27, 2023

    @sobitneupane
    Contributor

    Sorry for the delay. I was on leave. I will try to get to it in the weekend.

  17. jliexpensify commented on Oct 30, 2023

    @jliexpensify
    Contributor

    Thanks @sobitneupane and welcome back!

  18. sobitneupane commented on Oct 30, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

    #23703

    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    https://github.com/Expensify/App/pull/23703/files#r1375876861

    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Not Required.

    • [@sobitneupane] Determine if we should create a regression test for this bug.

    Yes.

    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    #26392 (comment)

  19. sobitneupane commented on Oct 30, 2023

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Click on a report.
    2. Verify the request header is displaying the correct email addresses.
    3. Go to request details.
    4. Change the request change currency.
    5. Go back to the report.
    6. Verify the request header has not changed.

    Do we agree 👍 or 👎

  20. sobitneupane commented on Oct 30, 2023

    @sobitneupane
    Contributor

    #26392 (comment)

    Requested payment on newDot.

  21. jliexpensify commented on Oct 30, 2023

    @jliexpensify
    Contributor

    Closing, thanks Sobit!

  22. JmillsExpensify commented on Nov 3, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @sobitneupane based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions