You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-02] [$500] Preferences - Shows blue color in Bottom Safearea when going offline #26425
changed the title [-]Preferences - Shows blue color in Bottom Safearea when going offline[/-][+][$500] Preferences - Shows blue color in Bottom Safearea when going offline[/+]on Sep 1, 2023
Please re-state the problem that we are trying to solve in this issue
Preferences - Shows blue color in Bottom Safearea when going offline
What is the root cause of that problem?
The Root Cause of this problem is on the Long Mobile screen (e.g. iPhone 13), the OfflineIndicator is having a gap as its not really at the bottom, thus the blue background from IllustratedHeaderPageLayout appears
What changes do you think we should make in order to solve the problem?
Fix the gap & position of OfflineIndicator component by changing the offlineIndicatorMobile styles of paddingBottom to 30 and marginBottom to -25 (to fill the gap and keep the position the same)
Confirmed with the team that the Slack date would work here, so I sent a proposal for the additional funds in Upwork. Please let me know as soon as you accept — thank you!
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
This should have caught in offline tests in the associated PR.
[@sobitneupane] Determine if we should create a regression test for this bug.
Yes.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)CortneyOfstad commentedon Sep 1, 2023
Was able to recreate very easily, so going to get eyes on this.
[-]Preferences - Shows blue color in Bottom Safearea when going offline[/-][+][$500] Preferences - Shows blue color in Bottom Safearea when going offline[/+]melvin-bot commentedon Sep 1, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01fe0ede226690a3a8
melvin-bot commentedon Sep 1, 2023
Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 1, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)studentofcoding commentedon Sep 1, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
Preferences - Shows blue color in Bottom Safearea when going offline
What is the root cause of that problem?
The Root Cause of this problem is on the Long Mobile screen (e.g. iPhone 13), the
OfflineIndicatoris having a gap as its not really at the bottom, thus the blue background fromIllustratedHeaderPageLayoutappearsWhat changes do you think we should make in order to solve the problem?
Fix the gap & position of
OfflineIndicatorcomponent by changing theofflineIndicatorMobilestyles ofpaddingBottom to 30andmarginBottom to -25(to fill the gap and keep the position the same)This way, the Safe Area bottom on
IllustratedHeaderPageLayoutpages will be fixedWhat alternative solutions did you explore? (Optional)
We can also have the same solution by adding a new Window dimension with the details below:
isSmallScreenWidthLongHeightonApp/src/components/withWindowDimensions.js
Lines 67 to 70 in a6a0572
offlineIndicatorMobileLongon styles.jsisSmallScreenWidthLongHeighton OfflineIndicator component condition and useofflineIndicatorMobileLongifisSmallScreenWidthLongHeighttrueResult
cc: @sobitneupane @CortneyOfstad
melvin-bot commentedon Sep 1, 2023
64 remaining items
CortneyOfstad commentedon Oct 4, 2023
Confirmed with the team that the Slack date would work here, so I sent a proposal for the additional funds in Upwork. Please let me know as soon as you accept — thank you!
DinalJivani commentedon Oct 4, 2023
Offer Accepted @CortneyOfstad
Thanks for quick action
CortneyOfstad commentedon Oct 4, 2023
@sobitneupane any update on the checklist above? Thanks!
sobitneupane commentedon Oct 5, 2023
Sorry for the delay. I am running quite behind schedule. I will work on checklist by the weekend.
sobitneupane commentedon Oct 9, 2023
#21852
#21852 (comment)
This should have caught in offline tests in the associated PR.
Yes.
#26425 (comment)
sobitneupane commentedon Oct 9, 2023
Regression Test Proposal
Do we agree 👍 or 👎
sobitneupane commentedon Oct 9, 2023
#26425 (comment)
Requested payment on newDot.
JmillsExpensify commentedon Oct 9, 2023
$750 payment approved for @sobitneupane based on this BZ summary.
CortneyOfstad commentedon Oct 11, 2023
@nkuoch any thoughts on the regression test proposal here?
nkuoch commentedon Oct 11, 2023
sounds good
CortneyOfstad commentedon Oct 11, 2023
Perfect! I'll get that GH created now 👍
CortneyOfstad commentedon Oct 11, 2023
Checklist updated above with the regression test link. Closing! Thanks all!