Skip to content

[HOLD for payment 2023-10-02] [$500] Preferences - Shows blue color in Bottom Safearea when going offline #26425

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go offline
  2. Go to settings -> Go to preferences
  3. See bottom Safearea

Expected Result:

It should be same as other Safearea color

Actual Result:

Shows blue color for bottom Safearea

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.60-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.7.MP4
0-02-01-2d51cddfb41db4128b5c382478dc2ebc52426e8d988e10695ceb1b48548ca0b3_cc06e62396a2b3a8.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: @DinalJivani

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692734918701659

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fe0ede226690a3a8
  • Upwork Job ID: 1697674109513048064
  • Last Price Increase: 2023-09-15

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 31, 2023
  2. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. CortneyOfstad commented on Sep 1, 2023

    @CortneyOfstad
    Contributor

    Was able to recreate very easily, so going to get eyes on this.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 1, 2023
  6. changed the title [-]Preferences - Shows blue color in Bottom Safearea when going offline[/-] [+][$500] Preferences - Shows blue color in Bottom Safearea when going offline[/+] on Sep 1, 2023
  7. melvin-bot commented on Sep 1, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 1, 2023
  9. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  11. studentofcoding commented on Sep 1, 2023

    @studentofcoding
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue

    Preferences - Shows blue color in Bottom Safearea when going offline

    What is the root cause of that problem?

    The Root Cause of this problem is on the Long Mobile screen (e.g. iPhone 13), the OfflineIndicator is having a gap as its not really at the bottom, thus the blue background from IllustratedHeaderPageLayout appears

    What changes do you think we should make in order to solve the problem?

    Fix the gap & position of OfflineIndicator component by changing the offlineIndicatorMobile styles of paddingBottom to 30 and marginBottom to -25 (to fill the gap and keep the position the same)

    offlineIndicatorMobile: {
            paddingLeft: 25,
            paddingTop: 5,
            paddingBottom: 30,
            marginBottom: -25,
    },
    

    This way, the Safe Area bottom on IllustratedHeaderPageLayout pages will be fixed

    What alternative solutions did you explore? (Optional)

    We can also have the same solution by adding a new Window dimension with the details below:

    1. Add a Long Mobile Screen as isSmallScreenWidthLongHeight on

    const isExtraSmallScreenWidth = windowDimension.windowWidth <= variables.extraSmallMobileResponsiveWidthBreakpoint;
    const isSmallScreenWidth = windowDimension.windowWidth <= variables.mobileResponsiveWidthBreakpoint;
    const isMediumScreenWidth = !isSmallScreenWidth && windowDimension.windowWidth <= variables.tabletResponsiveWidthBreakpoint;
    const isLargeScreenWidth = !isSmallScreenWidth && !isMediumScreenWidth;

    1. Add styles of offlineIndicatorMobileLong on styles.js
    offlineIndicatorMobileLong: {
            paddingLeft: 25,
            paddingTop: 5,
            paddingBottom: 30,
            marginBottom: -25,
    },
    
    1. Use isSmallScreenWidthLongHeight on OfflineIndicator component condition and use offlineIndicatorMobileLong if isSmallScreenWidthLongHeight true

    Result

    • After - iPhone 14 Pro
    Screenshot 2023-09-02 at 03 21 22
    • Before - iPhone 14 Pro
    Screenshot 2023-09-02 at 03 02 13
    • On Small Screen - iPhone SE
    Screenshot 2023-09-03 at 04 15 07

    cc: @sobitneupane @CortneyOfstad

  12. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    ⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

  13. 64 remaining items

  14. CortneyOfstad commented on Oct 4, 2023

    @CortneyOfstad
    Contributor

    Confirmed with the team that the Slack date would work here, so I sent a proposal for the additional funds in Upwork. Please let me know as soon as you accept — thank you!

  15. DinalJivani commented on Oct 4, 2023

    @DinalJivani

    Offer Accepted @CortneyOfstad
    Thanks for quick action

  16. CortneyOfstad commented on Oct 4, 2023

    @CortneyOfstad
    Contributor

    @sobitneupane any update on the checklist above? Thanks!

  17. sobitneupane commented on Oct 5, 2023

    @sobitneupane
    Contributor

    Sorry for the delay. I am running quite behind schedule. I will work on checklist by the weekend.

  18. sobitneupane commented on Oct 9, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

    #21852

    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #21852 (comment)

    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    This should have caught in offline tests in the associated PR.

    • [@sobitneupane] Determine if we should create a regression test for this bug.

    Yes.

    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    #26425 (comment)

  19. sobitneupane commented on Oct 9, 2023

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Go offline
    2. Go to settings -> Go to preferences
    3. Verify that offline indicator is shown at the bottom and blue color padding is not present at the bottom.

    Do we agree 👍 or 👎

  20. sobitneupane commented on Oct 9, 2023

    @sobitneupane
    Contributor

    #26425 (comment)

    Requested payment on newDot.

  21. JmillsExpensify commented on Oct 9, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @sobitneupane based on this BZ summary.

  22. CortneyOfstad commented on Oct 11, 2023

    @CortneyOfstad
    Contributor

    @nkuoch any thoughts on the regression test proposal here?

  23. nkuoch commented on Oct 11, 2023

    @nkuoch
    Contributor

    sounds good

  24. CortneyOfstad commented on Oct 11, 2023

    @CortneyOfstad
    Contributor

    Perfect! I'll get that GH created now 👍

  25. CortneyOfstad commented on Oct 11, 2023

    @CortneyOfstad
    Contributor

    Checklist updated above with the regression test link. Closing! Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions