You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Web - Money request - Workspace member is missing from the workspace when requesting money for workspace #26428
Select a workspace from the list if there is a workspace or create a new one
click member
click invite
Add members to invite
click next
Click invite
Click the + icon from LHN
click request money
Enter the amount
select the workspace from the list
Click the header from the IOU report
Observe the number of member
Expected Result:
The total number of the members should be correct
Actual Result:
The total number of the members is not correct
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.60.3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
This looks like quite a major bug!
I was checking it and found that not even the request for the money went through to the other end. (That's the whole point of the app right?)
But workspace expense chat report has only one participant id, so total number of the members is 1, and is different with total numbers of the workspace.
What changes do you think we should make to solve the problem?
We can display total number of workspace members if report is workspace room.
Add withPolicy HOC to ReportDetailsPage and ReportParticipantsPage.
In ReportDetailsPage, if report is workspace room, we should display total number of workspace members.
In ReportParticipantsPage, we should display workspace members.
We add policyMembers parameter to getAllParticipants, and pass props.policyMembers.
And in getAllParticipants, we check if the report is workspace room, and then add workspace members.
changed the title [-]Web - Money request - Workspace member is missing from the workspace when requesting money for workspace[/-][+][$500] Web - Money request - Workspace member is missing from the workspace when requesting money for workspace[/+]on Sep 1, 2023
I believe this is expected, you only see 1 member because there's only one member in that specific chat. Inviting other members in workspace will just create new reports related to that workspace.
I feel the bug here is that in selection page we display the workspace chat related to a specific user but at the confirmation page we just display the workspace report and it seems confusing because it looks like we are requesting the money from all the users from that workspace.
Activity
melvin-bot commentedon Aug 31, 2023
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Aug 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)AJV009 commentedon Aug 31, 2023
This looks like quite a major bug!
I was checking it and found that not even the request for the money went through to the other end. (That's the whole point of the app right?)
StevenKKC commentedon Sep 1, 2023
Proposal
Please state again the problem we are trying to solve in this issue.
Workspace member is missing from the workspace when requesting money for workspace.
What is the cause of this issue?
If click header from IOU report,
ReportDetailsPageis displayed, and inReportDetailsPage, we display report'sparticipantAccountIDs.App/src/pages/ReportDetailsPage.js
Line 73 in ec95ab0
App/src/pages/ReportDetailsPage.js
Lines 90 to 101 in ec95ab0
But workspace expense chat report has only one participant id, so total number of the members is 1, and is different with total numbers of the workspace.
What changes do you think we should make to solve the problem?
We can display total number of workspace members if report is workspace room.
withPolicyHOC toReportDetailsPageandReportParticipantsPage.ReportDetailsPage, if report is workspace room, we should display total number of workspace members.And change this line as below.
ReportParticipantsPage, we should display workspace members.We add
policyMembersparameter togetAllParticipants, and passprops.policyMembers.And in
getAllParticipants, we check if the report is workspace room, and then add workspace members.What alternative solutions have you investigated? (Optional)
None.
[-]Web - Money request - Workspace member is missing from the workspace when requesting money for workspace[/-][+][$500] Web - Money request - Workspace member is missing from the workspace when requesting money for workspace[/+]melvin-bot commentedon Sep 1, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0152b582c375b0403c
melvin-bot commentedon Sep 1, 2023
Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 1, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)melvin-bot commentedon Sep 4, 2023
@stephanieelliott, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
thesahindia commentedon Sep 4, 2023
I believe this is expected, you only see 1 member because there's only one member in that specific chat. Inviting other members in workspace will just create new reports related to that workspace.
thesahindia commentedon Sep 4, 2023
@stephanieelliott, I think we should close this issue.
thesahindia commentedon Sep 4, 2023
I feel the bug here is that in selection page we display the workspace chat related to a specific user but at the confirmation page we just display the workspace report and it seems confusing because it looks like we are requesting the money from all the users from that workspace.
stephanieelliott commentedon Sep 8, 2023
Ah yeah, I agree with you @thesahindia. Thinking about it that way this behavior would be expected.