Skip to content

[HOLD for payment 2023-10-09] [$500] Chat - 'Yesterday' is displayed even when new messages are sent #26477

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app and login with user A
  2. Set your timezone to a timezone which will currently have previous day or next day
  3. Open the app in another device and login with user B
  4. Set the timezone same as the one set in step 2
  5. From user A, send message to user B and observe that it displays 'Yesterday'/'Tomorrow' even for new message

Expected Result:

App should not display 'Yesterday'/'Tomorrow' for new messages

Actual Result:

If the set timezone has previous day or next day then your current timezone, it displays 'Yesterday'/'Tomorrow' even for new messages

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.61.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

image (26)

Yesterday.or.tomorrow.new.message.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693045224630199

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010874e09785851529
  • Upwork Job ID: 1699572386152280064
  • Last Price Increase: 2023-09-06
  • Automatic offers:
    • dhanashree-sawant | Reporter | 26767694

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 1, 2023
  2. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. joekaufmanexpensify commented on Sep 4, 2023

    @joekaufmanexpensify
    Contributor

    OOO today, will triage tomorrow!

  5. joekaufmanexpensify commented on Sep 6, 2023

    @joekaufmanexpensify
    Contributor

    Triaging today!

  6. joekaufmanexpensify commented on Sep 6, 2023

    @joekaufmanexpensify
    Contributor

    Reproduced. The time of the message is changing, we just aren't using the correct word out of today, tomorrow, and . yesterday`.

    2023-09-06_19-52-27.mp4
  7. changed the title [-]Chat - 'Yesterday' is displayed even when new messages are sent[/-] [+][$500] Chat - 'Yesterday' is displayed even when new messages are sent[/+] on Sep 6, 2023
  8. melvin-bot commented on Sep 6, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 6, 2023
  10. melvin-bot commented on Sep 6, 2023

    @melvin-bot

    Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

  11. 53 remaining items

  12. added and removed on Oct 9, 2023
  13. joekaufmanexpensify commented on Oct 9, 2023

    @joekaufmanexpensify
    Contributor

    Bumped checklist in Slack.

  14. burczu commented on Oct 10, 2023

    @burczu
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@burczu] The PR that introduced the bug has been identified. Link to the PR: It was introduced while replacing moment library by the date-fns lib, so I don't think we should treat it as regression.
    • [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
    • [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
    • [@burczu] Determine if we should create a regression test for this bug.
    • [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. joekaufmanexpensify commented on Oct 10, 2023

    @joekaufmanexpensify
    Contributor

    BZ checklist is complete, all set to issue payment!

  16. joekaufmanexpensify commented on Oct 10, 2023

    @joekaufmanexpensify
    Contributor

    This PR does not qualify for a speed bonus. So we need to issue the following payments:

  17. joekaufmanexpensify commented on Oct 10, 2023

    @joekaufmanexpensify
    Contributor

    @abzokhattab $500 sent and contract ended!

  18. joekaufmanexpensify commented on Oct 10, 2023

    @joekaufmanexpensify
    Contributor

    @dhanashree-sawant - $50 sent and contract ended!

  19. joekaufmanexpensify commented on Oct 10, 2023

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  20. joekaufmanexpensify commented on Oct 10, 2023

    @joekaufmanexpensify
    Contributor

    Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!

  21. added
    ReviewingHas a PR in review
    and removed on Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions