You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-09] [$500] Chat - 'Yesterday' is displayed even when new messages are sent #26477
Set your timezone to a timezone which will currently have previous day or next day
Open the app in another device and login with user B
Set the timezone same as the one set in step 2
From user A, send message to user B and observe that it displays 'Yesterday'/'Tomorrow' even for new message
Expected Result:
App should not display 'Yesterday'/'Tomorrow' for new messages
Actual Result:
If the set timezone has previous day or next day then your current timezone, it displays 'Yesterday'/'Tomorrow' even for new messages
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.61.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Chat - 'Yesterday' is displayed even when new messages are sent[/-][+][$500] Chat - 'Yesterday' is displayed even when new messages are sent[/+]on Sep 6, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@burczu] The PR that introduced the bug has been identified. Link to the PR: It was introduced while replacing moment library by the date-fns lib, so I don't think we should treat it as regression.
[@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
[@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[@burczu] Determine if we should create a regression test for this bug.
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Sep 1, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 1, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)joekaufmanexpensify commentedon Sep 4, 2023
OOO today, will triage tomorrow!
joekaufmanexpensify commentedon Sep 6, 2023
Triaging today!
joekaufmanexpensify commentedon Sep 6, 2023
Reproduced. The time of the message is changing, we just aren't using the correct word out of
today,tomorrow, and.yesterday`.2023-09-06_19-52-27.mp4
[-]Chat - 'Yesterday' is displayed even when new messages are sent[/-][+][$500] Chat - 'Yesterday' is displayed even when new messages are sent[/+]melvin-bot commentedon Sep 6, 2023
Job added to Upwork: https://www.upwork.com/jobs/~010874e09785851529
melvin-bot commentedon Sep 6, 2023
Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.
53 remaining items
joekaufmanexpensify commentedon Oct 9, 2023
Bumped checklist in Slack.
burczu commentedon Oct 10, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
momentlibrary by thedate-fnslib, so I don't think we should treat it as regression.joekaufmanexpensify commentedon Oct 10, 2023
BZ checklist is complete, all set to issue payment!
joekaufmanexpensify commentedon Oct 10, 2023
This PR does not qualify for a speed bonus. So we need to issue the following payments:
joekaufmanexpensify commentedon Oct 10, 2023
@abzokhattab $500 sent and contract ended!
joekaufmanexpensify commentedon Oct 10, 2023
@dhanashree-sawant - $50 sent and contract ended!
joekaufmanexpensify commentedon Oct 10, 2023
Upwork job closed.
joekaufmanexpensify commentedon Oct 10, 2023
Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!