You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-02] [$500] IOU - Losing focus on the amount input field when switching between apps #26505
Switch to other app by swiping with 3 fingers gesture (do not use comant +tab)
Open back the New Expensify app by swiping with 3 fingers gesture (do not use comant +tab)
Press any number keys on the keyboard
Expected Result:
Amount input label should be focused when user switched back to the app
Actual Result:
Losing focus on the amount input field for Request Money/Split bills when switching between apps by 3 fingers swipe gesture when app in fullscreen view
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.61-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
useEffect(()=>{constunsubscribeVisibilityListener=Visibility.onVisibilityChange(()=>{// focus the text input when the app is back in the foregroundif(Visibility.isVisible()&&textInput.current){textInput.current.focus();}});return()=>{unsubscribeVisibilityListener();};},[]);
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this type of bug is easy to catch when testing, the only complication here is that it's specific to only a single platform (Desktop)
Determine if we should create a regression test for this bug. While the bug doesn't impact user experience, there is a probability of it re-appearing with a RN/Electron/MacOS update, all of which are outside of our control. I think we might want to implement a regression test
when @tienifr got assigned: 2023-09-19 04:05:42 Z
when the PR got merged: 2023-09-22 08:08:07 UTC
the pull request did not get merged within 3 working days of assignment.
I don't think that's correct, the PR was merged on 22th, which isn't a working day, so it was merged in 2 business days
External issue reporter — Applause, so does not require payment
Contributor that fixed the issue — @tienifr paid **$500 (**does not qualify to the bonus based)
Contributor+ that helped on the issue and/or PR — @eVoloshchak paid via NewDot ($500) — additional $250 to be paid via NewDot
Activity
ishpaul777 commentedon Sep 2, 2023
Proposal
Problem
IOU - Losing focus on the amount input field when switching between apps
Root Cause
When user is switch window the focus is lost from text input and when user is back to app input is not focussed
Chnages
we can use visibilitylistner to focus back on textInput in MoneyRequestAmountForm when user switch back to app.
Without Changes
Screen.Recording.2023-09-02.at.3.33.58.PM.mov
With Changes
Screen.Recording.2023-09-02.at.3.37.11.PM.mov
melvin-bot commentedon Sep 5, 2023
Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
ishpaul777 commentedon Sep 7, 2023
@lanitochka17 No one is assigned to the issue, looks like automation failed.
melvin-bot commentedon Sep 8, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 8, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)CortneyOfstad commentedon Sep 8, 2023
Getting eyes on this 👍
49 remaining items
eVoloshchak commentedon Oct 4, 2023
eVoloshchak commentedon Oct 4, 2023
Regression Test Proposal
web/mweb/desktop
Do we agree 👍 or 👎
eVoloshchak commentedon Oct 4, 2023
I don't think that's correct, the PR was merged on 22th, which isn't a working day, so it was merged in 2 business days
@CortneyOfstad, could you double-check that please?
CortneyOfstad commentedon Oct 9, 2023
@thienlnam Does that sound correct to you ^^^
Just want a second pair of eyes on this
thienlnam commentedon Oct 9, 2023
Why isn't the 22nd a working day? Granted the PR was approved and required no updates from me on the 21st, so we can give the bonus here
eVoloshchak commentedon Oct 9, 2023
Oh my bad, I was looking at the calendar for October by mistake
Sorry for the confusion😅
CortneyOfstad commentedon Oct 11, 2023
No worries @eVoloshchak! I sent you a proposal in Upwork for the additional $250 bonus amount. Please let me know once you approve it!
Creating the regression test GH now 👍
CortneyOfstad commentedon Oct 11, 2023
Checklist above updated with Regression Test link 👍
eVoloshchak commentedon Oct 11, 2023
No need for Upwork, I'll just send the payment request via NewDot
CortneyOfstad commentedon Oct 11, 2023
Sounds good! Closing!
CortneyOfstad commentedon Oct 11, 2023
Payment Breakdown:
External issue reporter — Applause, so does not require payment
Contributor that fixed the issue — @tienifr paid **$500 (**does not qualify to the bonus based)
Contributor+ that helped on the issue and/or PR — @eVoloshchak paid via NewDot ($500) — additional $250 to be paid via NewDot
JmillsExpensify commentedon Oct 11, 2023
$750 payment approved for @eVoloshchak based on summary immediately above.