Skip to content

[HOLD for payment 2023-10-02] [$500] IOU - Losing focus on the amount input field when switching between apps #26505

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app in fullscreen view
  2. Tap on FAB
  3. Tap on Request money or Split bill
  4. Switch to other app by swiping with 3 fingers gesture (do not use comant +tab)
  5. Open back the New Expensify app by swiping with 3 fingers gesture (do not use comant +tab)
  6. Press any number keys on the keyboard

Expected Result:

Amount input label should be focused when user switched back to the app

Actual Result:

Losing focus on the amount input field for Request Money/Split bills when switching between apps by 3 fingers swipe gesture when app in fullscreen view

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.61-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6185121_Recording__279.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f419594d979a6b3d
  • Upwork Job ID: 1700176267856764928
  • Last Price Increase: 2023-09-15
  • Automatic offers:
    • tienifr | Contributor | 26746042

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 1, 2023
  2. ishpaul777 commented on Sep 2, 2023

    @ishpaul777
    Contributor

    Proposal

    Problem

    IOU - Losing focus on the amount input field when switching between apps

    Root Cause

    When user is switch window the focus is lost from text input and when user is back to app input is not focussed

    Chnages

    we can use visibilitylistner to focus back on textInput in MoneyRequestAmountForm when user switch back to app.

    useEffect(() => {
            const unsubscribeVisibilityListener = Visibility.onVisibilityChange(() => {
                // focus the text input when the app is back in the foreground
                if (Visibility.isVisible() && textInput.current) {
                    textInput.current.focus();
                }
            });
            return () => {
                unsubscribeVisibilityListener();
            };
        }, []);
    Without Changes

    Screen.Recording.2023-09-02.at.3.33.58.PM.mov

    With Changes

    Screen.Recording.2023-09-02.at.3.37.11.PM.mov

  3. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  4. ishpaul777 commented on Sep 7, 2023

    @ishpaul777
    Contributor

    @lanitochka17 No one is assigned to the issue, looks like automation failed.

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 8, 2023
  6. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. CortneyOfstad commented on Sep 8, 2023

    @CortneyOfstad
    Contributor

    Getting eyes on this 👍

  9. 49 remaining items

  10. eVoloshchak commented on Oct 4, 2023

    @eVoloshchak
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Changed the Amount Text to TextInput #6811
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/6811/files#r1345751207
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this type of bug is easy to catch when testing, the only complication here is that it's specific to only a single platform (Desktop)
    • Determine if we should create a regression test for this bug. While the bug doesn't impact user experience, there is a probability of it re-appearing with a RN/Electron/MacOS update, all of which are outside of our control. I think we might want to implement a regression test
  11. eVoloshchak commented on Oct 4, 2023

    @eVoloshchak
    Contributor

    Regression Test Proposal
    web/mweb/desktop

    1. Open the app in fullscreen view
    2. Tap on FAB
    3. Tap on Request money or Split bill
    4. Switch to another app by swiping with 3 fingers gesture (do not use command+tab)
    5. Open back the New Expensify app by swiping with 3 fingers gesture (do not use command+tab)
    6. Verify that the amount input is focused when you switched back to the app

    Do we agree 👍 or 👎

  12. eVoloshchak commented on Oct 4, 2023

    @eVoloshchak
    Contributor

    when @tienifr got assigned: 2023-09-19 04:05:42 Z
    when the PR got merged: 2023-09-22 08:08:07 UTC
    the pull request did not get merged within 3 working days of assignment.

    I don't think that's correct, the PR was merged on 22th, which isn't a working day, so it was merged in 2 business days

    @CortneyOfstad, could you double-check that please?

  13. CortneyOfstad commented on Oct 9, 2023

    @CortneyOfstad
    Contributor

    @thienlnam Does that sound correct to you ^^^

    Just want a second pair of eyes on this

  14. thienlnam commented on Oct 9, 2023

    @thienlnam
    Contributor

    Why isn't the 22nd a working day? Granted the PR was approved and required no updates from me on the 21st, so we can give the bonus here

  15. eVoloshchak commented on Oct 9, 2023

    @eVoloshchak
    Contributor

    Why isn't the 22nd a working day?

    Oh my bad, I was looking at the calendar for October by mistake
    Sorry for the confusion😅

  16. CortneyOfstad commented on Oct 11, 2023

    @CortneyOfstad
    Contributor

    No worries @eVoloshchak! I sent you a proposal in Upwork for the additional $250 bonus amount. Please let me know once you approve it!

    Creating the regression test GH now 👍

  17. CortneyOfstad commented on Oct 11, 2023

    @CortneyOfstad
    Contributor

    Checklist above updated with Regression Test link 👍

  18. eVoloshchak commented on Oct 11, 2023

    @eVoloshchak
    Contributor

    No need for Upwork, I'll just send the payment request via NewDot

  19. CortneyOfstad commented on Oct 11, 2023

    @CortneyOfstad
    Contributor

    Sounds good! Closing!

  20. CortneyOfstad commented on Oct 11, 2023

    @CortneyOfstad
    Contributor

    Payment Breakdown:

    External issue reporter — Applause, so does not require payment
    Contributor that fixed the issue — @tienifr paid **$500 (**does not qualify to the bonus based)
    Contributor+ that helped on the issue and/or PR — @eVoloshchak paid via NewDot ($500) — additional $250 to be paid via NewDot

  21. JmillsExpensify commented on Oct 11, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @eVoloshchak based on summary immediately above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions