Skip to content

[HOLD for payment 2023-10-25] [$500] Web - The horizontal line separating the header and the messages in the IOU report room disappears and reappears irregularly #26529

Closed
Closed
[HOLD for payment 2023-10-25] [$500] Web - The horizontal line separating the header and the messages in the IOU report room disappears and reappears irregularly#26529
Assignees
zukiloverdeetergpjoekaufmanexpensifyrobertKozik
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Description

@kbecciv
kbecciv
opened on Sep 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  • You Can open any IOU report room and skip the first two steps
  1. Click on the FAB and request Money from any user this will take you to that chat room
  2. Click on the IOU message to open the IOU report room
  3. Hover over the first Message in the IOU report room and mark it as unread
  4. Now notice the unread mark appears and the grey horizontal line still appears
  5. leave the the IOU report room and return
  6. Notice the horizontal grey line disappears
  7. Hover over the first message again and mark it as unread again
  8. Now the horizontal grey line appears again

Expected Result:

The unread indicator should be consistently be aligned with the grey bar in IOUs/tasks.

Actual Result:

The horizontal line separating the header and the messages in the IOU report room disappears and reappears irregularly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.61.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.28-08-23.02_23_41.webm
Recording.4176.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693183486459189

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a365a66bcfc380e7
  • Upwork Job ID: 1699177381705969664
  • Last Price Increase: 2023-09-05
  • Automatic offers:
    • Ahmed-Abdella | Reporter | 26638143

Activity

  1. kbecciv
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 1, 2023

  2. melvin-bot commented on Sep 1, 2023

    @melvin-bot
    melvin-botBot
    on Sep 1, 2023

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot
    assigned
    joekaufmanexpensify
    on Sep 1, 2023

  4. melvin-bot commented on Sep 1, 2023

    @melvin-bot
    melvin-botBot
    on Sep 1, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. melvin-bot
    added
    Overdue
    on Sep 4, 2023

  6. joekaufmanexpensify commented on Sep 4, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Sep 4, 2023
    Contributor

    OOO today, will triage tomorrow!

  7. melvin-bot
    removed
    Overdue
    on Sep 4, 2023

  8. joekaufmanexpensify commented on Sep 5, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Sep 5, 2023
    Contributor

    The behavior of the unread indicator here is consistent with the rest of the app. We just need to figure out the alignment of the unread bar. This same issue also applies to tasks, we should fix both here.

    IMO, we should just change the unread alignment, so the unread indicator consistently matches the grey bar. (This is what we do in regular chat threads).

  9. joekaufmanexpensify commented on Sep 5, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Sep 5, 2023
    Contributor

    Or alternatively, perhaps there shouldn't be margin between the top the first message in the IOU/task room and the grey bar.

  10. joekaufmanexpensify
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 5, 2023
  11. melvin-bot
    changed the title [-]Web - The horizontal line separating the header and the messages in the IOU report room disappears and reappears irregularly[/-] [+][$500] Web - The horizontal line separating the header and the messages in the IOU report room disappears and reappears irregularly[/+] on Sep 5, 2023

  12. melvin-bot commented on Sep 5, 2023

    @melvin-bot
    melvin-botBot
    on Sep 5, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~01a365a66bcfc380e7

  13. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 5, 2023

  14. melvin-bot commented on Sep 5, 2023

    @melvin-bot
    melvin-botBot
    on Sep 5, 2023

    Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

  15. 60 remaining items

  16. melvin-bot commented on Oct 18, 2023

    @melvin-bot
    melvin-botBot
    on Oct 18, 2023

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  17. joekaufmanexpensify commented on Oct 23, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 23, 2023
    Contributor

    @robertKozik mind completing the BZ checklist here so we can prep to close this one?

  18. robertKozik commented on Oct 23, 2023

    @robertKozik
    robertKozik
    on Oct 23, 2023
    Contributor
    • [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: It had more feature-like vibe, as it was consistent behaviour which needed to be changed (context)
    • [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@robertKozik] Determine if we should create a regression test for this bug. I think we don't need it for this one
    • [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
  19. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 25, 2023

  20. joekaufmanexpensify commented on Oct 25, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 25, 2023
    Contributor

    Great, ty!

  21. joekaufmanexpensify commented on Oct 25, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 25, 2023
    Contributor

    BZ checklist is complete, so we need to now issue payment. Here's a summary of payments:

  22. joekaufmanexpensify commented on Oct 25, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 25, 2023
    Contributor

    @zukilover your $500 was already previously paid out from when you submitted your work for approval in Upwork. I ended your contract!

  23. joekaufmanexpensify commented on Oct 25, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 25, 2023
    Contributor

    @Ahmed-Abdella $50 sent and contract ended!

  24. joekaufmanexpensify commented on Oct 25, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 25, 2023
    Contributor

    Also noting that the initial PR was completed in less than 9 days, which is why no urgency penalty applied here. We later than decided to do a second clean up PR, which was also merged in less than 9 days.

  25. joekaufmanexpensify commented on Oct 25, 2023

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 25, 2023
    Contributor

    Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!

  26. joekaufmanexpensify
    closed this as completedon Oct 25, 2023
  27. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    on Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions