Skip to content

[HOLD for payment 2023-09-27] [$500] IOS - Mention list open again after requesting money #26534

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any report, type @
  2. Go back to LHN, click Plus button and choose request money, request any amount to the above report.
  3. Repeat above steps few times.
  4. Notice that mention list is opened even composer is not focused.

Expected Result:

If composer is not focused, mention list shouldn't be opened.

Actual Result:

Mention list is opened even when composer is not focused.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.61.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1693134852.MP4
RPReplay_Final1693603547.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693194595071649

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014c468cc852a95d2d
  • Upwork Job ID: 1699131259631747072
  • Last Price Increase: 2023-09-05
  • Automatic offers:
    • cubuspl42 | Reviewer | 26637784
    • akinwale | Contributor | 26637787
    • hungvu193 | Reporter | 26637788

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 1, 2023
  2. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 1, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. akinwale commented on Sep 1, 2023

    @akinwale
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The Mentions list opens again after requesting money even if the composer is not focused.

    What is the root cause of that problem?

    The onSelectionChange event handler in ComposerWithSuggestions triggers a recalculation of the suggestions by calling suggestionsRef.current.onSelectionChange(e). Based on the implementation of the onSelectionChange from the current suggestion ref, this recalculation ends up rendering the mentions list even when the text input is not focused.

    calculateMentionSuggestion(e.nativeEvent.selection.end);

    Additionally, The Suggestions component in ComposerWithSuggestions is not conditionally rendered based on whether or not the composer currently has focus.

    What changes do you think we should make in order to solve the problem?

    Solution 1
    In the onSelectionChange handler for the ComposerWithSuggestions component, perform an early return if the text input ref is not currently focused.

     const onSelectionChange = useCallback(
        (e) => {
    +        if (!textInputRef.current.isFocused()) {
    +            return;
    +        }
            if (suggestionsRef.current.onSelectionChange(e)) {
                return;
            }
    
            setSelection(e.nativeEvent.selection);
        },
        [suggestionsRef],
    );

    Solution 2
    Conditionally render the Suggestions component using ReportActionComposeFocusManager.isFocused(), or using a local state variable which tracks whether or not the composer is currently focused.

    {ReportActionComposeFocusManager.isFocused() && <Suggestions
        ref={suggestionsRef}
        ...
    />
    

    Also update the areas where suggestionsRef.current is being used to prevent crash errors due to trying to access a null / undefined ref.

    What alternative solutions did you explore? (Optional)

    None.

    26534-demo.mp4
  5. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    @tjferriss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 5, 2023
  7. changed the title [-]IOS - Mention list open again after requesting money[/-] [+][$500] IOS - Mention list open again after requesting money[/+] on Sep 5, 2023
  8. melvin-bot commented on Sep 5, 2023

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 5, 2023
  10. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

  11. tjferriss commented on Sep 5, 2023

    @tjferriss
    Contributor

    I was able to reproduce the bug on staging.

  12. 25 remaining items

  13. changed the title [-][$500] IOS - Mention list open again after requesting money[/-] [+][HOLD for payment 2023-09-27] [$500] IOS - Mention list open again after requesting money[/+] on Sep 20, 2023
  14. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-27. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Sep 20, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
    • [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@cubuspl42] Determine if we should create a regression test for this bug.
    • [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. jakub-trzebiatowski commented on Sep 21, 2023

    @jakub-trzebiatowski
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
      • No need for additional discussion
    • Determine if we should create a regression test for this bug.
      • No need for a new regression test
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
      • N/A
  18. tjferriss commented on Sep 25, 2023

    @tjferriss
    Contributor

    Payment Summary:

    Eligible for the 50% speed bonus

  19. tjferriss commented on Sep 29, 2023

    @tjferriss
    Contributor

    Everyone has been paid out via Upworks. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions