You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-13] [HOLD for payment 2023-09-12] [$500] BUG: [distance] request next button is hidden on small height screens #26541
changed the title [-]BUG: [distance] request next button is hidden on small height screens[/-][+][$500] BUG: [distance] request next button is hidden on small height screens[/+]on Sep 1, 2023
@mananjadhav@ntdiary and @allroundexperts — I've sent job offers to each of you in Upwork. Please accept them as soon as you can so I can get those paid out. Thanks for your patience with this, and always – if you have any questions, just let me know!
No worries! I've withdrawn the offer in Upwork! Feel free to make the request in the app, and let me know if any additional info is needed on my part to get that paid!
@CortneyOfstad I will raise the request on NewDot. No upwork needed. Also can you confirm or acknowledge the posted payout summary? I'll need it for approval on the NewDot.
@allroundexperts - 750$ — TO BE PAID IN NEWDOT @ntdiary - 500$ (they reviewed the PR) — ALREADY PAID IN UPWORK @mananjadhav - 250$ — TO BE PAID IN NEWDOT
Activity
melvin-bot commentedon Sep 1, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 1, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]BUG: [distance] request next button is hidden on small height screens[/-][+][$500] BUG: [distance] request next button is hidden on small height screens[/+]melvin-bot commentedon Sep 1, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0131f651439d571fb4
melvin-bot commentedon Sep 1, 2023
Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 1, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)neonbhai commentedon Sep 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
[distance] request next button is hidden on small height screens
What is the root cause of that problem?
New Feature
What changes do you think we should make in order to solve the problem?
Solution 1:
isExtraSmallScreenHeightusing useWindowDimensions and only render MapView if the the screen is not extra smallApp/src/components/DistanceRequest.js
Lines 228 to 230 in 8fbe6aa
and then render the mapView container conditionally:
Solution 2:
styles.displayNoneto themapViewContainerCSS itself if the view is small here:App/src/styles/styles.js
Lines 3869 to 3875 in 8fbe6aa
What alternative solutions did you explore? (Optional)
xx
RPSanchez commentedon Sep 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
[distance] request next button is hidden on small height screens
What is the root cause of that problem?
The code initially renders both the map and the request button without considering the available screen height.
What changes do you think we should make in order to solve the problem?
<View style={[styles.flexRow, styles.justifyContentCenter, styles.pt1]}>
What alternative solutions did you explore? (Optional)
Rendering exclusively the map at a certain size, with user interaction then making the request button available.
67 remaining items
mananjadhav commentedon Sep 27, 2023
Yes @CortneyOfstad it includes the bonus.
CortneyOfstad commentedon Sep 27, 2023
Thanks!
@mananjadhav @ntdiary and @allroundexperts — I've sent job offers to each of you in Upwork. Please accept them as soon as you can so I can get those paid out. Thanks for your patience with this, and always – if you have any questions, just let me know!
allroundexperts commentedon Sep 27, 2023
Hi @CortneyOfstad!
I get paid through the app.
CortneyOfstad commentedon Sep 27, 2023
No worries! I've withdrawn the offer in Upwork! Feel free to make the request in the app, and let me know if any additional info is needed on my part to get that paid!
CortneyOfstad commentedon Sep 29, 2023
@ntdiary Contract has been paid, so you should be all set!
@mananjadhav It shows that the proposal in Upwork is still waiting for you to accept — please let me know as soon as you complete this. Thank you!
mananjadhav commentedon Oct 2, 2023
@CortneyOfstad I will raise the request on NewDot. No upwork needed. Also can you confirm or acknowledge the posted payout summary? I'll need it for approval on the NewDot.
CortneyOfstad commentedon Oct 3, 2023
@mananjadhav Sounds good!
The payment breakdown is shared below:
@allroundexperts - 750$ — TO BE PAID IN NEWDOT
@ntdiary - 500$ (they reviewed the PR) — ALREADY PAID IN UPWORK
@mananjadhav - 250$ — TO BE PAID IN NEWDOT
CortneyOfstad commentedon Oct 3, 2023
@mananjadhav @allroundexperts once you are both paid in NewDot, please let me know here so I can then close this out. Thanks!
mananjadhav commentedon Oct 3, 2023
I think we can close once @allroundexperts has raised. I've raised my request.
allroundexperts commentedon Oct 3, 2023
I have raised mine as well. Thank you @mananjadhav and @CortneyOfstad!
JmillsExpensify commentedon Oct 5, 2023
$750 payment approved for @allroundexperts based on BZ summary.
JmillsExpensify commentedon Oct 5, 2023
$250 payment approved for @mananjadhav based on BZ summary.