You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [Distance] - Distance editor menu in IOU report shows Merchant instead of Distance #26559
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
So here are the changes I suggest:
In MoneyRequestView, add a specific MenuItemWithTopDescription for Distance
Add CONST.EDIT_REQUEST_FIELD.DISTANCE in the const file
In EditRequestPage add a condition to test if the field is distance and navigate to the new page EditRequestDistancePage that will look like EditRequestMerchantPage but with the right text
What alternative solutions did you explore? (Optional)
The alternative is to test if this is a distance request in EditRequestMerchantPage to display the right text, and we also would need to test that in the submit method to save in the right field
changed the title [-]Distance IOU - Distance editor menu in IOU report shows Merchant instead of Distance[/-][+][$500] Distance IOU - Distance editor menu in IOU report shows Merchant instead of Distance[/+]on Sep 3, 2023
changed the title [-][$500] Distance IOU - Distance editor menu in IOU report shows Merchant instead of Distance[/-][+][$500] [Distance] - Distance editor menu in IOU report shows Merchant instead of Distance[/+]on Sep 5, 2023
Activity
OSBotify commentedon Sep 2, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 2, 2023
Triggered auto assignment to @jasperhuangg (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.ShogunFire commentedon Sep 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The text of the header and of the input are "Merchant" instead of Distance
What is the root cause of that problem?
In MoneyRequestView here:
App/src/components/ReportActionItem/MoneyRequestView.js
Lines 154 to 164 in 9701fbe
We have only one MenuItemWithTopDescription for both Merchant and Distance and we navigate to the same page for both.
The page we navigate to is https://github.com/Expensify/App/blob/main/src/pages/EditRequestMerchantPage.js
In this page we display Merchant and never Distance
What changes do you think we should make in order to solve the problem?
I think we should do a page specific for Distance because currently when we submit we actually save the distance in the merchant field here:
App/src/pages/EditRequestPage.js
Lines 159 to 166 in 9701fbe
So here are the changes I suggest:
In MoneyRequestView, add a specific MenuItemWithTopDescription for Distance
Add CONST.EDIT_REQUEST_FIELD.DISTANCE in the const file
In EditRequestPage add a condition to test if the field is distance and navigate to the new page EditRequestDistancePage that will look like EditRequestMerchantPage but with the right text
What alternative solutions did you explore? (Optional)
The alternative is to test if this is a distance request in EditRequestMerchantPage to display the right text, and we also would need to test that in the submit method to save in the right field
situchan commentedon Sep 2, 2023
This will be fixed in Edit distance request PR
[-]Distance IOU - Distance editor menu in IOU report shows Merchant instead of Distance[/-][+][$500] Distance IOU - Distance editor menu in IOU report shows Merchant instead of Distance[/+]melvin-bot commentedon Sep 3, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01c148f42c5bc47bd3
14 remaining items
melvin-bot commentedon Sep 3, 2023
Triggered auto assignment to @zanyrenney (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 3, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (
External)hayata-suenaga commentedon Sep 3, 2023
I'm so bad at assigning labels 😭
b4s36t4 commentedon Sep 3, 2023
Hey, as @situchan mentioned is in't going taken care at some other PR? is this up for proposals?
hayata-suenaga commentedon Sep 3, 2023
@b4s36t4 I need to confirm with that PR author but probably will be fixed in that PR
I gonna keep this issue open but will removed help wanted label
b4s36t4 commentedon Sep 3, 2023
Ok understood.
[-][$500] Distance IOU - Distance editor menu in IOU report shows Merchant instead of Distance[/-][+][$500] [Distance] - Distance editor menu in IOU report shows Merchant instead of Distance[/+]zanyrenney commentedon Sep 5, 2023
Hey @hayata-suenaga I'm a little lost on this one with the labels.
I think Anu is assigned as the BZ manager:
But then it looks like you unassigned her and then the external label again which has also now assigned me...
Can you confirm what's happening here please? Thanks!
hayata-suenaga commentedon Sep 5, 2023
😓 this is probably the fault of my late-night brain... I constantly click wrong buttons 🔘
Anyway, this PR is going to fix the issue. I gonna close this issue for now