You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-12-06] [Distance] - Extra padding between the header and address field in waypoint editor #26560
What changes do you think we should make in order to solve the problem?
Update it with styles.mt3 for making it to 12px as suggested here. I am not sure whether it is intentional or not, otherwise we can take that margin out.
changed the title [-][Distance] - Extra padding between the header and address field in waypoint editor[/-][+][HOLD for payment 2023-12-06] [Distance] - Extra padding between the header and address field in waypoint editor[/+]on Nov 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
[@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jjcoffee] Determine if we should create a regression test for this bug.
[@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: N/A - this covers a lot of screens and probably the correct spacing was just missing from the start
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. It's a bit cumbersome to measure, but probably worth doing for design consistency
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Navigate to each of the below pages:
Waypoint Editor Page
Priority mode page
App download link
About page
ReimbursementAccountPage (all steps)
Verify the top margin/padding is 12px between header and the start of the page's content
Activity
melvin-bot commentedon Sep 2, 2023
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Pujan92 commentedon Sep 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Extra top margin for waypoint editor page
What is the root cause of that problem?
We have provided
styles.mt4to the address search container.App/src/pages/iou/WaypointEditor.js
Line 208 in 9701fbe
What changes do you think we should make in order to solve the problem?
Update it with
styles.mt3for making it to 12px as suggested here.I am not sure whether it is intentional or not, otherwise we can take that margin out.melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)67 remaining items
[-][Distance] - Extra padding between the header and address field in waypoint editor[/-][+][HOLD for payment 2023-12-06] [Distance] - Extra padding between the header and address field in waypoint editor[/+]melvin-bot commentedon Nov 29, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 29, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jjcoffee commentedon Dec 7, 2023
Regression Test Proposal
Do we agree 👍 or 👎
mallenexpensify commentedon Dec 8, 2023
Contributor: @Pujan92 paid $500 via Upwork
Contributor+: @jjcoffee paid $500 via Upwork
TestRail GH
Thanks!