Skip to content

[HOLD for payment 2023-09-25] [$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results #26573

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on settings > Profile > Timezone
  2. Turn off Automatically determine your location
  3. Input the number on search, Observed no results found but not showing "No results found"

Expected Result:

Show "No results found"

Actual Result:

Not displayed "No results found"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.62.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-28.at.22.22.43.mov
Recording.4196.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693236150330049

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018b22f58c3d2060c6
  • Upwork Job ID: 1698491149454860288
  • Last Price Increase: 2023-09-04
  • Automatic offers:
    • namhihi237 | Contributor | 26489739
    • namhihi237 | Reporter | 26489742

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 2, 2023
  2. melvin-bot commented on Sep 2, 2023

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 2, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. kbecciv commented on Sep 2, 2023

    @kbecciv
    Author

    Proposal by: @namhihi237
    Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693236150330049

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Show "No results found" when no search result

    What is the root cause of that problem?

    We are using SelectionList here to show the list timezone. But we don't have the logic to display "No results found" through the headerMessage prop when there are no search results.

    <SelectionList
    textInputLabel={translate('timezonePage.timezone')}
    textInputValue={timezoneInputText}
    onChangeText={filterShownTimezones}
    onSelectRow={saveSelectedTimezone}
    sections={[{data: timezoneOptions, indexOffset: 0, isDisabled: timezone.automatic}]}
    initiallyFocusedOptionKey={_.get(_.filter(timezoneOptions, (tz) => tz.text === timezone.selected)[0], 'keyForList')}
    shouldDelayFocus
    showScrollIndicator
    />

    What changes do you think we should make in order to solve the problem?

    We should add headerMessage prop for SelectionList

    headerMessage={timezoneInputText.trim() && !timezoneOptions.length ? translate('common.noResultsFound') : ''}
    

    What alternative solutions did you explore? (Optional)

    N/A

  5. jliexpensify commented on Sep 3, 2023

    @jliexpensify
    Contributor

    @kbecciv and @namhihi237 I don't think this is a bug: it's working as intended, as you've disabled the location and are typing a series of numbers. Sure, it would be nice to surface an error, but at the same time, users shouldn't expect anything to pop up if they're typing numbers in a field that uses letters. I don't see this as a true, valid bug.

  6. namhihi237 commented on Sep 4, 2023

    @namhihi237
    Contributor

    Hi @jliexpensify Don't just enter numbers, if you enter letters without results, it still won't display "no results found". I see in the app we currently have several search places. At the same, "no results found" is displayed everywhere if the user searches without seeing results.

  7. jliexpensify commented on Sep 4, 2023

    @jliexpensify
    Contributor

    Got it, thanks for letting me know - here is what we use for another field:
    image

    For consistency's sake, I'd then consider the lack of "No Results Found" to be an issue. I can also reproduce on Android (Pixel 3a) and Chrome.

  8. changed the title [-]Web - App doesn't show the result "not found" when there are no search results[/-] [+]Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/+] on Sep 4, 2023
  9. namhihi237 commented on Sep 4, 2023

    @namhihi237
    Contributor
  10. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 4, 2023
  11. changed the title [-]Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/-] [+][$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/+] on Sep 4, 2023
  12. 14 remaining items

  13. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  14. added
    ReviewingHas a PR in review
    and removed on Sep 4, 2023
  15. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

    • when @namhihi237 got assigned: 2023-09-04 13:51:25 Z
    • when the PR got merged: 2023-09-13 09:01:26 UTC
    • days elapsed: 6

    On to the next one 🚀

  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 18, 2023
  17. changed the title [-][$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/-] [+][HOLD for payment 2023-09-25] [$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/+] on Sep 18, 2023
  18. jliexpensify commented on Sep 25, 2023

    @jliexpensify
    Contributor

    Payment summary:

    Upwork job

  19. jliexpensify commented on Sep 25, 2023

    @jliexpensify
    Contributor

    Bump for @narefyev91 to complete the checklist please!

  20. narefyev91 commented on Sep 25, 2023

    @narefyev91
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR - it was missing functionality which was not coming from any regression work
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - N/A
    • Determine if we should create a regression test for this bug. - N/A
  21. jliexpensify commented on Sep 27, 2023

    @jliexpensify
    Contributor

    Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions