You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-25] [$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results #26573
Input the number on search, Observed no results found but not showing "No results found"
Expected Result:
Show "No results found"
Actual Result:
Not displayed "No results found"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.62.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Please re-state the problem that we are trying to solve in this issue.
Show "No results found" when no search result
What is the root cause of that problem?
We are using SelectionList here to show the list timezone. But we don't have the logic to display "No results found" through the headerMessage prop when there are no search results.
@kbecciv and @namhihi237 I don't think this is a bug: it's working as intended, as you've disabled the location and are typing a series of numbers. Sure, it would be nice to surface an error, but at the same time, users shouldn't expect anything to pop up if they're typing numbers in a field that uses letters. I don't see this as a true, valid bug.
Hi @jliexpensify Don't just enter numbers, if you enter letters without results, it still won't display "no results found". I see in the app we currently have several search places. At the same, "no results found" is displayed everywhere if the user searches without seeing results.
changed the title [-]Web - App doesn't show the result "not found" when there are no search results[/-][+]Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/+]on Sep 4, 2023
changed the title [-]Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/-][+][$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/+]on Sep 4, 2023
changed the title [-][$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/-][+][HOLD for payment 2023-09-25] [$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/+]on Sep 18, 2023
The PR that introduced the bug has been identified. Link to the PR - it was missing functionality which was not coming from any regression work
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - N/A
Determine if we should create a regression test for this bug. - N/A
Activity
melvin-bot commentedon Sep 2, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kbecciv commentedon Sep 2, 2023
Proposal by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693236150330049
Proposal
Please re-state the problem that we are trying to solve in this issue.
Show "No results found" when no search result
What is the root cause of that problem?
We are using
SelectionListhere to show the list timezone. But we don't have the logic to display "No results found" through theheaderMessageprop when there are no search results.App/src/pages/settings/Profile/TimezoneSelectPage.js
Lines 74 to 83 in 08c2f5d
What changes do you think we should make in order to solve the problem?
We should add
headerMessageprop forSelectionListWhat alternative solutions did you explore? (Optional)
N/A
jliexpensify commentedon Sep 3, 2023
@kbecciv and @namhihi237 I don't think this is a bug: it's working as intended, as you've disabled the location and are typing a series of numbers. Sure, it would be nice to surface an error, but at the same time, users shouldn't expect anything to pop up if they're typing numbers in a field that uses letters. I don't see this as a true, valid bug.
namhihi237 commentedon Sep 4, 2023
Hi @jliexpensify Don't just enter numbers, if you enter letters without results, it still won't display "no results found". I see in the app we currently have several search places. At the same, "no results found" is displayed everywhere if the user searches without seeing results.
jliexpensify commentedon Sep 4, 2023
Got it, thanks for letting me know - here is what we use for another field:

For consistency's sake, I'd then consider the lack of "No Results Found" to be an issue. I can also reproduce on Android (Pixel 3a) and Chrome.
[-]Web - App doesn't show the result "not found" when there are no search results[/-][+]Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/+]namhihi237 commentedon Sep 4, 2023
thanks @jliexpensify.
[-]Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/-][+][$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/+]14 remaining items
melvin-bot commentedon Sep 4, 2023
📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Sep 13, 2023
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀
[-][$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/-][+][HOLD for payment 2023-09-25] [$500] Web - When manually entering a timezone, "No results found" is not shown when there are no search results[/+]jliexpensify commentedon Sep 25, 2023
Payment summary:
Upwork job
jliexpensify commentedon Sep 25, 2023
Bump for @narefyev91 to complete the checklist please!
narefyev91 commentedon Sep 25, 2023
jliexpensify commentedon Sep 27, 2023
Paid and job closed!