Skip to content

[$1000] LHN - Instead of user name, "chat report " is displayed #26592

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch app
  2. Tap profile icon
  3. Tap workspaces
  4. Tap any Workspace
  5. Tap Members
  6. Tap invite
  7. Enter any new non-existing account
  8. Tap Next
  9. Tap Invite
  10. Navigate to LHN

Expected Result:

The invited workspace user name should display in the first line of report in the LHN

Actual Result:

"Chat report" is displayed in the first line of report in the LHN instead of the invited workspace user name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.62-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6186538_chat_report_in_lhn.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a5e746cb88e86963
  • Upwork Job ID: 1698644415415676928
  • Last Price Increase: 2023-09-28

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 2, 2023
  2. melvin-bot commented on Sep 2, 2023

    @melvin-bot

    Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 2, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. conorpendergrast commented on Sep 4, 2023

    @conorpendergrast
    Contributor

    Oh yeah, weird:

    image

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 4, 2023
  6. changed the title [-] LHN - Instead of user name, "chat report " is displayed[/-] [+][$500] LHN - Instead of user name, "chat report " is displayed[/+] on Sep 4, 2023
  7. melvin-bot commented on Sep 4, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 4, 2023
  9. melvin-bot commented on Sep 4, 2023

    @melvin-bot
  10. melvin-bot commented on Sep 4, 2023

    @melvin-bot
  11. im-adithya commented on Sep 4, 2023

    @im-adithya

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Chat Report" is displayed instead of username

    What is the root cause of that problem?

    Because we send in undefined (second param, reportName) to buildOptimisticChatReport while creating the chat, see

    const optimisticReport = ReportUtils.buildOptimisticChatReport([sessionAccountID, cleanAccountID], undefined, CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, policyID, cleanAccountID);

    What changes do you think we should make in order to solve the problem?

    We can send the email as the reportName instead of undefined

    What alternative solutions did you explore? (Optional)

    < Thinking >

  12. Santhosh-Sellavel commented on Sep 5, 2023

    @Santhosh-Sellavel
    Collaborator

    @conorpendergrast Unassigning this one due to low bandwidth, can you assign a new C+ by applying external label again, thanks!

  13. 75 remaining items

  14. added and removed on Oct 2, 2023
  15. paultsimura commented on Oct 2, 2023

    @paultsimura
    Contributor

    Thank you @Julesssss, I will report a bug and will tag you in the thread.

  16. Julesssss commented on Oct 2, 2023

    @Julesssss
    Contributor

    I'll keep this issue open until that issue is created, just so we don't forgot

  17. mvtglobally commented on Oct 5, 2023

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  18. mallenexpensify commented on Oct 11, 2023

    @mallenexpensify
    Contributor

    Closing cuz I think we were waiting for the below to be created, and it is!

  19. ospfranco commented on Oct 11, 2023

    @ospfranco
    Contributor

    My changes on #28737 were reverted. The change caused issues in other places of the app. You should probably re-open this again.

  20. mallenexpensify commented on Oct 12, 2023

    @mallenexpensify
    Contributor

    Thanks @ospfranco

  21. mvtglobally commented on Oct 12, 2023

    @mvtglobally

    Issue not reproducible during KI retests. (Third week)

  22. mallenexpensify commented on Oct 16, 2023

    @mallenexpensify
    Contributor

    Closing cuz it's not reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions