You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
FAB - Save the world - After leaving the room " Expensify dot org/ Teacher's unite", option " I am a teacher should reappear #26691
now it should redirect to room "Expensify.org/ Teacher's unite"
go to details of the room and leave the room.
Go to Fab button again -> save the world . Notice this time " I am a teacher " option is not shown.
Expected Result:
user might leave the room ( Expensify.org/ Teacher's unite) accidentally. Thus, " I am a teacher" option should be shown in save the world page. So that one can join the room again.
Actual Result:
After leaving room Expensify.org/ Teacher's unite , " I am a teacher option " disappears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.62-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@ashimsharma10 Sorry, I can't reproduce this issue anymore in build v1.3.63-0. Production the same.
Recording.1441.mp4
Recording.1440.mp4
@izarutskaya This time step 1 is done incorrectly. reproducible step is: First fill in' I am a teacher' and then leave the room. In your videos, you did ' I know a teacher'.
asking in #open-source, if its a intended behaviour.
Apologies for the trouble. I think I didn't write the Action steps properly before.
Let me explain again.
( Rather than Bug, I guess it might be feature request)
I'm saying is that once you leave the 'teacher-unite policy' room, there is no feature to again join the community as 'I am a teacher'. I mean if someone leaves room accidentally, then he can't do ' I am teacher ' again.
fab button -> save the world -> 'I KNOW A TEACHER' -> fill the form -> lets do this
Now , fab button -> save the world -> 'I Am A TEACHER' -> fill the form -> lets do this
go to # teacher-unite -> settings-> leave room.
Now go to fab button -> save the world
Notice that after leaving the room, option ' I am a teacher' doesn't reappear.
I think someone from internal better see this. And its not a deploy blocker. @izarutskaya Thank you for looking again.
Reproducible step is: First fill in' I am a teacher' and then leave the room
Steps from "I am a teacher" will allow you to join the policy, once you join, we remove the "I am a teacher" button to prevent trying to join the policy multiple times. Leaving the public room has no effect on the "I am a teacher" button.
Activity
melvin-bot commentedon Sep 4, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 4, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)izarutskaya commentedon Sep 4, 2023
Issue is not reproducible in Production
Recording.1433.mp4
OSBotify commentedon Sep 4, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 4, 2023
Triggered auto assignment to @puneetlath (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.ashimsharma10 commentedon Sep 4, 2023
@izarutskaya you have not done step 4 from above. In this production video.
izarutskaya commentedon Sep 4, 2023
@ashimsharma10 Sorry, I can't reproduce this issue anymore in build v1.3.63-0. Production the same.
Recording.1441.mp4
Recording.1440.mp4
youssef-lr commentedon Sep 5, 2023
I can't reproduce this issue either. But we do hide the "I am a teacher" button once the teacher has joined the policy. Closing!
ashimsharma10 commentedon Sep 5, 2023
@izarutskaya This time step 1 is done incorrectly. reproducible step is: First fill in' I am a teacher' and then leave the room. In your videos, you did ' I know a teacher'.
asking in #open-source, if its a intended behaviour.
izarutskaya commentedon Sep 5, 2023
@ashimsharma10 I can't leave the room
Recording.1443.mp4
ashimsharma10 commentedon Sep 5, 2023
leaving room option is at, #teacher-unite room.
Apologies for the trouble. I think I didn't write the Action steps properly before.
Let me explain again.
( Rather than Bug, I guess it might be feature request)
I'm saying is that once you leave the 'teacher-unite policy' room, there is no feature to again join the community as 'I am a teacher'. I mean if someone leaves room accidentally, then he can't do ' I am teacher ' again.
I think someone from internal better see this. And its not a deploy blocker.

@izarutskaya Thank you for looking again.
youssef-lr commentedon Sep 5, 2023
Steps from "I am a teacher" will allow you to join the policy, once you join, we remove the "I am a teacher" button to prevent trying to join the policy multiple times. Leaving the public room has no effect on the "I am a teacher" button.