Skip to content

FAB - Save the world - After leaving the room " Expensify dot org/ Teacher's unite", option " I am a teacher should reappear #26691

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Fab -> save the world -> I am a teacher
  2. Enter Name and email
  3. now it should redirect to room "Expensify.org/ Teacher's unite"
  4. go to details of the room and leave the room.
  5. Go to Fab button again -> save the world . Notice this time " I am a teacher " option is not shown.

Expected Result:

user might leave the room ( Expensify.org/ Teacher's unite) accidentally. Thus, " I am a teacher" option should be shown in save the world page. So that one can join the room again.

Actual Result:

After leaving room Expensify.org/ Teacher's unite , " I am a teacher option " disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.62-4

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-30.At.7.31.05.Pm.1.mp4
Recording.1432.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ashimsharma10

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p16934030597274790

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 4, 2023
  2. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. izarutskaya commented on Sep 4, 2023

    @izarutskaya
    Author

    Issue is not reproducible in Production

    Recording.1433.mp4
  5. OSBotify commented on Sep 4, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. ashimsharma10 commented on Sep 4, 2023

    @ashimsharma10

    Issue is not reproducible in Production

    Recording.1433.mp4

    @izarutskaya you have not done step 4 from above. In this production video.

  8. izarutskaya commented on Sep 4, 2023

    @izarutskaya
    Author

    @ashimsharma10 Sorry, I can't reproduce this issue anymore in build v1.3.63-0. Production the same.

    Recording.1441.mp4
    Recording.1440.mp4
  9. youssef-lr commented on Sep 5, 2023

    @youssef-lr
    Contributor

    I can't reproduce this issue either. But we do hide the "I am a teacher" button once the teacher has joined the policy. Closing!

  10. ashimsharma10 commented on Sep 5, 2023

    @ashimsharma10

    @ashimsharma10 Sorry, I can't reproduce this issue anymore in build v1.3.63-0. Production the same.

    Recording.1441.mp4

    Recording.1440.mp4

    @izarutskaya This time step 1 is done incorrectly. reproducible step is: First fill in' I am a teacher' and then leave the room. In your videos, you did ' I know a teacher'.

    asking in #open-source, if its a intended behaviour.

  11. izarutskaya commented on Sep 5, 2023

    @izarutskaya
    Author

    @ashimsharma10 I can't leave the room

    Recording.1443.mp4
  12. ashimsharma10 commented on Sep 5, 2023

    @ashimsharma10

    leaving room option is at, #teacher-unite room.

    Apologies for the trouble. I think I didn't write the Action steps properly before.
    Let me explain again.

    ( Rather than Bug, I guess it might be feature request)

    I'm saying is that once you leave the 'teacher-unite policy' room, there is no feature to again join the community as 'I am a teacher'. I mean if someone leaves room accidentally, then he can't do ' I am teacher ' again.

    1. fab button -> save the world -> 'I KNOW A TEACHER' -> fill the form -> lets do this
    2. Now , fab button -> save the world -> 'I Am A TEACHER' -> fill the form -> lets do this
    3. go to # teacher-unite -> settings-> leave room.
    4. Now go to fab button -> save the world
    5. Notice that after leaving the room, option ' I am a teacher' doesn't reappear.

    I think someone from internal better see this. And its not a deploy blocker.
    @izarutskaya Thank you for looking again.
    Screenshot 2023-09-05 at 3 08 00 PM

  13. youssef-lr commented on Sep 5, 2023

    @youssef-lr
    Contributor

    Reproducible step is: First fill in' I am a teacher' and then leave the room

    Steps from "I am a teacher" will allow you to join the policy, once you join, we remove the "I am a teacher" button to prevent trying to join the policy multiple times. Leaving the public room has no effect on the "I am a teacher" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions