You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-12] [$500] Chat - Space is not added after an emoji is selected #26709
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
[@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jjcoffee] Determine if we should create a regression test for this bug.
[@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Just noting this one was C+ approved within 3 WD, and merged without any changes requested later (due to engineer delay), so I think this one is still due the urgency bonus.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A this one would be too hard to catch I think!
Determine if we should create a regression test for this bug. Yes - easy enough to test
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. See below
Activity
OSBotify commentedon Sep 4, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 4, 2023
Triggered auto assignment to @joelbettner (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.napster125 commentedon Sep 4, 2023
I can't reproduce it.
joelbettner commentedon Sep 5, 2023
I also cannot reproduce. I've tried to reproduce on desktop, mobile and web, too.
kavimuru commentedon Sep 5, 2023
@joelbettner Reproducible only in Android app.
melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.72 remaining items
melvin-bot commentedon Oct 5, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 5, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jjcoffee commentedon Oct 5, 2023
Just noting this one was C+ approved within 3 WD, and merged without any changes requested later (due to engineer delay), so I think this one is still due the urgency bonus.
jjcoffee commentedon Oct 5, 2023
jjcoffee commentedon Oct 5, 2023
Regression Test Proposal
Do we agree 👍 or 👎
joelbettner commentedon Oct 11, 2023
@johncschuster has the payment been finished for this?
What do we need to do to get this issue closed?
Krishna2323 commentedon Oct 15, 2023
@johncschuster, bump for payments.
johncschuster commentedon Oct 18, 2023
Ah, sorry this was held on me! I'll get payment issued!
johncschuster commentedon Oct 18, 2023
Payment has been issued!