Skip to content

[HOLD for payment 2023-10-12] [$500] Chat - Space is not added after an emoji is selected #26709

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #24614

Action Performed:

  1. Launch New Expensify app
  2. Go to any chat
  3. Open emoji picker
  4. Select an emoji
  5. Add another emoji

Expected Result:

Space is added after an emoji is selected

Actual Result:

Space is not added after an emoji is selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.63-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188282_Screen_Recording_20230905_013226_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d9f65ce9e5e54e44
  • Upwork Job ID: 1699517068377264128
  • Last Price Increase: 2023-09-20
  • Automatic offers:
    • jjcoffee | Reviewer | 26895645
    • Krishna2323 | Contributor | 26895646

Activity

  1. OSBotify commented on Sep 4, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. napster125 commented on Sep 4, 2023

    @napster125
    Contributor

    I can't reproduce it.

  4. joelbettner commented on Sep 5, 2023

    @joelbettner
    Contributor

    I also cannot reproduce. I've tried to reproduce on desktop, mobile and web, too.

  5. kavimuru commented on Sep 5, 2023

    @kavimuru

    @joelbettner Reproducible only in Android app.

  6. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Sep 5, 2023
  7. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  8. 72 remaining items

  9. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. melvin-bot commented on Oct 5, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
    • [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jjcoffee] Determine if we should create a regression test for this bug.
    • [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. jjcoffee commented on Oct 5, 2023

    @jjcoffee
    Contributor

    Just noting this one was C+ approved within 3 WD, and merged without any changes requested later (due to engineer delay), so I think this one is still due the urgency bonus.

  13. jjcoffee commented on Oct 5, 2023

    @jjcoffee
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: fix: 24261 user able to select 2 emoji at a time #24614
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: 24261 user able to select 2 emoji at a time #24614 (comment)
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A this one would be too hard to catch I think!
    • Determine if we should create a regression test for this bug. Yes - easy enough to test
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. See below
  14. jjcoffee commented on Oct 5, 2023

    @jjcoffee
    Contributor

    Regression Test Proposal

    1. Go to any chat
    2. Open the emoji picker
    3. Select any emoji
    4. Verify that the emoji is inserted with a single space following it

    Do we agree 👍 or 👎

  15. joelbettner commented on Oct 11, 2023

    @joelbettner
    Contributor

    @johncschuster has the payment been finished for this?

    What do we need to do to get this issue closed?

  16. Krishna2323 commented on Oct 15, 2023

    @Krishna2323
    Contributor

    @johncschuster, bump for payments.

  17. johncschuster commented on Oct 18, 2023

    @johncschuster
    Contributor

    Ah, sorry this was held on me! I'll get payment issued!

  18. johncschuster commented on Oct 18, 2023

    @johncschuster
    Contributor

    Payment has been issued!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions