Skip to content

[HOLD for payment 2023-09-15] Request money - Merchant name is not indicated as unknown merchant #26759

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #26643

Action Performed:

  1. Create a new receipt money request from newDot by going to + -> Request Money -> receipt and sending a random image. Make sure to choose a worskpace ( Used a receipt masking the merchant details)

Expected Result:

Merchant name indicated as unknown and error displayed

Actual Result:

Merchant name displayed as none and no error message displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.63-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188638_26643_Desktop.mp4

Bug6188638_receipt__2_

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 5, 2023
  2. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. sophiepintoraetz commented on Sep 6, 2023

    @sophiepintoraetz
    Contributor

    @Gonals (cc @mountiny and @MariaHCD) - this is came from one of your PRs - shall I assign it to you to fix?

  5. Gonals commented on Sep 6, 2023

    @Gonals
    Contributor

    I don't think this is a bug, at least, not with the described steps. The merchant is only marked as unknown after Smartscan, if the smartscanner indicates so manually, but maybe we should show an error for the merchant in this case too. Looking into it

  6. mountiny commented on Sep 6, 2023

    @mountiny
    Contributor

    This is no t a bug, you cannot set empty Merchant @lanitochka17 can you update the test steps? For now, merchant field can never be empty

  7. reopened this on Sep 6, 2023
  8. Gonals commented on Sep 6, 2023

    @Gonals
    Contributor

    There is a bug, though, @mountiny! If the merchant is (none) (the partial transaction one) and smartscan has stopped, we should have the user populate it with a real one

  9. MariaHCD commented on Sep 6, 2023

    @MariaHCD
    Contributor

    If the merchant is (none) (the partial transaction one) and smartscan has stopped

    Wouldn't we show the RBR in that case?

    function areRequiredFieldsEmpty(transaction) {
    return (
    transaction.modifiedMerchant === CONST.TRANSACTION.UNKNOWN_MERCHANT ||
    (transaction.modifiedMerchant === '' &&
    (transaction.merchant === CONST.TRANSACTION.UNKNOWN_MERCHANT || transaction.merchant === '' || transaction.merchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT)) ||
    (transaction.modifiedAmount === 0 && transaction.amount === 0) ||
    (transaction.modifiedCreated === '' && transaction.created === '')
    );
    }

  10. added
    ReviewingHas a PR in review
    and removed on Sep 6, 2023
  11. 3 remaining items

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 8, 2023
  13. changed the title [-]Request money - Merchant name is not indicated as unknown merchant[/-] [+][HOLD for payment 2023-09-15] Request money - Merchant name is not indicated as unknown merchant[/+] on Sep 8, 2023
  14. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.65-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-09-15. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Sep 8, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Gonals] The PR that introduced the bug has been identified. Link to the PR:
      This wasn't really a bug, but I did find a related bug while testing, which was introduced with the core functionality, so not really a regression. Checking these off
    • [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Gonals] Determine if we should create a regression test for this bug.
    • [@Gonals] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. sophiepintoraetz commented on Sep 15, 2023

    @sophiepintoraetz
    Contributor

    No payments needed here as it was reported by Applause and fixed internally - @Gonals - do we need a regression test for this?

  18. Gonals commented on Sep 15, 2023

    @Gonals
    Contributor

    Nah, this wasn't really a bug, but I did find a related bug while testing 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions