You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-15] Request money - Merchant name is not indicated as unknown merchant #26759
Create a new receipt money request from newDot by going to + -> Request Money -> receipt and sending a random image. Make sure to choose a worskpace ( Used a receipt masking the merchant details)
Expected Result:
Merchant name indicated as unknown and error displayed
Actual Result:
Merchant name displayed as none and no error message displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
I don't think this is a bug, at least, not with the described steps. The merchant is only marked as unknown after Smartscan, if the smartscanner indicates so manually, but maybe we should show an error for the merchant in this case too. Looking into it
There is a bug, though, @mountiny! If the merchant is (none) (the partial transaction one) and smartscan has stopped, we should have the user populate it with a real one
changed the title [-]Request money - Merchant name is not indicated as unknown merchant[/-][+][HOLD for payment 2023-09-15] Request money - Merchant name is not indicated as unknown merchant[/+]on Sep 8, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.65-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-15. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Gonals] The PR that introduced the bug has been identified. Link to the PR: This wasn't really a bug, but I did find a related bug while testing, which was introduced with the core functionality, so not really a regression. Checking these off
[@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Gonals] Determine if we should create a regression test for this bug.
[@Gonals] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)sophiepintoraetz commentedon Sep 6, 2023
@Gonals (cc @mountiny and @MariaHCD) - this is came from one of your PRs - shall I assign it to you to fix?
Gonals commentedon Sep 6, 2023
I don't think this is a bug, at least, not with the described steps. The merchant is only marked as unknown after Smartscan, if the smartscanner indicates so manually, but maybe we should show an error for the merchant in this case too. Looking into it
mountiny commentedon Sep 6, 2023
This is no t a bug, you cannot set empty Merchant @lanitochka17 can you update the test steps? For now, merchant field can never be empty
Gonals commentedon Sep 6, 2023
There is a bug, though, @mountiny! If the merchant is
(none)(the partial transaction one) and smartscan has stopped, we should have the user populate it with a real oneMariaHCD commentedon Sep 6, 2023
Wouldn't we show the RBR in that case?
App/src/libs/TransactionUtils.js
Lines 92 to 100 in 1bdc5ac
3 remaining items
[-]Request money - Merchant name is not indicated as unknown merchant[/-][+][HOLD for payment 2023-09-15] Request money - Merchant name is not indicated as unknown merchant[/+]melvin-bot commentedon Sep 8, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 8, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.65-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-09-15. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 8, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
This wasn't really a bug, but I did find a related bug while testing, which was introduced with the core functionality, so not really a regression. Checking these off
sophiepintoraetz commentedon Sep 15, 2023
No payments needed here as it was reported by Applause and fixed internally - @Gonals - do we need a regression test for this?
Gonals commentedon Sep 15, 2023
Nah, this wasn't really a bug, but I did find a related bug while testing 😆