You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-10] [$500] Settings - Profile - User is able to delete default contact method, result in error #26773
Please re-state the problem that we are trying to solve in this issue.
User is able to delete default contact method, result in error
What is the root cause of that problem?
In current ContactMethodDetailsPage, we don't a have logic to hide the delete modal or prevent user from deleting the current contact method even it's default contact methods once modal is opened.
What changes do you think we should make in order to solve the problem?
Solution 1:
Add an useEffect inside ContactMethodDetailsPage, if current contact method is default contact method and Confirm Modal is opened, we should hide the modal.
Solution 2:
Disabled the Yes, continue button if current contact method is default contact method.
What alternative solutions did you explore? (Optional)
I think this issue is related to both backend and frontend
The backend should return error when a user tries to delete his default contact method. This is possible for sure
The frontend should show error message like "You can't delete your default contact method" when press Yes button
changed the title [-]Settings - Profile - User is able to delete default contact method, result in error[/-][+][$500] Settings - Profile - User is able to delete default contact method, result in error[/+]on Sep 5, 2023
changed the title [-][$500] Settings - Profile - User is able to delete default contact method, result in error[/-][+][HOLD for payment 2023-10-10] [$500] Settings - Profile - User is able to delete default contact method, result in error[/+]on Oct 3, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-10. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Ollyws] The PR that introduced the bug has been identified. Link to the PR: N/A
[@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws] Determine if we should create a regression test for this bug.
[@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist:
I don't think we can say any PR caused this issue, it's just not something we considered to check for when implementing.
This is pretty edge case and not really related to any important user flow, it's also not that easy to test for so I don't think a regression test is useful here.
Activity
melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 5, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)izarutskaya commentedon Sep 5, 2023
Proposal from @hungvu193
Please re-state the problem that we are trying to solve in this issue.
User is able to delete default contact method, result in error
What is the root cause of that problem?
In current
ContactMethodDetailsPage, we don't a have logic to hide the delete modal or prevent user from deleting the current contact method even it's default contact methods once modal is opened.What changes do you think we should make in order to solve the problem?
Solution 1:
Add an
useEffectinsideContactMethodDetailsPage, if current contact method is default contact method and Confirm Modal is opened, we should hide the modal.Solution 2:
Disabled the
Yes, continuebutton if current contact method is default contact method.What alternative solutions did you explore? (Optional)
N/A
dummy-1111 commentedon Sep 5, 2023
I think this issue is related to both backend and frontend
The backend should return error when a user tries to delete his default contact method. This is possible for sure
The frontend should show error message like "You can't delete your default contact method" when press
Yesbutton[-]Settings - Profile - User is able to delete default contact method, result in error[/-][+][$500] Settings - Profile - User is able to delete default contact method, result in error[/+]melvin-bot commentedon Sep 5, 2023
Job added to Upwork: https://www.upwork.com/jobs/~011a89cd5b6cb92262
melvin-bot commentedon Sep 5, 2023
Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)hungvu193 commentedon Sep 6, 2023
@izarutskaya Can you update the reporter and proposal, it was actually me. Sorry for this inconvenient.
25 remaining items
[-][$500] Settings - Profile - User is able to delete default contact method, result in error[/-][+][HOLD for payment 2023-10-10] [$500] Settings - Profile - User is able to delete default contact method, result in error[/+]melvin-bot commentedon Oct 3, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 3, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-10. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 3, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abekkala commentedon Oct 4, 2023
PAYMENTS FOR OCT 10
Ollyws commentedon Oct 10, 2023
BugZero Checklist:
I don't think we can say any PR caused this issue, it's just not something we considered to check for when implementing.
This is pretty edge case and not really related to any important user flow, it's also not that easy to test for so I don't think a regression test is useful here.
abekkala commentedon Oct 10, 2023
@hungvu193 payment made [$50] and contract ended - thank you! 🎉
abekkala commentedon Oct 10, 2023
@Ollyws payment made [$500] and contract ended - thank you! 🎉
abekkala commentedon Oct 10, 2023
closing