You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-24] [$500] Implement new layout in About page #26779
Except it should also include the app version in the same font color as the < back button beneath the coin on the About page.
Notes:
It should be implemented with the IllustratedHeaderPageLayout
because the app version needs to be included in the top section, the IllustratedHeaderPageLayout component may need to be updated to allow us to render some stuff beneath the animation
Currently the aspect ratio for all these animations are the same, so by setting the animation to 100% width the top section of the screen always has the same height. We need to render the app version in the top section without adjusting the animation size or the height of the top (colored) section.
changed the title [-][$500] Implement new layout in About page[/-][+][HOLD for payment 2024-01-24] [$500] Implement new layout in About page[/+]on Jan 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
I don't think we need a regression test here for the simplicity. This kinda of design change is not something that would just break. This is an improvement more than a new feature.
Activity
[-]Implement new layout in About page[/-][+][$500] Implement new layout in About page[/+]melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @Christinadobrzyn (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.melvin-bot commentedon Sep 5, 2023
Triggered auto assignment to @isabelastisser (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.41 remaining items
roryabraham commentedon Jan 14, 2024
PR merged! 🚀 Thanks @shawnborton for working with our design partners to get an animation that worked as expected and was correctly sized
[-][$500] Implement new layout in About page[/-][+][HOLD for payment 2024-01-24] [$500] Implement new layout in About page[/+]melvin-bot commentedon Jan 17, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 17, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Jan 18, 2024
I don't think we need a regression test here for the simplicity. This kinda of design change is not something that would just break. This is an improvement more than a new feature.
isabelastisser commentedon Jan 29, 2024
The payments were made in Upwork:
@Pujan92 requires payment automatic offer (Contributor) $500
@s77rt requires payment automatic offer (Reviewer) $500
isabelastisser commentedon Jan 29, 2024
all set!