Skip to content

[HOLD for payment 2024-01-24] [$500] Implement new layout in About page #26779

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


HOLD on #26784

Action Performed:

Open the Settings -> About page.

Expected Result:

image

Except it should also include the app version in the same font color as the < back button beneath the coin on the About page.

Notes:

  • It should be implemented with the IllustratedHeaderPageLayout

  • because the app version needs to be included in the top section, the IllustratedHeaderPageLayout component may need to be updated to allow us to render some stuff beneath the animation

  • Currently the aspect ratio for all these animations are the same, so by setting the animation to 100% width the top section of the screen always has the same height. We need to render the app version in the top section without adjusting the animation size or the height of the top (colored) section.

  • The animation lottie asset is here:

    Loading.json.zip

  • The correct background color is yellow600 or #D18000

Actual Result:

It does not look like that.

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0179e9954261696fde
  • Upwork Job ID: 1699055159124353024
  • Last Price Increase: 2023-09-05
  • Automatic offers:
    • s77rt | Reviewer | 26508154
    • Pujan92 | Contributor | 26508156

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    NewFeatureSomething to build that is a new item.
    on Sep 5, 2023
  2. self-assigned this
    on Sep 5, 2023
  3. changed the title [-]Implement new layout in About page[/-] [+][$500] Implement new layout in About page[/+] on Sep 5, 2023
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 5, 2023
  5. melvin-bot commented on Sep 5, 2023

    @melvin-bot
  6. melvin-bot commented on Sep 5, 2023

    @melvin-bot

    Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  7. 41 remaining items

  8. roryabraham commented on Jan 14, 2024

    @roryabraham
    ContributorAuthor

    PR merged! 🚀 Thanks @shawnborton for working with our design partners to get an animation that worked as expected and was correctly sized

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 17, 2024
  10. changed the title [-][$500] Implement new layout in About page[/-] [+][HOLD for payment 2024-01-24] [$500] Implement new layout in About page[/+] on Jan 17, 2024
  11. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-01-24. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  14. s77rt commented on Jan 18, 2024

    @s77rt
    Member

    I don't think we need a regression test here for the simplicity. This kinda of design change is not something that would just break. This is an improvement more than a new feature.

  15. isabelastisser commented on Jan 29, 2024

    @isabelastisser
    Contributor

    The payments were made in Upwork:

    @Pujan92 requires payment automatic offer (Contributor) $500
    @s77rt requires payment automatic offer (Reviewer) $500

  16. isabelastisser commented on Jan 29, 2024

    @isabelastisser
    Contributor

    all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions