Skip to content

[HOLD for payment 2023-09-18] [$1000] Deeplinks except chat reports are not working on web #26852

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  1. Log out
  2. Go to any app URL (/enable-payments) or /concierge or some other deeplink activated route
  3. Log in

Expected Result:

Describe what you think should've happened

You are signed in and logged into that route

Actual Result:

Describe what actually happened

You are in normal chat report/ not deeplinked to the page you wanted

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.60-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

deeplink-compressed.mov

Expensify/Expensify Issue URL:
Issue reported by: @tienifr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693478978353389

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fe24c8c7021a0486
  • Upwork Job ID: 1699316717752012800
  • Last Price Increase: 2023-09-06
  • Automatic offers:
    • hungvu193 | Contributor | 26522318
    • tienifr | Reporter | 26522320

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 6, 2023
  2. melvin-bot commented on Sep 6, 2023

    @melvin-bot
  3. changed the title [-]Deeplinks except chat reports are not working on web[/-] [+][$500] Deeplinks except chat reports are not working on web[/+] on Sep 6, 2023
  4. melvin-bot commented on Sep 6, 2023

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 6, 2023
  6. melvin-bot commented on Sep 6, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Sep 6, 2023

    @melvin-bot

    Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  8. melvin-bot commented on Sep 6, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  9. changed the title [-][$500] Deeplinks except chat reports are not working on web[/-] [+][$1000] Deeplinks except chat reports are not working on web[/+] on Sep 6, 2023
  10. melvin-bot commented on Sep 6, 2023

    @melvin-bot

    Upwork job price has been updated to $1000

  11. 59 remaining items

  12. abekkala commented on Sep 19, 2023

    @abekkala
    Contributor

    Thanks!

    • Issue reported by: @tienifr [$50] - Upwork
    • Selected Proposal for fix: @hungvu193 [$1000] + [$500 PR bonus] - Upwork
    • C+ Review: @parasharrajat [$1000] + [$500 PR bonus] - Manual Request for payment in EChat
  13. parasharrajat commented on Sep 19, 2023

    @parasharrajat
    Member

    I am exactly not sure which PR was responsible for this issue. The adopted solution was a workaround and the deep link problem is not completely solved. There is another action issue for it. So I think we can skip the root PR for this.

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Skipped
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Skipped
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1695134566954149
    • [@parasharrajat] Determine if we should create a regression test for this bug. Yes
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Steps

    Test RHP deeplink

    1. Log out
    2. Go to any app URL (/enable-payments) or /concierge or some other deeplink activated route
    3. Log in
    4. Verify that App navigates to that url after logging in.

    Test Concierge deeplink

    1. Log out
    2. Go to /concierge route
    3. Sign in
    4. Verify you are deeplinked to a concierge chat and clicking Up in top left corner navigates you to the LHN

    Test specific chat report deeplink

    1. Log out
    2. Go to /r/ route (some valid for the account)
    3. Sign in
    4. Verify you are deeplinked to that report chat and clicking Up in top left corner navigates you to the LHN (in narrow view)

    Test annonymous user claiming their account from public room

    1. Log out
    2. Go to /r/{public_room_id} route where this is a public_announce room that you can access as an anonymous user.
    3. Click Sign in either from footer or LHN to sign in page to claim the account
    4. Sign in
    5. Verify you are correctly signed in and you can see the public chat room in the LHN

    Do you agree 👍 or 👎 ?

  14. abekkala commented on Sep 19, 2023

    @abekkala
    Contributor

    @tienifr and @hungvu193 payments have been made and contracts ended. Thank you! 🎉

    @parasharrajat have you already requested manually payment in EChat yet?

  15. parasharrajat commented on Sep 19, 2023

    @parasharrajat
    Member

    No, I will do that later. Feel free to close if you want.

  16. mountiny commented on Sep 21, 2023

    @mountiny
    ContributorAuthor

    Thanks everyone!

  17. lcsvcn commented on Sep 25, 2023

    @lcsvcn

    This issue is still a blocker for this bug fix to be open?

    @dhanashree-sawant reported it first here, I noticed today that it is still reproducible on latest version and I have a proposal to fix this issue.

    Thanks!

  18. mountiny commented on Sep 25, 2023

    @mountiny
    ContributorAuthor

    @lcsvcn I dont think that is related to this issue, the bug report should be created separately for a new GH ticket

  19. lcsvcn commented on Sep 25, 2023

    @lcsvcn

    It is related because it was marked as blocker to create the issue, if you check this slack thread

  20. hungvu193 commented on Sep 25, 2023

    @hungvu193
    Contributor

    I checked the thread, it's not related to this one, Kavi posted the wrong link.

  21. lcsvcn commented on Sep 25, 2023

    @lcsvcn

    Oh, I see. what is the correct link, please? Do you know?

  22. parasharrajat commented on Oct 13, 2023

    @parasharrajat
    Member

    Payment requested as per #26852 (comment)

  23. JmillsExpensify commented on Oct 13, 2023

    @JmillsExpensify
    Contributor

    $1,500 payment approved for @parasharrajat based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions