You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-09-18] [$1000] Deeplinks except chat reports are not working on web #26852
Go to any app URL (/enable-payments) or /concierge or some other deeplink activated route
Log in
Expected Result:
Describe what you think should've happened
You are signed in and logged into that route
Actual Result:
Describe what actually happened
You are in normal chat report/ not deeplinked to the page you wanted
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.60-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Deeplinks except chat reports are not working on web[/-][+][$500] Deeplinks except chat reports are not working on web[/+]on Sep 6, 2023
changed the title [-][$500] Deeplinks except chat reports are not working on web[/-][+][$1000] Deeplinks except chat reports are not working on web[/+]on Sep 6, 2023
I am exactly not sure which PR was responsible for this issue. The adopted solution was a workaround and the deep link problem is not completely solved. There is another action issue for it. So I think we can skip the root PR for this.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Skipped
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Skipped
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Test RHP deeplink
Log out
Go to any app URL (/enable-payments) or /concierge or some other deeplink activated route
Log in
Verify that App navigates to that url after logging in.
Test Concierge deeplink
Log out
Go to /concierge route
Sign in
Verify you are deeplinked to a concierge chat and clicking Up in top left corner navigates you to the LHN
Test specific chat report deeplink
Log out
Go to /r/ route (some valid for the account)
Sign in
Verify you are deeplinked to that report chat and clicking Up in top left corner navigates you to the LHN (in narrow view)
Test annonymous user claiming their account from public room
Log out
Go to /r/{public_room_id} route where this is a public_announce room that you can access as an anonymous user.
Click Sign in either from footer or LHN to sign in page to claim the account
Sign in
Verify you are correctly signed in and you can see the public chat room in the LHN
Activity
melvin-bot commentedon Sep 6, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01fe24c8c7021a0486
[-]Deeplinks except chat reports are not working on web[/-][+][$500] Deeplinks except chat reports are not working on web[/+]melvin-bot commentedon Sep 6, 2023
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 6, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 6, 2023
Triggered auto assignment to @alexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 6, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)[-][$500] Deeplinks except chat reports are not working on web[/-][+][$1000] Deeplinks except chat reports are not working on web[/+]melvin-bot commentedon Sep 6, 2023
Upwork job price has been updated to $1000
59 remaining items
abekkala commentedon Sep 19, 2023
Thanks!
parasharrajat commentedon Sep 19, 2023
I am exactly not sure which PR was responsible for this issue. The adopted solution was a workaround and the deep link problem is not completely solved. There is another action issue for it. So I think we can skip the root PR for this.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Steps
Test RHP deeplink
Test Concierge deeplink
Test specific chat report deeplink
Test annonymous user claiming their account from public room
Do you agree 👍 or 👎 ?
abekkala commentedon Sep 19, 2023
@tienifr and @hungvu193 payments have been made and contracts ended. Thank you! 🎉
@parasharrajat have you already requested manually payment in EChat yet?
parasharrajat commentedon Sep 19, 2023
No, I will do that later. Feel free to close if you want.
mountiny commentedon Sep 21, 2023
Thanks everyone!
lcsvcn commentedon Sep 25, 2023
This issue is still a blocker for this bug fix to be open?
@dhanashree-sawant reported it first here, I noticed today that it is still reproducible on latest version and I have a proposal to fix this issue.
Thanks!
mountiny commentedon Sep 25, 2023
@lcsvcn I dont think that is related to this issue, the bug report should be created separately for a new GH ticket
lcsvcn commentedon Sep 25, 2023
It is related because it was marked as blocker to create the issue, if you check this slack thread
hungvu193 commentedon Sep 25, 2023
I checked the thread, it's not related to this one, Kavi posted the wrong link.
lcsvcn commentedon Sep 25, 2023
Oh, I see. what is the correct link, please? Do you know?
parasharrajat commentedon Oct 13, 2023
Payment requested as per #26852 (comment)
JmillsExpensify commentedon Oct 13, 2023
$1,500 payment approved for @parasharrajat based on BZ summary.