Skip to content

[PAID] [$1000] Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending #26942

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app and click on a chat
  2. Type into the chat:
    # [google1
    google2
    google3](https://www.google.com)
  1. Try to edit the typed comment. Notice that it has a different markdown structure:
    # [google1](https://www.google.com)
    google2
    google3

Expected Result:

User sending an URL, with 3 rows of multiline message in [ ],all are shown as URL.

Similarly,User sending an URL including header markdown, with 3 rows of multiline message in [ ], all 3 rows multiline message must be shown as URL.

The Header markdown, multiline message with URL, must not display in different format while editing. All three rows of multiline message should display inside [ ], as entered by user

Actual Result:

User sending an URL, with 3 rows of multiline message in [ ],all are shown as URL.

User sending an URL including header markdown, with 3 rows of multiline message in [ ], only first row message is shown as url and remaining two rows message shown as text.

The Header markdown, multiline message with URL, displays in different format while editing. First row text entered only shown inside [ ], and for remaining 2 rows message format changed and shown outside [ ].

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.65-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6191062_line_order.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cf462eb26aa8fbe1
  • Upwork Job ID: 1701242002102861824
  • Last Price Increase: 2023-09-28
Issue OwnerCurrent Issue Owner: @robertKozik
Issue OwnerCurrent Issue Owner: @robertKozik

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 7, 2023
  2. melvin-bot commented on Sep 7, 2023

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 7, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. melvin-bot commented on Sep 11, 2023

    @melvin-bot

    @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. melvin-bot commented on Sep 11, 2023

    @melvin-bot

    @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. strepanier03 commented on Sep 11, 2023

    @strepanier03
    Contributor

    Working on this now, I've been ill.

  7. strepanier03 commented on Sep 11, 2023

    @strepanier03
    Contributor

    Repro'd following steps.

    image

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 11, 2023
  9. changed the title [-]Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending[/-] [+][$500] Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending[/+] on Sep 11, 2023
  10. melvin-bot commented on Sep 11, 2023

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 11, 2023
  12. 133 remaining items

  13. strepanier03 commented on Nov 30, 2023

    @strepanier03
    Contributor

    @r3770 - Please apply for the job here, I've attempted to hire you directly to it but because your Upwork profile is private I cannot.

  14. r3770 commented on Nov 30, 2023

    @r3770
    Contributor

    @strepanier03
    I've applied, could you please check ?

  15. robertKozik commented on Nov 30, 2023

    @robertKozik
    Contributor
    • [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: That was case not handled before
    • [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@robertKozik] Determine if we should create a regression test for this bug. N/A there are implemented unit tests which covers this case
    • [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
  16. strepanier03 commented on Nov 30, 2023

    @strepanier03
    Contributor

    Thank you @r3770 I'm working on payment now.

    Thank you @robertKozik as well!

    Update in a moment.

  17. strepanier03 commented on Nov 30, 2023

    @strepanier03
    Contributor

    @r3770 - There's no applications on the job :(

  18. strepanier03 commented on Nov 30, 2023

    @strepanier03
    Contributor

    Hmm, actually I think something is up with Upwork.

    When I view your profile I can see that you've applied, although there's no way to accept the application from within your profile.

    image

    However when I view the actual job, your application is not listed.

    I'll see if I can figure this out and message Upwork's support if I have to.

  19. r3770 commented on Nov 30, 2023

    @r3770
    Contributor

    @strepanier03 Here is what I applied

    image

  20. strepanier03 commented on Nov 30, 2023

    @strepanier03
    Contributor

    @r3770 - I found a workaround but had to send you an offer for the job. Please accept that offer then let me know here, and I'll circle back to this payment before I leave for the day.

  21. r3770 commented on Nov 30, 2023

    @r3770
    Contributor

    @strepanier03
    Offer accepted, Thanks

  22. strepanier03 commented on Nov 30, 2023

    @strepanier03
    Contributor

    I see you did it right away so I just paid it as well!

  23. strepanier03 commented on Nov 30, 2023

    @strepanier03
    Contributor

    Thank you again for your quick communication @r3770, I'm sorry this went unhandled for this long.

  24. strepanier03 commented on Nov 30, 2023

    @strepanier03
    Contributor

    Since the checklist is done and no regression test is suggested I'm going to close this out. Thanks everyone and thank you for the 1:1 message @cead22 🙌

  25. changed the title [-][HOLD for payment 2023-11-17] [$1000] Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending[/-] [+][PAID] [$1000] Android-Compose- Header markdown-multiline with URL, vary in format while editing & sending[/+] on Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions