You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-17] [HOLD for payment 2024-01-11] [$500] Android- IOU-When user changes Stop address, the Request money amount is not updated #26946
Note the distance details and request money amount is correct (15.39*2=₹30.78) i. e shown as ₹30.77
Tap back to distance money request page
Tap Stop
Replace the entered address with a new one
Tap next
Select a Workspace
Note the distance field and request money amount (9.68*2=₹19.36)
Expected Result:
When user changes Stop address, the Request money amount should be updated based on new distance.
Actual Result:
When user changes Stop address, the Request money amount is not updated. The distance amount(15.39*2=₹30.78) before changing address is shown even after changing the address.
For new distance when address changed (9.68*2=₹19.36) , but still old amount ₹30.77 is displayed.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
changed the title [-]Android- IOU-When user changes Stop address, the Request money amount is not updated[/-][+][$500] Android- IOU-When user changes Stop address, the Request money amount is not updated[/+]on Sep 8, 2023
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
No need for additional discussion
Determine if we should create a regression test for this bug.
Up to the QA team
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Create new distance request
Fill start point and end point
Go to confirmation page and observe the amount field
Click back to the distance page and edit waypoint
Go to confirmation page and verify that the amount is updated
Activity
melvin-bot commentedon Sep 7, 2023
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dukenv0307 commentedon Sep 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
distance - Amount isn't recalculated on changing waypoints
What is the root cause of that problem?
We only calculate when the amount is 0 and the request is distance. So when we edit the waypoint again, the amount is not recalculated
App/src/components/MoneyRequestConfirmationList.js
Line 173 in 1eafc7d
What changes do you think we should make in order to solve the problem?
We should always calculate the amount when the distance is changed by changing the check here to
App/src/components/MoneyRequestConfirmationList.js
Line 173 in 1eafc7d
What alternative solutions did you explore? (Optional)
Whenever we edit the waypoint we will reset the amount to
0to make it re-calculate inMoneyRequestConfirmationList[-]Android- IOU-When user changes Stop address, the Request money amount is not updated[/-][+][$500] Android- IOU-When user changes Stop address, the Request money amount is not updated[/+]melvin-bot commentedon Sep 8, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01f82f14ed7e096782
melvin-bot commentedon Sep 8, 2023
Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 8, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (
External)ashimsharma10 commentedon Sep 8, 2023
Have posted this before,
https://expensify.slack.com/archives/C049HHMV9SM/p1693984012665899
jeet-dhandha commentedon Sep 8, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
shouldCalculateDistanceAmountflag is not set totruewhen the distance is changed. due to theprops.iouAmount === 0condition.What changes do you think we should make in order to solve the problem?
We can simply remove the
shouldCalculateDistanceAmountflag and replace it withprops.isDistanceRequest.Keeping the
shouldCalculateDistanceAmountflag doesn't make sense anymore since we are always calculating the amount when its a distance request.This will solve two problems:
What alternative solutions did you explore? (Optional)
130 remaining items
CortneyOfstad commentedon Jan 17, 2024
Payments have been completed!
Payment Summary
@cubuspl42 paid $250 as C+ (-50% due to regression) in Upwork
@DylanDylann paid $250 as Contributor (-50% due to regression) in Upwork
CortneyOfstad commentedon Jan 17, 2024
@cubuspl42 any update on the checklist above? Thanks!
ashimsharma10 commentedon Jan 17, 2024
@CortneyOfstad Waiting for payment.
I'm the issue reporter.
Thanks.
CortneyOfstad commentedon Jan 17, 2024
Thanks @ashimsharma10 — sorry about that!
I had to create a new job post since the old one expired. I've sent you an offer here — https://www.upwork.com/jobs/~01d9cdd3e5a961ef64.
Please let me know once you accept and I can get that paid ASAP. Thanks!
jakub-trzebiatowski commentedon Jan 18, 2024
MoneyRequestConfirmPagefor Distance Request #25707CortneyOfstad commentedon Jan 18, 2024
Thanks @cubuspl42!
@ashimsharma10 any update on the proposal so I can get the payment processed? Thanks!
ashimsharma10 commentedon Jan 19, 2024
@CortneyOfstad I'm not able to apply.
my upwork is this : https://www.upwork.com/freelancers/~018a92cf13e1e88eed
CortneyOfstad commentedon Jan 22, 2024
@ashimsharma10 that Upwork profile is where I sent the proposal. I just sent it again 👍
CortneyOfstad commentedon Jan 24, 2024
@ashimsharma10 sorry for the delay here — finalized the payment this morning so you're all set!
Regression test has been created here, so this is all set to be closed!