You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove ReportActionsUtils.getParentReportAction(), ReportUtils.getParentReport(), TransactionUtils.getLinkedTransaction(), ReportUtils.getPolicy(), and TransactionUtils.getTransaction() #27262
These methods are anti-patterns because they are most always used for loading data into a component without using withOnyx(). This breaks the data flow of a react application. (data is coming from somewhere that is not props or state and cannot be debugged in react dev tools).
Solution
Switch all references to properly use withOnyx() for components and connect() for libs.
changed the title [-]Remove ReportActionsUtils.getParentReportAction() and TransactionUtils.getLinkedTransaction()[/-][+]Remove ReportActionsUtils.getParentReportAction(), TransactionUtils.getLinkedTransaction(), and TransactionUtils.getTransaction()[/+]on Sep 12, 2023
This issue has not been updated in over 15 days. @tgolen eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
[-]Remove ReportActionsUtils.getParentReportAction() and TransactionUtils.getLinkedTransaction()[/-][+]Remove ReportActionsUtils.getParentReportAction(), TransactionUtils.getLinkedTransaction(), and TransactionUtils.getTransaction()[/+]techievivek commentedon Sep 15, 2023
Adding @aimane-chnaif to the GH as he helped review the PR: https://expensify.slack.com/archives/C02NK2DQWUX/p1694749699352029
58 remaining items
tgolen commentedon Mar 29, 2024
Weekly Update
Next Steps
ReportUtilsonce all the current issues are doneETA
tgolen commentedon Apr 12, 2024
Weekly Update
Next Steps
ReportUtilsand make sure it is not exporting anything "bad", then this issue can be closedETA
tgolen commentedon May 3, 2024
Weekly Update
Next Steps
ETA
tgolen commentedon May 10, 2024
Weekly Update
tgolen commentedon May 17, 2024
Weekly Update
melvin-bot commentedon Jun 10, 2024
This issue has not been updated in over 15 days. @tgolen eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
tgolen commentedon Jul 26, 2024
ReportUtilsis the only remaining item, but I took a look at it and I think it's mostly fine for now so I am going to close this out.