You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-01-17] [$1000] Workspace - Expensify download link in the welcome message is not hyperlinked #27290
What changes do you think we should make in order to solve the problem?
We need to use replace method from ExpensiMark parser and parse the welcomeNote before sending invitations.
sendInvitation() {
Keyboard.dismiss();
const parser = new ExpensiMark();
const parsedWelcomeNote = parser.replace(this.state.welcomeNote);
Policy.addMembersToWorkspace(this.props.invitedEmailsToAccountIDsDraft, parsedWelcomeNote, this.props.route.params.policyID);
Policy.setWorkspaceInviteMembersDraft(this.props.route.params.policyID, {});
// Pop the invite message page before navigating to the members page.
Navigation.goBack();
Navigation.navigate(ROUTES.getWorkspaceMembersRoute(this.props.route.params.policyID));
}
changed the title [-]Workspace - Expensify download link in the welcome message is not hyperlinked[/-][+][$500] Workspace - Expensify download link in the welcome message is not hyperlinked[/+]on Sep 13, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
I'm back! sorry for the delay - the old Upwork job expired so I created a new one. @alitoshmatov and @situchan can you review the payment summary here and let me know if I'm missing anything?
if that is good please accept my offer in Upwork so I can pay you.
Activity
melvin-bot commentedon Sep 12, 2023
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 12, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Krishna2323 commentedon Sep 13, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - Expensify download link in the welcome message is not hyperlinked.
What is the root cause of that problem?
We are not parsing the text before passing it to
addMembersToWorkspace.App/src/pages/workspace/WorkspaceInviteMessagePage.js
Lines 120 to 127 in 9b0d92f
What changes do you think we should make in order to solve the problem?
We need to use
replacemethod fromExpensiMarkparser and parse the welcomeNote before sending invitations.Result:
fixed.mp4
[-]Workspace - Expensify download link in the welcome message is not hyperlinked[/-][+][$500] Workspace - Expensify download link in the welcome message is not hyperlinked[/+]melvin-bot commentedon Sep 13, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0130840f78177f0f3f
melvin-bot commentedon Sep 13, 2023
Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 13, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)alitoshmatov commentedon Sep 14, 2023
I have reported this issue before https://expensify.slack.com/archives/C049HHMV9SM/p1694444208170039 . Can someone check and confirm if I indeed reported it earlier?
Christinadobrzyn commentedon Sep 14, 2023
I agree, it does look like the same report - I will add you as the reporter to this job @alitoshmatov!
133 remaining items
melvin-bot commentedon Jan 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Jan 17, 2024
Payment Summary
Upwork Job
BugZero Checklist (@Christinadobrzyn)
cristipaval commentedon Jan 19, 2024
@Christinadobrzyn is OOO until Monday.
Christinadobrzyn commentedon Jan 23, 2024
I'm back! sorry for the delay - the old Upwork job expired so I created a new one. @alitoshmatov and @situchan can you review the payment summary here and let me know if I'm missing anything?
if that is good please accept my offer in Upwork so I can pay you.
alitoshmatov commentedon Jan 24, 2024
Accepted the offer.
situchan commentedon Jan 24, 2024
yes summary looks correct.
Accepted offer. Thanks
Christinadobrzyn commentedon Jan 26, 2024
Awesome! Paid out based on this payment summary #27290 (comment)
Closing this as complete! Thanks everyone!