Skip to content

[HOLD for payment 2024-01-17] [$1000] Workspace - Expensify download link in the welcome message is not hyperlinked #27290

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Invite a member to the workspace
  3. Navigate to the workspace chat with the invited member

Expected Result:

https://use.expensify.com/download
link in the welcome message is hyperlinked

Actual Result:

https://use.expensify.com/download
link in the welcome message is not hyperlinked, unless the message is edited and saved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.68-15

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6198051_20230913_021651.mp4

Expensify/Expensify Issue URL:

Issue reported by: @alitoshmatov

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694444208170039

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0130840f78177f0f3f
  • Upwork Job ID: 1702073199412563968
  • Last Price Increase: 2023-10-06

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 12, 2023
  2. melvin-bot commented on Sep 12, 2023

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 12, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. Krishna2323 commented on Sep 13, 2023

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Workspace - Expensify download link in the welcome message is not hyperlinked.

    What is the root cause of that problem?

    We are not parsing the text before passing it to addMembersToWorkspace.

    sendInvitation() {
    Keyboard.dismiss();
    Policy.addMembersToWorkspace(this.props.invitedEmailsToAccountIDsDraft, this.state.welcomeNote, this.props.route.params.policyID);
    Policy.setWorkspaceInviteMembersDraft(this.props.route.params.policyID, {});
    // Pop the invite message page before navigating to the members page.
    Navigation.goBack();
    Navigation.navigate(ROUTES.getWorkspaceMembersRoute(this.props.route.params.policyID));
    }

    What changes do you think we should make in order to solve the problem?

    We need to use replace method from ExpensiMark parser and parse the welcomeNote before sending invitations.

        sendInvitation() {
            Keyboard.dismiss();
    
            const parser = new ExpensiMark();
            const parsedWelcomeNote = parser.replace(this.state.welcomeNote);
    
            Policy.addMembersToWorkspace(this.props.invitedEmailsToAccountIDsDraft, parsedWelcomeNote, this.props.route.params.policyID);
            Policy.setWorkspaceInviteMembersDraft(this.props.route.params.policyID, {});
            // Pop the invite message page before navigating to the members page.
            Navigation.goBack();
            Navigation.navigate(ROUTES.getWorkspaceMembersRoute(this.props.route.params.policyID));
        }
    

    Result:

    fixed.mp4
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 13, 2023
  6. changed the title [-]Workspace - Expensify download link in the welcome message is not hyperlinked[/-] [+][$500] Workspace - Expensify download link in the welcome message is not hyperlinked[/+] on Sep 13, 2023
  7. melvin-bot commented on Sep 13, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 13, 2023
  9. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  11. alitoshmatov commented on Sep 14, 2023

    @alitoshmatov
    Contributor

    I have reported this issue before https://expensify.slack.com/archives/C049HHMV9SM/p1694444208170039 . Can someone check and confirm if I indeed reported it earlier?

  12. Christinadobrzyn commented on Sep 14, 2023

    @Christinadobrzyn
    Contributor

    I agree, it does look like the same report - I will add you as the reporter to this job @alitoshmatov!

  13. 133 remaining items

  14. melvin-bot commented on Jan 10, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-01-17. 🎊

    For reference, here are some details about the assignees on this issue:

    • @situchan requires payment (Needs manual offer from BZ)
    • @alitoshmatov requires payment (Needs manual offer from BZ)
  15. melvin-bot commented on Jan 10, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. melvin-bot commented on Jan 17, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@Christinadobrzyn)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1702073199412563968/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. cristipaval commented on Jan 19, 2024

    @cristipaval
    Contributor

    @Christinadobrzyn is OOO until Monday.

  18. Christinadobrzyn commented on Jan 23, 2024

    @Christinadobrzyn
    Contributor

    I'm back! sorry for the delay - the old Upwork job expired so I created a new one. @alitoshmatov and @situchan can you review the payment summary here and let me know if I'm missing anything?

    if that is good please accept my offer in Upwork so I can pay you.

  19. alitoshmatov commented on Jan 24, 2024

    @alitoshmatov
    Contributor

    Accepted the offer.

  20. situchan commented on Jan 24, 2024

    @situchan
    Contributor

    yes summary looks correct.
    Accepted offer. Thanks

  21. Christinadobrzyn commented on Jan 26, 2024

    @Christinadobrzyn
    Contributor

    Awesome! Paid out based on this payment summary #27290 (comment)

    Closing this as complete! Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions