You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [HOLD for payment 2023-09-21] Web - allStates.Greater London.stateName appears on select United state as Country #27325
Go to Settings >Profile > Personal details > Home address
Click on Country and select United state
Check the state
Expected Result:
should not show allStates.Greater London.stateName
Actual Result:
allStates.Greater London.stateName appears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.69.0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
After a state is selected, and the country is changed to USA, the StatePicker component breaks.
Note: in current main branch in dev, it doesn't just show allStates.Greater London.stateName – it breaks the app.
What is the root cause of that problem?
In AddressPage, the StatePicker component has the defaultValue set to the initially selected state.
Because of it, even though we reset the state on country change in handleAddressChange, the value of StatePicker does not change, since the defaultValue is already persisted the moment the StatePicker is rendered.
Activity
OSBotify commentedon Sep 13, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 13, 2023
Triggered auto assignment to @madmax330 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.paultsimura commentedon Sep 13, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
After a state is selected, and the country is changed to USA, the
StatePickercomponent breaks.Note: in current
mainbranch in dev, it doesn't just showallStates.Greater London.stateName– it breaks the app.What is the root cause of that problem?
In
AddressPage, theStatePickercomponent has thedefaultValueset to the initially selected state.Because of it, even though we reset the state on country change in
handleAddressChange, the value ofStatePickerdoes not change, since thedefaultValueis already persisted the moment theStatePickeris rendered.App/src/pages/settings/Profile/PersonalDetails/AddressPage.js
Lines 119 to 129 in 544661b
What changes do you think we should make in order to solve the problem?
My suggestion is to replace
defaultValuewithvalue. This will change the selected value in theStatePickerdynamically.App/src/pages/settings/Profile/PersonalDetails/AddressPage.js
Lines 187 to 191 in 544661b
<StatePicker inputID="state" - defaultValue={state} + value={state} onValueChange={handleAddressChange} />Result:
https://www.loom.com/share/17db17156d444b648b6382f0870c3489?sid=dee1c244-dc20-448f-81d8-ec9ca3546e8e
What alternative solutions did you explore? (Optional)
paultsimura commentedon Sep 13, 2023
@madmax330 since this is a blocker – is it still eligible for proposals? If yes – how often are they reviewed?
madmax330 commentedon Sep 13, 2023
@paultsimura I think someone already has the fix, we're just waiting for them to put up the PR
paultsimura commentedon Sep 13, 2023
I see this issue was referenced in a PR, but I doubt that PR fixes this issue - it doesn't look like a regression from the translations flattening.
Anyway, let's wait and see what the result would be.
madmax330 commentedon Sep 13, 2023
@paultsimura if you look at the testing videos in the PR description, it is fixed.
melvin-bot commentedon Sep 13, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
36 remaining items
melvin-bot commentedon Sep 27, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)greg-schroeder commentedon Sep 27, 2023
Just applying external to create an upwork job
madmax330 commentedon Sep 27, 2023
@greg-schroeder I think @parasharrajat gets paid in newDot, do we still need an upwork job for that?
greg-schroeder commentedon Sep 27, 2023
@madmax330 are we not paying the issue reporter?
dhanashree-sawant commentedon Sep 27, 2023
Yes my payment too is left 😅
madmax330 commentedon Sep 27, 2023
Ah yes, forgot about that, sorry :ohnothing:
greg-schroeder commentedon Sep 27, 2023
Issue Participants:
Issue reported by: @dhanashree-sawant hanashree-sawant
C+: @parasharrajat
Reporter: $50
C+: $500 (+$250 speed bonus)
offer sent to reporter, Rajat you can make a manual request in newdot
dhanashree-sawant commentedon Sep 27, 2023
Thanks @greg-schroeder, I have accepted the offer
parasharrajat commentedon Sep 27, 2023
@greg-schroeder Can you please assign me as well to the issue for tracking purposes?
parasharrajat commentedon Oct 8, 2023
Payment requested as per #27325 (comment)
JmillsExpensify commentedon Oct 9, 2023
$750 payment approved for @parasharrajat based on BZ summary.