Skip to content

[$500] [HOLD for payment 2023-09-21] Web - allStates.Greater London.stateName appears on select United state as Country #27325

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings >Profile > Personal details > Home address
  2. Click on Country and select United state
  3. Check the state

Expected Result:

should not show allStates.Greater London.stateName

Actual Result:

allStates.Greater London.stateName appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.69.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-13.at.2.58.39.PM.mov
Recording.4430.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694597057219419
Original reporter:
https://expensify.slack.com/archives/C049HHMV9SM/p1694597349412869

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e4437f3cf84845b7
  • Upwork Job ID: 1706865721848041472
  • Last Price Increase: 2023-09-27

Activity

  1. OSBotify commented on Sep 13, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. paultsimura commented on Sep 13, 2023

    @paultsimura
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After a state is selected, and the country is changed to USA, the StatePicker component breaks.

    Note: in current main branch in dev, it doesn't just show allStates.Greater London.stateName – it breaks the app.

    What is the root cause of that problem?

    In AddressPage, the StatePicker component has the defaultValue set to the initially selected state.

    Because of it, even though we reset the state on country change in handleAddressChange, the value of StatePicker does not change, since the defaultValue is already persisted the moment the StatePicker is rendered.

    const handleAddressChange = (value, key) => {
    if (key !== 'country' && key !== 'state') {
    return;
    }
    if (key === 'country') {
    setCurrentCountry(value);
    setState('');
    return;
    }
    setState(value);
    };

    What changes do you think we should make in order to solve the problem?

    My suggestion is to replace defaultValue with value. This will change the selected value in the StatePicker dynamically.

    <StatePicker
    inputID="state"
    defaultValue={state}
    onValueChange={handleAddressChange}
    />

                                <StatePicker
                                    inputID="state"
    -                               defaultValue={state}
    +                               value={state}
                                    onValueChange={handleAddressChange}
                                />

    Result:

    https://www.loom.com/share/17db17156d444b648b6382f0870c3489?sid=dee1c244-dc20-448f-81d8-ec9ca3546e8e

    What alternative solutions did you explore? (Optional)

  4. paultsimura commented on Sep 13, 2023

    @paultsimura
    Contributor

    @madmax330 since this is a blocker – is it still eligible for proposals? If yes – how often are they reviewed?

  5. madmax330 commented on Sep 13, 2023

    @madmax330
    Contributor

    @paultsimura I think someone already has the fix, we're just waiting for them to put up the PR

  6. paultsimura commented on Sep 13, 2023

    @paultsimura
    Contributor

    @paultsimura I think someone already has the fix, we're just waiting for them to put up the PR

    I see this issue was referenced in a PR, but I doubt that PR fixes this issue - it doesn't look like a regression from the translations flattening.

    Anyway, let's wait and see what the result would be.

  7. madmax330 commented on Sep 13, 2023

    @madmax330
    Contributor

    @paultsimura if you look at the testing videos in the PR description, it is fixed.

  8. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. 36 remaining items

  10. melvin-bot commented on Sep 27, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  11. greg-schroeder commented on Sep 27, 2023

    @greg-schroeder
    Contributor

    Just applying external to create an upwork job

  12. madmax330 commented on Sep 27, 2023

    @madmax330
    Contributor

    @greg-schroeder I think @parasharrajat gets paid in newDot, do we still need an upwork job for that?

  13. greg-schroeder commented on Sep 27, 2023

    @greg-schroeder
    Contributor

    @madmax330 are we not paying the issue reporter?

  14. dhanashree-sawant commented on Sep 27, 2023

    @dhanashree-sawant

    Yes my payment too is left 😅

  15. madmax330 commented on Sep 27, 2023

    @madmax330
    Contributor

    are we not paying the issue reporter?

    Ah yes, forgot about that, sorry :ohnothing:

  16. greg-schroeder commented on Sep 27, 2023

    @greg-schroeder
    Contributor

    Issue Participants:

    Issue reported by: @dhanashree-sawant hanashree-sawant
    C+: @parasharrajat

    Reporter: $50
    C+: $500 (+$250 speed bonus)

    offer sent to reporter, Rajat you can make a manual request in newdot

  17. dhanashree-sawant commented on Sep 27, 2023

    @dhanashree-sawant

    Thanks @greg-schroeder, I have accepted the offer

  18. parasharrajat commented on Sep 27, 2023

    @parasharrajat
    Member

    @greg-schroeder Can you please assign me as well to the issue for tracking purposes?

  19. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 28, 2023
  20. parasharrajat commented on Oct 8, 2023

    @parasharrajat
    Member

    Payment requested as per #27325 (comment)

  21. JmillsExpensify commented on Oct 9, 2023

    @JmillsExpensify
    Contributor

    $750 payment approved for @parasharrajat based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions