You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-05] [$500] Green Dot is Shown in the LHN but there is no Button to settle #27348
Request money and select the newly created workspace
Delete the workspace
Click on the requested money and notice no settle button there
Notice that there is a Green dot on the LHN
Expected Result:
No green dot on the LHN if there is no settle button
Actual Result:
There is a green dot.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.69-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Green Dot is Shown in the LHN but there is no Button to settle[/-][+][$500] Green Dot is Shown in the LHN but there is no Button to settle[/+]on Sep 13, 2023
changed the title [-][$500] Green Dot is Shown in the LHN but there is no Button to settle[/-][+][HOLD for payment 2023-10-05] [$500] Green Dot is Shown in the LHN but there is no Button to settle[/+]on Sep 28, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@0xmiroslav] Determine if we should create a regression test for this bug.
[@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
I think this is worth adding regression test as green dot in LHN will be confusing users.
Regression Test Proposal
Create new workspace
Request money on that workspace
Verify that green dot shows in LHN for the money request report row
Activity
melvin-bot commentedon Sep 13, 2023
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 13, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Green Dot is Shown in the LHN but there is no Button to settle[/-][+][$500] Green Dot is Shown in the LHN but there is no Button to settle[/+]melvin-bot commentedon Sep 13, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01537b6caa270fb519
melvin-bot commentedon Sep 13, 2023
Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Sep 13, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (
External)hungvu193 commentedon Sep 13, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Green Dot is Shown in the LHN but there is no Button to settle
What is the root cause of that problem?
We will hide the SettleButton when the request is canceled, but we didn't implement it for green dot.
What changes do you think we should make in order to solve the problem?
We should change this condition here:
App/src/components/LHNOptionsList/OptionRowLHN.js
Lines 105 to 109 in 6c6b3ad
to
What alternative solutions did you explore? (Optional)
Update the logic of
isWaitingForIOUActionFromCurrentUserfunction, if the parent report is archived, then we should return false.0xmiroslav commentedon Sep 16, 2023
@hungvu193 thanks for the proposal.
Do you have permalink where this logic is added?
hungvu193 commentedon Sep 17, 2023
I think here's is it: #27212
24 remaining items
[-][$500] Green Dot is Shown in the LHN but there is no Button to settle[/-][+][HOLD for payment 2023-10-05] [$500] Green Dot is Shown in the LHN but there is no Button to settle[/+]melvin-bot commentedon Sep 28, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 28, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Sep 28, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
dylanexpensify commentedon Oct 2, 2023
payment coming up!
dylanexpensify commentedon Oct 5, 2023
@0xmiroslav please accept the offer link so I can pay ya out! Also please complete the checklist 😄
dylanexpensify commentedon Oct 5, 2023
@hungvu193 @daveSeife payments sent!
0xmiroslav commentedon Oct 5, 2023
I think this is worth adding regression test as green dot in LHN will be confusing users.
Regression Test Proposal
dylanexpensify commentedon Oct 5, 2023
All done! TY!