Skip to content

[HOLD for payment 2023-10-05] [$500] Green Dot is Shown in the LHN but there is no Button to settle #27348

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create a new workspace
  2. Request money and select the newly created workspace
  3. Delete the workspace
  4. Click on the requested money and notice no settle button there
  5. Notice that there is a Green dot on the LHN

Expected Result:

No green dot on the LHN if there is no settle button

Actual Result:

There is a green dot.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.69-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

T149.Greendot-1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694609404430979

View all open jobs on GitHub

Recording.1585.mp4
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01537b6caa270fb519
  • Upwork Job ID: 1701955779855437824
  • Last Price Increase: 2023-09-13
  • Automatic offers:
    • 0xmiroslav | Reviewer | 26769100
    • hungvu193 | Contributor | 26769104
    • daveSeife | Reporter | 26769113

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 13, 2023
  2. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 13, 2023
  5. changed the title [-]Green Dot is Shown in the LHN but there is no Button to settle[/-] [+][$500] Green Dot is Shown in the LHN but there is no Button to settle[/+] on Sep 13, 2023
  6. melvin-bot commented on Sep 13, 2023

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 13, 2023
  8. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

  9. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

  10. hungvu193 commented on Sep 13, 2023

    @hungvu193
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Green Dot is Shown in the LHN but there is no Button to settle

    What is the root cause of that problem?

    We will hide the SettleButton when the request is canceled, but we didn't implement it for green dot.

    What changes do you think we should make in order to solve the problem?

    We should change this condition here:

    const shouldShowGreenDotIndicator =
    !hasBrickError &&
    (optionItem.isUnreadWithMention ||
    ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) ||
    (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom));

    to

    const isParentArchivedRoom =  ReportUtils.isArchivedRoom(ReportUtils.getReport(optionItem.parentReportID))
     const shouldShowGreenDotIndicator =
            !hasBrickError &&
            (optionItem.isUnreadWithMention ||
                (ReportUtils.isWaitingForIOUActionFromCurrentUser(optionItem) && !isParentArchivedRoom) ||
                (optionItem.isTaskReport && optionItem.isTaskAssignee && !optionItem.isCompletedTaskReport && !optionItem.isArchivedRoom));

    What alternative solutions did you explore? (Optional)

    Update the logic of isWaitingForIOUActionFromCurrentUser function, if the parent report is archived, then we should return false.

  11. 0xmiroslav commented on Sep 16, 2023

    @0xmiroslav
    Contributor

    @hungvu193 thanks for the proposal.

    We will hide the SettleButton when the request is canceled

    Do you have permalink where this logic is added?

  12. hungvu193 commented on Sep 17, 2023

    @hungvu193
    Contributor

    @hungvu193 thanks for the proposal.

    We will hide the SettleButton when the request is canceled

    Do you have permalink where this logic is added?

    I think here's is it: #27212

  13. 24 remaining items

  14. changed the title [-][$500] Green Dot is Shown in the LHN but there is no Button to settle[/-] [+][HOLD for payment 2023-10-05] [$500] Green Dot is Shown in the LHN but there is no Button to settle[/+] on Sep 28, 2023
  15. melvin-bot commented on Sep 28, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Sep 28, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-05. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  17. melvin-bot commented on Sep 28, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
    • [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@0xmiroslav] Determine if we should create a regression test for this bug.
    • [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. dylanexpensify commented on Oct 2, 2023

    @dylanexpensify
    Contributor

    payment coming up!

  19. dylanexpensify commented on Oct 5, 2023

    @dylanexpensify
    Contributor

    @0xmiroslav please accept the offer link so I can pay ya out! Also please complete the checklist 😄

  20. dylanexpensify commented on Oct 5, 2023

    @dylanexpensify
    Contributor

    @hungvu193 @daveSeife payments sent!

  21. 0xmiroslav commented on Oct 5, 2023

    @0xmiroslav
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: N/A
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug.
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    I think this is worth adding regression test as green dot in LHN will be confusing users.

    Regression Test Proposal

    1. Create new workspace
    2. Request money on that workspace
    3. Verify that green dot shows in LHN for the money request report row
    4. Delete the workspace
    5. Verify that green dot disappears from LHN
  22. dylanexpensify commented on Oct 5, 2023

    @dylanexpensify
    Contributor

    All done! TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions