Skip to content

[PAID] [$500] help.expensify.com is showing broken "Not found page" #27405

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to help.expensify.com/abcd
  2. Notice that there is overlapped not found text and broken image

Expected Result:

Should show correct image and text without any overlapping

Actual Result:

Shows overlapped text with broken image

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.69-0
Reproducible in staging?: n/a
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-23.at.18.17.16.mov

Expensify/Expensify Issue URL:
Issue reported by: @alitoshmatov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692796609530559

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0155f0466612861fa0
  • Upwork Job ID: 1702163572248096768
  • Last Price Increase: 2023-09-14

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 14, 2023
  2. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. mvtglobally commented on Sep 14, 2023

    @mvtglobally
    Author

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    help.expensify.com is showing broken "Not found page"

    What is the root cause of that problem?

    The image is broken because wrong image is being pointed to

    <img class="icon" src="/assets/images/hourglass.svg" />

    the existing file is called circle-hourglass
    The overlapping is happening because centered-content class has position: absolute

    App/docs/_sass/_main.scss

    Lines 566 to 570 in 867d61e

    .centered-content {
    height: 240px;
    text-align: center;
    font-size: larger;
    position: absolute;

    What changes do you think we should make in order to solve the problem?

    We should fix src of image to point to correct image.
    I am assuming the whole page should just show Hmm it's not here... and when scrolled down the footer should appear, but we can clarify exact design with responsible person.
    To achieve above mentioned case we just need to modify centered-content with something like this:

        width: 100%;
        height: calc(100vh - 56px);
        display: flex;
        flex-direction: column;
        align-items: center;
        justify-content: center;
        text-align: center;

    The result:
    Screenshot 2023-08-23 at 20 34 02
    https://github.com/Expensify/App/assets/59907218/0d86c098-4247-49fa-8b7d-4eb05f384ec2

    What alternative solutions did you explore? (Optional)

  4. changed the title [-]help.expensify.com is showing broken "Not found page"[/-] [+][$500] help.expensify.com is showing broken "Not found page"[/+] on Sep 14, 2023
  5. melvin-bot commented on Sep 14, 2023

    @melvin-bot
  6. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 14, 2023
  8. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  9. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

  10. mvtglobally commented on Sep 14, 2023

    @mvtglobally
    Author

    From Original contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    help.expensify.com is showing broken "Not found page"

    What is the root cause of that problem?

    The image is broken because wrong image is being pointed to

    <img class="icon" src="/assets/images/hourglass.svg" />

    the existing file is called circle-hourglass
    The overlapping is happening because centered-content class has position: absolute

    App/docs/_sass/_main.scss

    Lines 566 to 570 in 867d61e

    .centered-content {
    height: 240px;
    text-align: center;
    font-size: larger;
    position: absolute;

    What changes do you think we should make in order to solve the problem?

    We should fix src of image to point to correct image.
    I am assuming the whole page should just show Hmm it's not here... and when scrolled down the footer should appear, but we can clarify exact design with responsible person.
    To achieve above mentioned case we just need to modify centered-content with something like this:

        width: 100%;
        height: calc(100vh - 56px);
        display: flex;
        flex-direction: column;
        align-items: center;
        justify-content: center;
        text-align: center;

    The result:
    Screenshot 2023-08-23 at 20 34 02
    https://github.com/Expensify/App/assets/59907218/0d86c098-4247-49fa-8b7d-4eb05f384ec2

    What alternative solutions did you explore? (Optional)

  11. 29 remaining items

  12. added and removed on Oct 9, 2023
  13. strepanier03 commented on Oct 9, 2023

    @strepanier03
    Contributor

    @alitoshmatov - I have hired you in Upwork and will pay when you accept the job. I made one contract for both reporting and contributing and will apply a bonus for the reporting job.

    Thanks!

  14. alitoshmatov commented on Oct 9, 2023

    @alitoshmatov
    Contributor

    @strepanier03 Accepted

  15. alitoshmatov commented on Oct 12, 2023

    @alitoshmatov
    Contributor

    @strepanier03 Friendly bump on payment

  16. Beamanator commented on Oct 16, 2023

    @Beamanator
    Contributor

    Can this be closed? Or not quite yet?

  17. alitoshmatov commented on Oct 16, 2023

    @alitoshmatov
    Contributor

    I have received payment yet

  18. strepanier03 commented on Oct 17, 2023

    @strepanier03
    Contributor

    @alitoshmatov - I've paid both payments and closed the contract, thanks for your patience there was a lot on my plate to get through.


    @Beamanator - Unless there's something I'm not aware of that means we don't need it, we're waiting on the BZ checklist responses from @robertKozik and then I can make a regression if needed and close this GH.

  19. changed the title [-][HOLD for payment 2023-10-09] [$500] help.expensify.com is showing broken "Not found page"[/-] [+][PAID] [$500] help.expensify.com is showing broken "Not found page"[/+] on Oct 17, 2023
  20. robertKozik commented on Oct 17, 2023

    @robertKozik
    Contributor
  21. strepanier03 commented on Oct 17, 2023

    @strepanier03
    Contributor

    Thank you @robertKozik - Looks like we're all set to close since no regression test is needed.

    Cheers everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions