Skip to content

[HOLD for payment 2023-10-23] [$500] Android - Grant Camera Permission button not working on first click #27442

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Pre Requisite - Make sure camera permission is declined

  1. Open FAB, Click Request money -> Scan Receipt
  2. Click on Grant Permission.
  3. If Permission Pop up open, deny permission.
  4. Repeat 2 and 3 until redirected to settings, Close app and remove from recent
  5. Open App , Open FAB, Click Request money -> Scan Receipt
  6. Click on Grant Permission

Expected Result:

Linked to App settings (as request permission is blocked by OS)

Actual Result:

Clicking button does nothing on first click.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.70.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Record_2023-09-11-22-36-35.mp4
Screen_Recording_20230914_094815_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694451532440139

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019c4a398f728939bc
  • Upwork Job ID: 1702319435415248896
  • Last Price Increase: 2023-09-28
  • Automatic offers:
    • Ollyws | Reviewer | 26980712
    • zoontek | Contributor | 26980715
    • ishpaul777 | Reporter | 26980718
    • ntdiary | Contributor | 26981787

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 14, 2023
  2. changed the title [-]Android - Grant Camera Permission button not working on first click[/-] [+][$500] Android - Grant Camera Permission button not working on first click[/+] on Sep 14, 2023
  3. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Sep 14, 2023

    @melvin-bot
  5. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 14, 2023
  7. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  8. melvin-bot commented on Sep 14, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  9. akinwale commented on Sep 14, 2023

    @akinwale
    Contributor

    This may be a duplicate of #26499.

  10. trjExpensify commented on Sep 14, 2023

    @trjExpensify
    Contributor

    Yeah, it looks like it. @Julesssss, I'm going to close this but let me know if you disagree.

  11. 74 remaining items

  12. changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Grant Camera Permission button not working on first click[/-] [+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Grant Camera Permission button not working on first click[/+] on Oct 16, 2023
  13. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-23. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
    • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ntdiary] Determine if we should create a regression test for this bug.
    • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify / @kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Grant Camera Permission button not working on first click[/-] [+][HOLD for payment 2023-10-23] [$500] Android - Grant Camera Permission button not working on first click[/+] on Oct 23, 2023
  16. Julesssss commented on Oct 23, 2023

    @Julesssss
    Contributor

    Can be paid out today

  17. ntdiary commented on Oct 23, 2023

    @ntdiary
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    This is also a ux improvement. : )

  18. trjExpensify commented on Oct 23, 2023

    @trjExpensify
    Contributor

    Okay, so keeping these jobs separate for following the audit trail later if needs be. Confirming the payment summary as follows:

    No #urgency bonus applied as per here.

  19. zoontek commented on Oct 23, 2023

    @zoontek
    Contributor

    @trjExpensify Sorry, I accepted it.

  20. trjExpensify commented on Oct 23, 2023

    @trjExpensify
    Contributor

    Perfect, settled up with everyone. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions