You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-23] [$500] Android - Grant Camera Permission button not working on first click #27442
Pre Requisite - Make sure camera permission is declined
Open FAB, Click Request money -> Scan Receipt
Click on Grant Permission.
If Permission Pop up open, deny permission.
Repeat 2 and 3 until redirected to settings, Close app and remove from recent
Open App , Open FAB, Click Request money -> Scan Receipt
Click on Grant Permission
Expected Result:
Linked to App settings (as request permission is blocked by OS)
Actual Result:
Clicking button does nothing on first click.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.70.2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Android - Grant Camera Permission button not working on first click[/-][+][$500] Android - Grant Camera Permission button not working on first click[/+]on Sep 14, 2023
changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Grant Camera Permission button not working on first click[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Grant Camera Permission button not working on first click[/+]on Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
[@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ntdiary] Determine if we should create a regression test for this bug.
[@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify / @kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Grant Camera Permission button not working on first click[/-][+][HOLD for payment 2023-10-23] [$500] Android - Grant Camera Permission button not working on first click[/+]on Oct 23, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
[@ntdiary] Determine if we should create a regression test for this bug. No need
[@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
[@trjExpensify / @kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]Android - Grant Camera Permission button not working on first click[/-][+][$500] Android - Grant Camera Permission button not working on first click[/+]melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 14, 2023
Job added to Upwork: https://www.upwork.com/jobs/~019c4a398f728939bc
melvin-bot commentedon Sep 14, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to @trjExpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)akinwale commentedon Sep 14, 2023
This may be a duplicate of #26499.
trjExpensify commentedon Sep 14, 2023
Yeah, it looks like it. @Julesssss, I'm going to close this but let me know if you disagree.
74 remaining items
[-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Grant Camera Permission button not working on first click[/-][+][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Grant Camera Permission button not working on first click[/+]melvin-bot commentedon Oct 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Grant Camera Permission button not working on first click[/-][+][HOLD for payment 2023-10-23] [$500] Android - Grant Camera Permission button not working on first click[/+]Julesssss commentedon Oct 23, 2023
Can be paid out today
ntdiary commentedon Oct 23, 2023
This is also a ux improvement. : )
trjExpensify commentedon Oct 23, 2023
Okay, so keeping these jobs separate for following the audit trail later if needs be. Confirming the payment summary as follows:
No #urgency bonus applied as per here.
zoontek commentedon Oct 23, 2023
@trjExpensify Sorry, I accepted it.
trjExpensify commentedon Oct 23, 2023
Perfect, settled up with everyone. Closing!